github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6747] [MERGED] use consistent colours on the budget page #13764

New Issue
Closed
opened 2026-04-10 22:02:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 22:02:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6747
Author: @matt-fidd
Created: 1/22/2026
Status: ✅ Merged
Merged: 1/22/2026
Merged by: @matt-fidd

Base: master ← Head: colours/number

📝 Commits (8)

📊 Changes

38 files changed (+111 additions, -37 deletions)

View changed files

📝 packages/component-library/src/theme.ts (+9 -0)
📝 packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking--321fd-ed-amount-opens-the-budget-summary-menu-modal-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking--4bb70-ed-amount-opens-the-budget-summary-menu-modal-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking--94a85-ed-amount-opens-the-budget-summary-menu-modal-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Tracking-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Tracking-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Tracking-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.ts-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.ts-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.ts-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.ts-snapshots/Budget-transfer-funds-to-another-category-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.ts-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.ts-snapshots/Budget-transfer-funds-to-another-category-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/command-bar.test.ts-snapshots/Command-bar-Check-the-command-bar-search-works-correctly-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-help-menu-visuals-1-chromium-linux.png (+0 -0)

...and 18 more files

📄 Description

Opted for an inheritance system here to let us more easily change things in the future (and maybe a future iteration of custom themes could use these).

I've also moved to make the reports and account balance number colouring consistent with the budget pages as we were using slightly different shades across the app.

Also added a variable to let custom themes define a positive budget number colour (without templates) if they so desire, I've seen that requested a number of times.

It would be nice to get this in before release and put out these colour changes together (reports and budget) otherwise they reduce consistency across the light theme

Before (light):
image
image

After (light):
image
image

Before (dark):
image
image

After (dark):
image
image

Before (midnight):
image
image

After (midnight):
image
image

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 28 14.4 MB → 14.41 MB (+2.69 kB) +0.02%
loot-core 1 5.84 MB 0%
api 1 4.38 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
28 14.4 MB → 14.41 MB (+2.69 kB) +0.02%
Changeset
File Δ Size
src/components/reports/SummaryNumber.tsx 📈 +136 B (+5.76%) 2.31 kB → 2.44 kB
src/style/themes/development.ts 📈 +401 B (+4.86%) 8.07 kB → 8.46 kB
src/style/themes/dark.ts 📈 +401 B (+4.84%) 8.09 kB → 8.49 kB
src/style/themes/light.ts 📈 +401 B (+4.80%) 8.16 kB → 8.55 kB
src/style/themes/midnight.ts 📈 +373 B (+4.69%) 7.77 kB → 8.13 kB
home/runner/work/actual/actual/packages/component-library/src/theme.ts 📈 +511 B (+4.27%) 11.68 kB → 12.18 kB
src/components/budget/util.ts 📈 +116 B (+3.18%) 3.56 kB → 3.67 kB
src/components/mobile/transactions/FocusableAmountInput.tsx 📈 +226 B (+1.65%) 13.41 kB → 13.63 kB
src/components/mobile/accounts/AccountsPage.tsx 📈 +132 B (+0.61%) 21.3 kB → 21.43 kB
src/components/budget/envelope/budgetsummary/ToBudgetAmount.tsx 📈 +16 B (+0.37%) 4.2 kB → 4.22 kB
src/components/budget/BalanceWithCarryover.tsx 📈 +36 B (+0.36%) 9.75 kB → 9.78 kB
src/components/accounts/Balance.tsx 📈 +4 B (+0.03%) 11.21 kB → 11.21 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 9.24 MB → 9.24 MB (+2.42 kB) +0.03%
static/js/ReportRouter.js 1.05 MB → 1.05 MB (+136 B) +0.01%
static/js/narrow.js 640.86 kB → 640.99 kB (+132 B) +0.02%
static/js/wide.js 159.96 kB → 159.96 kB (+4 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/da.js 106.62 kB 0%
static/js/de.js 176.28 kB 0%
static/js/en-GB.js 6.98 kB 0%
static/js/en.js 159.37 kB 0%
static/js/es.js 171.98 kB 0%
static/js/fr.js 180.63 kB 0%
static/js/it.js 172.42 kB 0%
static/js/nb-NO.js 158.09 kB 0%
static/js/nl.js 103.35 kB 0%
static/js/pl.js 88.64 kB 0%
static/js/pt-BR.js 146.32 kB 0%
static/js/ru.js 106.97 kB 0%
static/js/sv.js 78.28 kB 0%
static/js/th.js 182.35 kB 0%
static/js/uk.js 216.34 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/TransactionList.js 101.58 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 11.79 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.84 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.BInehE-N.js 5.84 MB 0%

api

Total

Files count Total bundle size % Changed
1 4.38 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
bundle.api.js 4.38 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6747 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 1/22/2026 **Status:** ✅ Merged **Merged:** 1/22/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `colours/number` --- ### 📝 Commits (8) - [`11a5037`](https://github.com/actualbudget/actual/commit/11a50371bee99c6dc68fc12868e88613b5862e63) fix colouring of non-numerical summary cards - [`7fe7834`](https://github.com/actualbudget/actual/commit/7fe7834da7fb458565e306d61d754ff61704d633) define new colours - [`e3c0212`](https://github.com/actualbudget/actual/commit/e3c0212c33db466c78894d50acfc5d9971fdb268) use new colours on budget page - [`4d9a783`](https://github.com/actualbudget/actual/commit/4d9a783b27ea5f1b0afb2596c13530e8113f7e0d) use colours on account pages - [`d3974c8`](https://github.com/actualbudget/actual/commit/d3974c811d7a3a7700ee3349efb5448dc1af5ae6) note - [`ff4e3e7`](https://github.com/actualbudget/actual/commit/ff4e3e73dcbd67bee9321647ee7a98339e43f9fd) Update VRT screenshots - [`f60952f`](https://github.com/actualbudget/actual/commit/f60952f54e8b9b0a078b6be1a08ce8792035ca89) fix mobile colouring - [`a6713b7`](https://github.com/actualbudget/actual/commit/a6713b7569156747ecdc9d4e9ce70f03d45a0867) Update VRT screenshots ### 📊 Changes **38 files changed** (+111 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/src/theme.ts` (+9 -0) 📝 `packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking--321fd-ed-amount-opens-the-budget-summary-menu-modal-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking--4bb70-ed-amount-opens-the-budget-summary-menu-modal-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking--94a85-ed-amount-opens-the-budget-summary-menu-modal-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Tracking-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Tracking-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Tracking-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.ts-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.ts-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.ts-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.ts-snapshots/Budget-transfer-funds-to-another-category-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.ts-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.ts-snapshots/Budget-transfer-funds-to-another-category-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/command-bar.test.ts-snapshots/Command-bar-Check-the-command-bar-search-works-correctly-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-help-menu-visuals-1-chromium-linux.png` (+0 -0) _...and 18 more files_ </details> ### 📄 Description Opted for an inheritance system here to let us more easily change things in the future (and maybe a future iteration of custom themes could use these). I've also moved to make the reports and account balance number colouring consistent with the budget pages as we were using slightly different shades across the app. Also added a variable to let custom themes define a positive budget number colour (without templates) if they so desire, I've seen that requested a number of times. It would be nice to get this in before release and put out these colour changes together (reports and budget) otherwise they reduce consistency across the light theme Before (light): <img width="683" height="313" alt="image" src="https://github.com/user-attachments/assets/d14248c6-bf5c-4e25-b0ff-ec85073e5fc4" /> <img width="954" height="695" alt="image" src="https://github.com/user-attachments/assets/83b88c05-3f6f-499a-9486-5e19b91ac2aa" /> After (light): <img width="680" height="313" alt="image" src="https://github.com/user-attachments/assets/8c5cd4ee-cc18-4f9d-9b75-0da999ddda5e" /> <img width="952" height="703" alt="image" src="https://github.com/user-attachments/assets/18d3e428-1b3e-4ac0-a7de-e9cd1d3befb4" /> Before (dark): <img width="683" height="309" alt="image" src="https://github.com/user-attachments/assets/21623b21-9019-4e2b-9b0c-3d9a59e71138" /> <img width="935" height="698" alt="image" src="https://github.com/user-attachments/assets/aab17f04-3aad-48df-a478-c07da23f27c4" /> After (dark): <img width="684" height="311" alt="image" src="https://github.com/user-attachments/assets/ea53fe25-9d6c-452f-9968-abfa209ca300" /> <img width="940" height="698" alt="image" src="https://github.com/user-attachments/assets/49febc5b-be0b-4448-a9ef-446cb33c6be9" /> Before (midnight): <img width="682" height="313" alt="image" src="https://github.com/user-attachments/assets/039688cb-e8cc-42f4-8cfe-457e9b27f9a4" /> <img width="940" height="698" alt="image" src="https://github.com/user-attachments/assets/cc44af5d-a6d3-4cc4-9bb0-e67808ed6559" /> After (midnight): <img width="686" height="312" alt="image" src="https://github.com/user-attachments/assets/1f8df894-b938-438c-a6c3-1a1c5a05816a" /> <img width="941" height="697" alt="image" src="https://github.com/user-attachments/assets/4224f5bb-5e8b-48bc-a527-a8c487cd8d4e" /> <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 28 | 14.4 MB → 14.41 MB (+2.69 kB) | +0.02% loot-core | 1 | 5.84 MB | 0% api | 1 | 4.38 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 28 | 14.4 MB → 14.41 MB (+2.69 kB) | +0.02% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/reports/SummaryNumber.tsx` | 📈 +136 B (+5.76%) | 2.31 kB → 2.44 kB `src/style/themes/development.ts` | 📈 +401 B (+4.86%) | 8.07 kB → 8.46 kB `src/style/themes/dark.ts` | 📈 +401 B (+4.84%) | 8.09 kB → 8.49 kB `src/style/themes/light.ts` | 📈 +401 B (+4.80%) | 8.16 kB → 8.55 kB `src/style/themes/midnight.ts` | 📈 +373 B (+4.69%) | 7.77 kB → 8.13 kB `home/runner/work/actual/actual/packages/component-library/src/theme.ts` | 📈 +511 B (+4.27%) | 11.68 kB → 12.18 kB `src/components/budget/util.ts` | 📈 +116 B (+3.18%) | 3.56 kB → 3.67 kB `src/components/mobile/transactions/FocusableAmountInput.tsx` | 📈 +226 B (+1.65%) | 13.41 kB → 13.63 kB `src/components/mobile/accounts/AccountsPage.tsx` | 📈 +132 B (+0.61%) | 21.3 kB → 21.43 kB `src/components/budget/envelope/budgetsummary/ToBudgetAmount.tsx` | 📈 +16 B (+0.37%) | 4.2 kB → 4.22 kB `src/components/budget/BalanceWithCarryover.tsx` | 📈 +36 B (+0.36%) | 9.75 kB → 9.78 kB `src/components/accounts/Balance.tsx` | 📈 +4 B (+0.03%) | 11.21 kB → 11.21 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.24 MB → 9.24 MB (+2.42 kB) | +0.03% static/js/ReportRouter.js | 1.05 MB → 1.05 MB (+136 B) | +0.01% static/js/narrow.js | 640.86 kB → 640.99 kB (+132 B) | +0.02% static/js/wide.js | 159.96 kB → 159.96 kB (+4 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/da.js | 106.62 kB | 0% static/js/de.js | 176.28 kB | 0% static/js/en-GB.js | 6.98 kB | 0% static/js/en.js | 159.37 kB | 0% static/js/es.js | 171.98 kB | 0% static/js/fr.js | 180.63 kB | 0% static/js/it.js | 172.42 kB | 0% static/js/nb-NO.js | 158.09 kB | 0% static/js/nl.js | 103.35 kB | 0% static/js/pl.js | 88.64 kB | 0% static/js/pt-BR.js | 146.32 kB | 0% static/js/ru.js | 106.97 kB | 0% static/js/sv.js | 78.28 kB | 0% static/js/th.js | 182.35 kB | 0% static/js/uk.js | 216.34 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/TransactionList.js | 101.58 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 11.79 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.84 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BInehE-N.js | 5.84 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.38 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.38 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 22:02:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#13764
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?