github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-11 09:03:36 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #750] [MERGED] Reduce client build size by 1MB #136799

New Issue
Closed
opened 2026-06-19 01:32:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-19 01:32:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/750
Author: @j-f1
Created: 3/14/2023
Status: ✅ Merged
Merged: 3/14/2023
Merged by: @j-f1

Base: master ← Head: jed/bump-browserslist

📝 Commits (1)

  • 56daf78 Centralize the browserslist, switch defaults + electron 12

📊 Changes

3 files changed (+7 additions, -9 deletions)

View changed files

📝 package.json (+5 -1)
📝 packages/desktop-client/package.json (+1 -4)
📝 packages/loot-design/package.json (+1 -4)

📄 Description

before:

kcab.worker.4bdc73a8d45eb2115156.js (2.1 MiB)
xfo.kcab.worker.4bdc73a8d45eb2115156.js (1010 KiB)

after:

kcab.worker.39f5fba82d7bc7477962.js (1.41 MiB)
xfo.kcab.worker.39f5fba82d7bc7477962.js (1000 KiB)

What’s changed:

  • loot-core did not have a browserslist config, so @babel/preset-env assumes we want to transpile all the way back to ES5. I’ve removed the browserslist config from each of the package.json files and moved it to the root so this doesn’t happen again.
  • I updated the target from electron 3.0 to electron 12.0 to match our Electron dependency
  • I’ve added defaults (currently equivalent to > 0.5%, last 2 versions, Firefox ESR, not dead) which is recommended by browserslist. We could consider tightening this, but it doesn’t offer a ton of space savings at this point to just target Electron 12.
  • Since much less transpilation will be happening, stack traces (dev and prod) will be much easier to read!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/750 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 3/14/2023 **Status:** ✅ Merged **Merged:** 3/14/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/bump-browserslist` --- ### 📝 Commits (1) - [`56daf78`](https://github.com/actualbudget/actual/commit/56daf7844efbe046b86a9e6a63694a0055a219d0) Centralize the browserslist, switch defaults + electron 12 ### 📊 Changes **3 files changed** (+7 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+5 -1) 📝 `packages/desktop-client/package.json` (+1 -4) 📝 `packages/loot-design/package.json` (+1 -4) </details> ### 📄 Description before: ``` kcab.worker.4bdc73a8d45eb2115156.js (2.1 MiB) xfo.kcab.worker.4bdc73a8d45eb2115156.js (1010 KiB) ``` after: ``` kcab.worker.39f5fba82d7bc7477962.js (1.41 MiB) xfo.kcab.worker.39f5fba82d7bc7477962.js (1000 KiB) ``` What’s changed: - `loot-core` did not have a `browserslist` config, so `@babel/preset-env` assumes we want to [transpile all the way back to ES5](https://babeljs.io/docs/options#no-targets). I’ve removed the `browserslist` config from each of the `package.json` files and moved it to the root so this doesn’t happen again. - I updated the target from `electron 3.0` to `electron 12.0` to match our Electron dependency - I’ve added `defaults` (currently equivalent to `> 0.5%, last 2 versions, Firefox ESR, not dead`) which is [recommended by browserslist](https://browsersl.ist/#q=defaults). We could consider tightening this, but it doesn’t offer a ton of space savings at this point to just target Electron 12. - Since much less transpilation will be happening, stack traces (dev and prod) will be much easier to read! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-19 01:32:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#136799
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?