github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6569] [MERGED] fix: skip schedule prompt for transactions already linked to schedule #13663

New Issue
Closed
opened 2026-04-10 22:00:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 22:00:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6569
Author: @majiayu000
Created: 1/6/2026
Status: ✅ Merged
Merged: 1/13/2026
Merged by: @matt-fidd

Base: master ← Head: fix/6357-mobile-schedule-prompt

📝 Commits (7)

  • fa29780 fix: skip schedule prompt for transactions already linked to schedule
  • 0c6d26f fix: resolve build and lint issues in TransactionEdit.tsx
  • 63da510 docs: add release notes for PR #6569
  • 5d340da Merge branch 'master' into fix/6357-mobile-schedule-prompt
  • 9491249 chore: remove duplicate release note file
  • 2718d4f chore: rename release note file to match PR number
  • 948fd4e fix: apply schedule prompt fix to desktop version

📊 Changes

3 files changed (+18 additions, -7 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx (+4 -5)
📝 packages/desktop-client/src/components/transactions/TransactionList.tsx (+8 -2)
➕ upcoming-release-notes/6569.md (+6 -0)

📄 Description

Summary

  • Fixes schedule prompt appearing when editing transactions already linked to a schedule on mobile

Changes

  • Adds check for unserializedTransaction.schedule before showing the convert-to-schedule prompt
  • If transaction is already linked to a schedule, skip the prompt and proceed with normal save

Test Plan

  • Verified yarn typecheck passes
  • Verified yarn lint:fix passes
  • Verified yarn test passes
  • Manual testing: edit scheduled transaction on mobile, verify no schedule prompt appears

Fixes #6357

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6569 **Author:** [@majiayu000](https://github.com/majiayu000) **Created:** 1/6/2026 **Status:** ✅ Merged **Merged:** 1/13/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `fix/6357-mobile-schedule-prompt` --- ### 📝 Commits (7) - [`fa29780`](https://github.com/actualbudget/actual/commit/fa29780035670022678a70a0f5845baf66cf3366) fix: skip schedule prompt for transactions already linked to schedule - [`0c6d26f`](https://github.com/actualbudget/actual/commit/0c6d26fc7da47005ee87c2007819fc74c113ae5f) fix: resolve build and lint issues in TransactionEdit.tsx - [`63da510`](https://github.com/actualbudget/actual/commit/63da510971a5e2e14b4c47f5c95cc6280a83753a) docs: add release notes for PR #6569 - [`5d340da`](https://github.com/actualbudget/actual/commit/5d340dac44f020be4bc2226f1a2563516eecdeb4) Merge branch 'master' into fix/6357-mobile-schedule-prompt - [`9491249`](https://github.com/actualbudget/actual/commit/949124922777dce87c249df5c77f1dee50d36695) chore: remove duplicate release note file - [`2718d4f`](https://github.com/actualbudget/actual/commit/2718d4fbb04ee2679e23dd3c811d53dbe87747a7) chore: rename release note file to match PR number - [`948fd4e`](https://github.com/actualbudget/actual/commit/948fd4e37f632c48eb698fbf449f9add288b95ea) fix: apply schedule prompt fix to desktop version ### 📊 Changes **3 files changed** (+18 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx` (+4 -5) 📝 `packages/desktop-client/src/components/transactions/TransactionList.tsx` (+8 -2) ➕ `upcoming-release-notes/6569.md` (+6 -0) </details> ### 📄 Description ## Summary - Fixes schedule prompt appearing when editing transactions already linked to a schedule on mobile ## Changes - Adds check for `unserializedTransaction.schedule` before showing the convert-to-schedule prompt - If transaction is already linked to a schedule, skip the prompt and proceed with normal save ## Test Plan - [x] Verified `yarn typecheck` passes - [x] Verified `yarn lint:fix` passes - [x] Verified `yarn test` passes - [x] Manual testing: edit scheduled transaction on mobile, verify no schedule prompt appears Fixes #6357 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 22:00:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#13663
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?