[Bug]: Reconciliation box closing immediately when using return key to open #1366

Closed
opened 2026-02-28 19:41:46 -06:00 by GiteaMirror · 6 comments
Owner

Originally created by @matt-fidd on GitHub (Aug 29, 2024).

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

To reproduce:

  1. Open an account
  2. Open initial reconcile amount input
  3. Enter amount different to account balance
  4. Press enter/return
  5. Main reconciliation box opens then immediately shuts

Does not happen when reconcile button clicked with mouse

https://github.com/user-attachments/assets/17377407-f382-4879-851b-607906ca9661

Possibly related to #2974

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Chrome

Operating System

Windows 11

Originally created by @matt-fidd on GitHub (Aug 29, 2024). ### Verified issue does not already exist? - [X] I have searched and found no existing issue - [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file) ### What happened? To reproduce: 1. Open an account 2. Open initial reconcile amount input 3. Enter amount different to account balance 4. Press enter/return 5. Main reconciliation box opens then immediately shuts Does not happen when reconcile button clicked with mouse https://github.com/user-attachments/assets/17377407-f382-4879-851b-607906ca9661 Possibly related to #2974 ### Where are you hosting Actual? Locally via Yarn ### What browsers are you seeing the problem on? Chrome ### Operating System Windows 11
GiteaMirror added the bug label 2026-02-28 19:41:46 -06:00
Author
Owner

@matt-fidd commented on GitHub (Aug 29, 2024):

Confirmed caused by #2974

@matt-fidd commented on GitHub (Aug 29, 2024): Confirmed caused by #2974
Author
Owner

@psybers commented on GitHub (Aug 30, 2024):

Interesting. Probably the key down event triggers the primary button of that dialog, and then the key up event immediately triggers the primary of the next dialog.

@psybers commented on GitHub (Aug 30, 2024): Interesting. Probably the key down event triggers the primary button of that dialog, and then the key up event immediately triggers the primary of the next dialog.
Author
Owner

@psybers commented on GitHub (Sep 2, 2024):

@MatissJanis to be clear, #3338 fixes the bug by reverting the prior change. Thus, the functionality is sub-optimal still just in a different way.

@psybers commented on GitHub (Sep 2, 2024): @MatissJanis to be clear, #3338 fixes the bug by reverting the prior change. Thus, the functionality is sub-optimal still just in a different way.
Author
Owner

@MatissJanis commented on GitHub (Sep 2, 2024):

What’s the sub-optimality? I couldn’t spot any issues when spot checking.

On Monday, Sep 02, 2024 at 5:15 a.m., Robert Dyer @.*** @.***)> wrote:

@MatissJanis (https://github.com/MatissJanis) to be clear, #3338 (https://github.com/actualbudget/actual/pull/3338) fixes the bug by reverting the prior change. Thus, the functionality is sub-optimal still just in a different way.


Reply to this email directly, view it on GitHub (https://github.com/actualbudget/actual/issues/3330#issuecomment-2323780034), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAGYOJ3ABJ32CE45LSBMNGDZUPQ4LAVCNFSM6AAAAABNLKKMJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRTG44DAMBTGQ).
You are receiving this because you were mentioned.Message ID: @.***>

@MatissJanis commented on GitHub (Sep 2, 2024): What’s the sub-optimality? I couldn’t spot any issues when spot checking. > On Monday, Sep 02, 2024 at 5:15 a.m., Robert Dyer ***@***.*** ***@***.***)> wrote: > > > > > @MatissJanis (https://github.com/MatissJanis) to be clear, #3338 (https://github.com/actualbudget/actual/pull/3338) fixes the bug by reverting the prior change. Thus, the functionality is sub-optimal still just in a different way. > > > — > Reply to this email directly, view it on GitHub (https://github.com/actualbudget/actual/issues/3330#issuecomment-2323780034), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAGYOJ3ABJ32CE45LSBMNGDZUPQ4LAVCNFSM6AAAAABNLKKMJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRTG44DAMBTGQ). > You are receiving this because you were mentioned.Message ID: ***@***.***> > > >
Author
Owner

@psybers commented on GitHub (Sep 2, 2024):

What’s the sub-optimality? I couldn’t spot any issues when spot checking.

@MatissJanis Press enter twice to reconcile. The second one fails and opens the menu:
bug

@psybers commented on GitHub (Sep 2, 2024): > What’s the sub-optimality? I couldn’t spot any issues when spot checking. @MatissJanis Press enter twice to reconcile. The second one fails and opens the menu: ![bug](https://github.com/user-attachments/assets/85c34cbc-2d8f-4c0d-8105-60fd3a6711ad)
Author
Owner

@MatissJanis commented on GitHub (Sep 2, 2024):

Thanks. Yea, that's not great. But also not a deal-breaker for the patch I think.

@MatissJanis commented on GitHub (Sep 2, 2024): Thanks. Yea, that's not _great_. But also not a deal-breaker for the patch I think.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#1366