github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 22:54:03 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8243] [WIP] EasyBank PayeeName fallback fix #136462

New Issue
Open
opened 2026-06-17 21:15:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-17 21:15:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8243
Author: @neuos
Created: 6/16/2026
Status: 🔄 Open

Base: master ← Head: master

📝 Commits (10+)

  • 05ef7c3 fix fallback logic for easybank payeeName
  • d263801 Merge branch 'actualbudget:master' into master
  • 9fc8010 yarn generate:release-notes
  • 4eaf450 Merge remote-tracking branch 'refs/remotes/origin/master'
  • c57f460 fix type error
  • 57aad9a expand hasCreditor check
  • 43773d2 [autofix.ci] apply automated fixes
  • e24ec8f simplify changelog
  • b269c56 Merge remote-tracking branch 'refs/remotes/origin/master'
  • c0523a7 Merge branch 'master' into master

📊 Changes

3 files changed (+29 additions, -6 deletions)

View changed files

📝 packages/sync-server/src/app-gocardless/banks/easybank_bawaatww.ts (+16 -2)
📝 packages/sync-server/src/app-gocardless/banks/tests/easybank_bawaatww.spec.ts (+7 -4)
➕ upcoming-release-notes/easybank-payee-fallback.md (+6 -0)

📄 Description

Description

Sometimes in easybank transactions the creditor is not provided. The formatPayeeName then falls back to debtor. But that is not correct in case of a negative booking, as it is just the account holders IBAN.

This Change fixes the fallback logic for that particular case.

No AI was used, except the configured pr ai workflows.

Related issue(s)

No pre-existing issue for this problem.

Testing

The unit tests were adapted to check for this case.

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I have read every line of this diff and can explain what each change does and why it is needed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8243 **Author:** [@neuos](https://github.com/neuos) **Created:** 6/16/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`05ef7c3`](https://github.com/actualbudget/actual/commit/05ef7c305e05813fead2e49e33d3385a64bbdc9c) fix fallback logic for easybank payeeName - [`d263801`](https://github.com/actualbudget/actual/commit/d26380105f78d70936473e5ca6883a7c5f7d3382) Merge branch 'actualbudget:master' into master - [`9fc8010`](https://github.com/actualbudget/actual/commit/9fc8010c6edc1fb6b05a117cbc0747d64fcf3a5a) yarn generate:release-notes - [`4eaf450`](https://github.com/actualbudget/actual/commit/4eaf4507588be2869971679981c39b3a70b6f110) Merge remote-tracking branch 'refs/remotes/origin/master' - [`c57f460`](https://github.com/actualbudget/actual/commit/c57f460061dee2a602ef7f5cc4ad3e15c18cafa3) fix type error - [`57aad9a`](https://github.com/actualbudget/actual/commit/57aad9a1a942d7d861a5cfe8676abcfb8960c7c4) expand hasCreditor check - [`43773d2`](https://github.com/actualbudget/actual/commit/43773d2783a9774854c27ccbd58e09b1db575444) [autofix.ci] apply automated fixes - [`e24ec8f`](https://github.com/actualbudget/actual/commit/e24ec8fb79780f8bc087d241011f5a3dc98bfeb1) simplify changelog - [`b269c56`](https://github.com/actualbudget/actual/commit/b269c56b8ca11fae3c856bdefac13c929da69cfc) Merge remote-tracking branch 'refs/remotes/origin/master' - [`c0523a7`](https://github.com/actualbudget/actual/commit/c0523a79ef368f5862832f8534c1a2690d89bd77) Merge branch 'master' into master ### 📊 Changes **3 files changed** (+29 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/sync-server/src/app-gocardless/banks/easybank_bawaatww.ts` (+16 -2) 📝 `packages/sync-server/src/app-gocardless/banks/tests/easybank_bawaatww.spec.ts` (+7 -4) ➕ `upcoming-release-notes/easybank-payee-fallback.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://actualbudget.org/docs/contributing/#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description Sometimes in easybank transactions the creditor is not provided. The formatPayeeName then falls back to debtor. But that is not correct in case of a negative booking, as it is just the account holders IBAN. This Change fixes the fallback logic for that particular case. <!-- What does this PR do? Why is it needed? Please give context on the "why?": why do we need this change? What problem is it solving for you?--> <!-- If AI tools wrote a significant part of this change, please disclose it here and name the tool you used. See https://actualbudget.org/docs/contributing/ai-usage-policy --> No AI was used, except the configured pr ai workflows. ## Related issue(s) No pre-existing issue for this problem. <!-- e.g. Fixes #123, Relates to #456 --> ## Testing The unit tests were adapted to check for this case. <!-- What did you test? How can we reproduce the issue you are fixing or how can we test the feature you built? --> ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I have read every line of this diff and can explain what each change does and why it is needed <!--- actual-bot-sections ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-17 21:15:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#136462
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?