[PR #8234] [MERGED] Start desktop split transactions with two splits instead of one #136455

New Issue

Closed

opened 2026-06-17 21:14:51 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-06-17 21:14:51 -05:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8234
Author: @citrus-it
Created: 6/15/2026
Status: ✅ Merged
Merged: 6/17/2026
Merged by: @matt-fidd

Base: master ← Head: twosplit

---

📝 Commits (2)

• 936bdd6 Start desktop split transactions with two splits instead of one
• 21ed91f Update VRT screenshots

📊 Changes

11 files changed (+25 additions, -10 deletions)

View changed files

📝 packages/desktop-client/e2e/page-models/account-page.ts (+7 -4)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Area-Graph-and-checks-the-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Bar-Graph-and-checks-the-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Data-Table-and-checks-the-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/transactions/TransactionList.tsx (+6 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx (+1 -4)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+5 -1)
➕ upcoming-release-notes/default-two-splits.md (+6 -0)

📄 Description

Description

This change updates the desktop app so that splitting a transaction creates two empty splits in the same way that the mobile app does. A split needs at least two lines to be meaningful and I find myself otherwise always having to click Add Split straight away.

Testing

I have updated the tests to handle the new default number of splits and checked that they run successfully. I ran the desktop app locally with yarn start and confirmed the new behaviour.

Checklist

• Release notes added (see link above)
• No obvious regressions in affected areas
• Self-review has been performed - I have read every line of this diff and can explain what each change does and why it is needed

---

Bundle Stats

Bundle	Files count	Total bundle size	% Changed
desktop-client	37	13.24 MB → 13.19 MB (-52.71 kB)	-0.39%
loot-core	1	4.88 MB	0%
api	2	3.88 MB	0%
cli	1	7.97 MB	0%
crdt	1	11.12 kB	0%

View detailed bundle stats

desktop-client

Total

Files count	Total bundle size	% Changed
37	13.24 MB → 13.19 MB (-52.71 kB)	-0.39%

Changeset

File	Δ	Size
src/components/transactions/TransactionList.tsx	📈 +88 B (+0.50%)	17.29 kB → 17.37 kB
src/components/transactions/TransactionsTable.tsx	📈 +58 B (+0.06%)	90.38 kB → 90.43 kB
locale/nl.json	📉 -590 B (-0.48%)	119.71 kB → 119.14 kB
locale/en.json	📉 -1.82 kB (-0.90%)	202.14 kB → 200.33 kB
locale/zh-Hans.json	📉 -3.18 kB (-2.73%)	116.44 kB → 113.26 kB
locale/uk.json	📉 -6.73 kB (-3.11%)	216.7 kB → 209.97 kB
locale/pt-BR.json	📉 -5.84 kB (-3.12%)	187.34 kB → 181.5 kB
locale/de.json	📉 -5.76 kB (-3.16%)	182.38 kB → 176.61 kB
locale/ca.json	📉 -5.92 kB (-3.19%)	185.63 kB → 179.71 kB
locale/es.json	📉 -5.75 kB (-3.24%)	177.58 kB → 171.82 kB
locale/fr.json	📉 -5.96 kB (-3.36%)	177.35 kB → 171.39 kB
locale/it.json	📉 -5.79 kB (-3.53%)	163.93 kB → 158.13 kB
locale/nb-NO.json	📉 -5.52 kB (-3.75%)	147.07 kB → 141.55 kB

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset	File Size	% Changed
static/js/Value.js	4.49 MB → 4.49 MB (+146 B)	+0.00%

Smaller

Asset	File Size	% Changed
static/js/uk.js	216.7 kB → 209.97 kB (-6.73 kB)	-3.11%
static/js/fr.js	177.35 kB → 171.39 kB (-5.96 kB)	-3.36%
static/js/ca.js	185.63 kB → 179.71 kB (-5.92 kB)	-3.19%
static/js/pt-BR.js	187.34 kB → 181.5 kB (-5.84 kB)	-3.12%
static/js/it.js	163.93 kB → 158.13 kB (-5.79 kB)	-3.53%
static/js/de.js	182.38 kB → 176.61 kB (-5.76 kB)	-3.16%
static/js/es.js	177.58 kB → 171.82 kB (-5.75 kB)	-3.24%
static/js/nb-NO.js	147.07 kB → 141.55 kB (-5.52 kB)	-3.75%
static/js/zh-Hans.js	116.44 kB → 113.26 kB (-3.18 kB)	-2.73%
static/js/en.js	202.14 kB → 200.33 kB (-1.82 kB)	-0.90%
static/js/nl.js	119.71 kB → 119.14 kB (-590 B)	-0.48%

Unchanged

Asset	File Size	% Changed
static/js/index.js	1.58 MB	0%
static/js/BackgroundImage.js	121.09 kB	0%
static/js/FormulaEditor.js	816.62 kB	0%
static/js/ManageRules.js	46.47 kB	0%
static/js/PayeeRuleCountLabel.js	7.1 kB	0%
static/js/ReportRouter.js	1.25 MB	0%
static/js/ScheduleEditForm.js	146.51 kB	0%
static/js/SchedulesTable.js	203.53 kB	0%
static/js/TransactionEdit.js	90.63 kB	0%
static/js/TransactionList.js	82.8 kB	0%
static/js/_baseIsEqual.js	76.76 kB	0%
static/js/client.js	450.92 kB	0%
static/js/da.js	100.19 kB	0%
static/js/en-GB.js	9.25 kB	0%
static/js/extends.js	473.99 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.46 kB	0%
static/js/narrow.js	364.55 kB	0%
static/js/resize-observer.js	18.06 kB	0%
static/js/th.js	173.33 kB	0%
static/js/theme.js	31.01 kB	0%
static/js/toString.js	638.95 kB	0%
static/js/useFormatList.js	2.52 kB	0%
static/js/useTransactionBatchActions.js	9.71 kB	0%
static/js/wide.js	298.23 kB	0%
static/js/workbox-window.prod.es5.js	7.33 kB	0%

---

loot-core

Total

Files count	Total bundle size	% Changed
1	4.88 MB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.BA86qMul.js	4.88 MB	0%

---

api

Total

Files count	Total bundle size	% Changed
2	3.88 MB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
index.js	3.88 MB	0%
models.js	0 B	0%

---

cli

Total

Files count	Total bundle size	% Changed
1	7.97 MB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
cli.js	7.97 MB	0%

---

crdt

Total

Files count	Total bundle size	% Changed
1	11.12 kB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
index.js	11.12 kB	0%

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8234 **Author:** [@citrus-it](https://github.com/citrus-it) **Created:** 6/15/2026 **Status:** ✅ Merged **Merged:** 6/17/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `twosplit` --- ### 📝 Commits (2) - [`936bdd6`](https://github.com/actualbudget/actual/commit/936bdd69889d7a0ecb2c980d24ec59833fde6b2c) Start desktop split transactions with two splits instead of one - [`21ed91f`](https://github.com/actualbudget/actual/commit/21ed91f379c19a0bd1175c91cfc3f3d05be6bf3e) Update VRT screenshots ### 📊 Changes **11 files changed** (+25 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/page-models/account-page.ts` (+7 -4) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Area-Graph-and-checks-the-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Bar-Graph-and-checks-the-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Data-Table-and-checks-the-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/transactions/TransactionList.tsx` (+6 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx` (+1 -4) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+5 -1) ➕ `upcoming-release-notes/default-two-splits.md` (+6 -0) </details> ### 📄 Description ## Description This change updates the desktop app so that splitting a transaction creates two empty splits in the same way that the mobile app does. A split needs at least two lines to be meaningful and I find myself otherwise always having to click Add Split straight away. ## Testing I have updated the tests to handle the new default number of splits and checked that they run successfully. I ran the desktop app locally with `yarn start` and confirmed the new behaviour. ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I have read every line of this diff and can explain what each change does and why it is needed <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 13.24 MB → 13.19 MB (-52.71 kB) | -0.39% loot-core | 1 | 4.88 MB | 0% api | 2 | 3.88 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 13.24 MB → 13.19 MB (-52.71 kB) | -0.39% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/transactions/TransactionList.tsx` | 📈 +88 B (+0.50%) | 17.29 kB → 17.37 kB `src/components/transactions/TransactionsTable.tsx` | 📈 +58 B (+0.06%) | 90.38 kB → 90.43 kB `locale/nl.json` | 📉 -590 B (-0.48%) | 119.71 kB → 119.14 kB `locale/en.json` | 📉 -1.82 kB (-0.90%) | 202.14 kB → 200.33 kB `locale/zh-Hans.json` | 📉 -3.18 kB (-2.73%) | 116.44 kB → 113.26 kB `locale/uk.json` | 📉 -6.73 kB (-3.11%) | 216.7 kB → 209.97 kB `locale/pt-BR.json` | 📉 -5.84 kB (-3.12%) | 187.34 kB → 181.5 kB `locale/de.json` | 📉 -5.76 kB (-3.16%) | 182.38 kB → 176.61 kB `locale/ca.json` | 📉 -5.92 kB (-3.19%) | 185.63 kB → 179.71 kB `locale/es.json` | 📉 -5.75 kB (-3.24%) | 177.58 kB → 171.82 kB `locale/fr.json` | 📉 -5.96 kB (-3.36%) | 177.35 kB → 171.39 kB `locale/it.json` | 📉 -5.79 kB (-3.53%) | 163.93 kB → 158.13 kB `locale/nb-NO.json` | 📉 -5.52 kB (-3.75%) | 147.07 kB → 141.55 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/Value.js | 4.49 MB → 4.49 MB (+146 B) | +0.00% **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/uk.js | 216.7 kB → 209.97 kB (-6.73 kB) | -3.11% static/js/fr.js | 177.35 kB → 171.39 kB (-5.96 kB) | -3.36% static/js/ca.js | 185.63 kB → 179.71 kB (-5.92 kB) | -3.19% static/js/pt-BR.js | 187.34 kB → 181.5 kB (-5.84 kB) | -3.12% static/js/it.js | 163.93 kB → 158.13 kB (-5.79 kB) | -3.53% static/js/de.js | 182.38 kB → 176.61 kB (-5.76 kB) | -3.16% static/js/es.js | 177.58 kB → 171.82 kB (-5.75 kB) | -3.24% static/js/nb-NO.js | 147.07 kB → 141.55 kB (-5.52 kB) | -3.75% static/js/zh-Hans.js | 116.44 kB → 113.26 kB (-3.18 kB) | -2.73% static/js/en.js | 202.14 kB → 200.33 kB (-1.82 kB) | -0.90% static/js/nl.js | 119.71 kB → 119.14 kB (-590 B) | -0.48% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.58 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 816.62 kB | 0% static/js/ManageRules.js | 46.47 kB | 0% static/js/PayeeRuleCountLabel.js | 7.1 kB | 0% static/js/ReportRouter.js | 1.25 MB | 0% static/js/ScheduleEditForm.js | 146.51 kB | 0% static/js/SchedulesTable.js | 203.53 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 82.8 kB | 0% static/js/_baseIsEqual.js | 76.76 kB | 0% static/js/client.js | 450.92 kB | 0% static/js/da.js | 100.19 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/extends.js | 473.99 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/narrow.js | 364.55 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 173.33 kB | 0% static/js/theme.js | 31.01 kB | 0% static/js/toString.js | 638.95 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 298.23 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.88 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BA86qMul.js | 4.88 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.88 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.88 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-06-17 21:14:51 -05:00

GiteaMirror closed this issue 2026-06-17 21:14:55 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

ai/rule-formula-amount-units

release-notes/26.9.0

release

cross-version-sync

react-query-rules

ai/add-loan-formula-autocomplete

claude/pr-8519-regression-testing-fhvrrh

speed-up-transaction-list-and-schedules

fix-slow-balance-recompute-on-transaction-edit

jfdoming/opfs-sahpool-mobile

jfdoming/opfs-sahpool

fix-8612-schedule-delete-menu

jfdoming/api-tokens-part-8

jfdoming/api-tokens-part-7

jfdoming/api-tokens-part-6

jfdoming/api-tokens-part-5

jfdoming/mobile-safe-area-header

jfdoming/api-tokens-part-4

jfdoming/mobile-splash-lifecycle

jfdoming/api-tokens-part-3

jfdoming/mobile-shared-array-buffer

jfdoming/api-tokens-part-2

jfdoming/api-tokens-part-1

persist-transaction-filters

claude/modernize-transactions-tanstack-orgrze

bank-sync-per-file-03-pluggy-loot-core

claude/auto-close-prs-no-profile-pic-mjqpsy

cross-version-sync-stage2

claude/react-table-library-research-afx83z

tolerate-newer-migrations

claude/verify-migration-guardrails-i82c8m

tabedzki/feat/replacing-month-picker-with-day-picker

delay-initial-sync-until-loaded

cross-version-sync-compat

jfdoming/mobile-app-updates

claude/budget-version-migration-compat-151jlr

claude/worker-error-serialization-9iqtl7

claude/issue-8401-regression-test-9nw9l3

jfdoming/mobile-app-foundation-part-1

jfdoming/mobile-app-scaffold

ai-fix-cleanup-def-8290

claude/relaxed-shannon-jusywa

claude/fervent-keller-s6f2fq

claude/determined-feynman-st1y9z

claude/wizardly-einstein-vi2wce

claude/sweet-albattani-7nseio

feat/bank-sync-per-budget-file

claude/affectionate-cannon-y0kc82

claude/dependabot-findings-m9pgmb

claude/mac-app-ios-publish-zjs1lz

claude/vigilant-tesla-aiiyos

depot-migrate-secrets-1781296330308

claude/quirky-cerf-v5qck7

claude/animation-removal-alternative-2etfh1

claude/netlify-preview-comments-consolidate-9XPYa

osc/7391-error-boundaries-reports

claude/pensive-dijkstra-7DYui

claude/server-app-version-mismatch-HTCGv

claude/pr-8027-review-feedback-mELuO

claude/zealous-wozniak-e5pO0

claude/intelligent-heisenberg-BSHJq

claude/translation-download-refactor-jFRsO

claude/mobile-performance-ideas-G9PAO

claude/github-issue-7988-5A5ly

blacksmith-migration-ff70d2d

claude/great-mayer-KRvOk

claude/react-native-ios-compilation-fcJh5

claude/serene-goldberg-58xv0

claude/kind-euler-LVG3K

release-automation/edge-nightly

7710-bundle-migrations

claude/fix-docker-build-error-WMfed

claude/llm-compatible-release-notes-t20Nr

7710-tests-tdd

cursor/transaction-table-rewrite-f077

claude/plan-ci-secure-context-OtEe1

claude/fix-issue-7667-DPXi3

cursor/resolve-pr-7449-ee11

claude/fix-typescript-build-error-JPtZ5

copilot/add-repository-configs-to-packages

worktree-compressed-drifting-ritchie

claude/api-consumer-verification-kfz1K

pr-7454

claude/fix-issue-7410-LLLQ4

revert-7281-generate-icons

react-query-useSchedules

copilot/sub-pr-6140

package-upgrades

v26.8.1

v26.8.0

v26.7.0

v26.6.0

v26.5.2

v26.5.1

v26.5.0

v26.4.0

v26.3.0

v26.2.1

v26.2.0

v26.1.0

v25.12.0

v25.11.0

v25.10.0

v25.9.0

v25.8.0

v25.7.1

v25.7.0

v25.6.1

v25.6.0

v25.5.0

v25.4.0

v25.3.1

v25.3.0

v25.2.1

v25.2.0

v25.1.0

v24.12.0

v24.11.0

v24.10.1

v24.10.0

v24.9.0

v24.8.0

v24.7.0

v24.6.0

v24.5.0

v24.4.0

v24.3.0

v24.2.0

v24.1.0

v23.12.0

v23.11.0

v23.10.0

v23.9.0

v23.8.1

v23.8.0

v23.7.2

v23.7.1

v23.7.0

v23.6.0

v23.5.0

v23.4.2

v23.4.1

v23.4.0

v23.3.2

v23.3.0

v23.2.9

v23.2.5

v23.1.12

v22.12.9

Labels

Clear labels

AI generated

API

bank sync

budgeting

bug

can’t replicate

dependencies

docker

documentation

electron

experimental feature

feature

feedback

goal templates

good first issue

help wanted

importers

maintenance

needs info

needs testing

needs triage

needs votes

openid

payees

pull-request

Mirrored from GitHub Pull Request

regression

reports

responsive

rules

schedules

server

✨ merged

split transactions

tech debt

tech-support

theme

transaction import

transaction reconciliation

transactions

translations

upstream

user interface

✅ approved

wontfix

No labels pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

GiteaMirror ninjasurge (Kaehlen Rog)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/actual#136455