github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8127] [CLOSED] fix(transactions): anchor split-error popover to row start to prevent horizontal overflow #136428

New Issue
Closed
opened 2026-06-17 21:11:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-17 21:11:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8127
Author: @64johnlee
Created: 6/7/2026
Status: ❌ Closed

Base: master ← Head: fix-split-popover-overflow-7981

📝 Commits (4)

  • 7792cde fix(reports): show correct tooltip entries in compact widget mode
  • 269fe12 fix(transactions): anchor split-error popover to row start to prevent horizontal overflow
  • 6f9c7a0 chore: add release notes for #7981
  • 26cde83 chore: retrigger CI

📊 Changes

4 files changed (+36 additions, -28 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/graphs/LineGraph.tsx (+8 -8)
📝 packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx (+21 -19)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+1 -1)
➕ upcoming-release-notes/7981.md (+6 -0)

📄 Description

Summary

The split-error popover (showing "Amount left / Distribute / Add Split") used placement="bottom end", which aligns the popover's right edge to the trigger row's right edge. When the table is wider than the viewport (e.g. on smaller screens or with many columns), the row's right edge is off-screen, pushing the popover beyond the viewport and hiding the action buttons entirely.

Changing to placement="bottom start" anchors the popover's left edge to the row's left edge, which is always visible within the viewport.

Closes #7981

Changes

  • packages/desktop-client/src/components/transactions/TransactionsTable.tsx — change split-error Popover placement from "bottom end" to "bottom start"

Test plan

  • Create or open a split transaction that has an unbalanced remainder
  • Confirm the "Amount left / Distribute / Add Split" popover appears below the row and its buttons are accessible
  • Confirm the popover does not overflow to the right on narrow viewports or when the table has horizontal scroll

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.13 MB → 14.13 MB (+276 B) +0.00%
loot-core 1 5.28 MB 0%
api 2 3.87 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.13 MB → 14.13 MB (+276 B) +0.00%
Changeset
File Δ Size
src/components/reports/graphs/StackedBarGraph.tsx 📈 +254 B (+2.52%) 9.84 kB → 10.09 kB
src/components/reports/graphs/LineGraph.tsx 📈 +18 B (+0.18%) 9.89 kB → 9.91 kB
src/components/reports/reports/Calendar.tsx 📈 +2 B (+0.01%) 27.58 kB → 27.59 kB
src/components/transactions/TransactionsTable.tsx 📈 +2 B (+0.00%) 90.38 kB → 90.38 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.27 MB → 1.27 MB (+274 B) +0.02%
static/js/Value.js 5.08 MB → 5.08 MB (+2 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.6 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.63 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ScheduleEditForm.js 146.57 kB 0%
static/js/SchedulesTable.js 206.26 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 185.63 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 100.19 kB 0%
static/js/de.js 172.1 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 201.61 kB 0%
static/js/es.js 177.58 kB 0%
static/js/extends.js 508.79 kB 0%
static/js/fr.js 177.35 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 163.93 kB 0%
static/js/narrow.js 365.05 kB 0%
static/js/nb-NO.js 147.07 kB 0%
static/js/nl.js 119.71 kB 0%
static/js/pt-BR.js 187.34 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 173.33 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 216.7 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 298.88 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.44 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.28 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.lfNBY2TT.js 5.28 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.87 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.87 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8127 **Author:** [@64johnlee](https://github.com/64johnlee) **Created:** 6/7/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-split-popover-overflow-7981` --- ### 📝 Commits (4) - [`7792cde`](https://github.com/actualbudget/actual/commit/7792cdee49d83a8a9fa97107aae572272e94ce9a) fix(reports): show correct tooltip entries in compact widget mode - [`269fe12`](https://github.com/actualbudget/actual/commit/269fe126e593bca3027e887d5d58251c1152281d) fix(transactions): anchor split-error popover to row start to prevent horizontal overflow - [`6f9c7a0`](https://github.com/actualbudget/actual/commit/6f9c7a091d30c85de5a6802cf4ee77ae54e3746a) chore: add release notes for #7981 - [`26cde83`](https://github.com/actualbudget/actual/commit/26cde8307eb469157ed66da8491fe9ad876f542c) chore: retrigger CI ### 📊 Changes **4 files changed** (+36 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/graphs/LineGraph.tsx` (+8 -8) 📝 `packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx` (+21 -19) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+1 -1) ➕ `upcoming-release-notes/7981.md` (+6 -0) </details> ### 📄 Description ## Summary The split-error popover (showing "Amount left / Distribute / Add Split") used `placement="bottom end"`, which aligns the popover's right edge to the trigger row's right edge. When the table is wider than the viewport (e.g. on smaller screens or with many columns), the row's right edge is off-screen, pushing the popover beyond the viewport and hiding the action buttons entirely. Changing to `placement="bottom start"` anchors the popover's left edge to the row's left edge, which is always visible within the viewport. Closes #7981 ## Changes - `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` — change split-error Popover `placement` from `"bottom end"` to `"bottom start"` ## Test plan - [ ] Create or open a split transaction that has an unbalanced remainder - [ ] Confirm the "Amount left / Distribute / Add Split" popover appears below the row and its buttons are accessible - [ ] Confirm the popover does not overflow to the right on narrow viewports or when the table has horizontal scroll <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.13 MB → 14.13 MB (+276 B) | +0.00% loot-core | 1 | 5.28 MB | 0% api | 2 | 3.87 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.13 MB → 14.13 MB (+276 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/reports/graphs/StackedBarGraph.tsx` | 📈 +254 B (+2.52%) | 9.84 kB → 10.09 kB `src/components/reports/graphs/LineGraph.tsx` | 📈 +18 B (+0.18%) | 9.89 kB → 9.91 kB `src/components/reports/reports/Calendar.tsx` | 📈 +2 B (+0.01%) | 27.58 kB → 27.59 kB `src/components/transactions/TransactionsTable.tsx` | 📈 +2 B (+0.00%) | 90.38 kB → 90.38 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/ReportRouter.js | 1.27 MB → 1.27 MB (+274 B) | +0.02% static/js/Value.js | 5.08 MB → 5.08 MB (+2 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.6 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.63 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ScheduleEditForm.js | 146.57 kB | 0% static/js/SchedulesTable.js | 206.26 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 185.63 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 100.19 kB | 0% static/js/de.js | 172.1 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 201.61 kB | 0% static/js/es.js | 177.58 kB | 0% static/js/extends.js | 508.79 kB | 0% static/js/fr.js | 177.35 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 163.93 kB | 0% static/js/narrow.js | 365.05 kB | 0% static/js/nb-NO.js | 147.07 kB | 0% static/js/nl.js | 119.71 kB | 0% static/js/pt-BR.js | 187.34 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 173.33 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 216.7 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 298.88 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.44 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.28 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.lfNBY2TT.js | 5.28 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.87 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.87 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-17 21:11:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#136428
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?