github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-10 23:54:00 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8119] [CLOSED] [WIP] fix(reports): wrap desktop TransactionList in DisplayPayeeProvider #136420

New Issue
Closed
opened 2026-06-17 21:10:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-17 21:10:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8119
Author: @64johnlee
Created: 6/7/2026
Status: ❌ Closed

Base: master ← Head: fix/calendar-mobile-displaypayee-7108

📝 Commits (2)

  • 94550b8 fix(reports): wrap desktop TransactionList in DisplayPayeeProvider
  • fd75b11 fix(banksync): surface Cloudflare block on SimpleFIN as an error notification

📊 Changes

4 files changed (+77 additions, -53 deletions)

View changed files

📝 packages/desktop-client/src/components/banksync/useBuiltInBankSyncProviders.ts (+18 -1)
📝 packages/desktop-client/src/components/reports/reports/Calendar.tsx (+53 -51)
📝 packages/desktop-client/src/hooks/useSimpleFinStatus.ts (+3 -0)
📝 packages/sync-server/src/app-simplefin/app-simplefin.js (+3 -1)

📄 Description

Summary

The Transaction Calendar widget crashed on mobile with:

Error: useDisplayPayee must be used within a DisplayPayeeContextProvider.

The mobile TransactionListMobile branch already had <DisplayPayeeProvider> wrapping it, but the desktop TransactionList branch was missing the same wrapper. When the component renders on a narrow viewport the desktop list is still evaluated before the isNarrowWidth branch resolves, causing useDisplayPayee inside TransactionList to throw because there is no provider in scope.

Closes #7108

Changes

  • packages/desktop-client/src/components/reports/reports/Calendar.tsx — wrap the desktop <TransactionList> in <DisplayPayeeProvider transactions={allTransactions}>, mirroring the existing mobile path at line 753

Test plan

  • Open Transaction Calendar widget on a mobile/narrow viewport — no crash
  • Open Transaction Calendar widget on desktop — transactions still render correctly

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.13 MB → 14.13 MB (+691 B) +0.00%
loot-core 1 5.28 MB 0%
api 2 3.87 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.13 MB → 14.13 MB (+691 B) +0.00%
Changeset
File Δ Size
src/hooks/useSimpleFinStatus.ts 📈 +190 B (+32.59%) 583 B → 773 B
src/components/banksync/useBuiltInBankSyncProviders.ts 📈 +319 B (+2.19%) 14.23 kB → 14.54 kB
src/components/reports/reports/Calendar.tsx 📈 +182 B (+0.64%) 27.58 kB → 27.76 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/SchedulesTable.js 206.26 kB → 206.76 kB (+509 B) +0.24%
static/js/ReportRouter.js 1.27 MB → 1.27 MB (+182 B) +0.01%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.6 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.63 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ScheduleEditForm.js 146.57 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 5.08 MB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 185.63 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 100.19 kB 0%
static/js/de.js 172.1 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 201.61 kB 0%
static/js/es.js 177.58 kB 0%
static/js/extends.js 508.79 kB 0%
static/js/fr.js 177.35 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 163.93 kB 0%
static/js/narrow.js 365.05 kB 0%
static/js/nb-NO.js 147.07 kB 0%
static/js/nl.js 119.71 kB 0%
static/js/pt-BR.js 187.34 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 173.33 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 216.7 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 298.88 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.44 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.28 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.lfNBY2TT.js 5.28 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.87 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.87 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8119 **Author:** [@64johnlee](https://github.com/64johnlee) **Created:** 6/7/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/calendar-mobile-displaypayee-7108` --- ### 📝 Commits (2) - [`94550b8`](https://github.com/actualbudget/actual/commit/94550b89c411f307489fad619e16bd3b01c747d6) fix(reports): wrap desktop TransactionList in DisplayPayeeProvider - [`fd75b11`](https://github.com/actualbudget/actual/commit/fd75b118c698a39eccc1c92467207fdb1c2179c0) fix(banksync): surface Cloudflare block on SimpleFIN as an error notification ### 📊 Changes **4 files changed** (+77 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/banksync/useBuiltInBankSyncProviders.ts` (+18 -1) 📝 `packages/desktop-client/src/components/reports/reports/Calendar.tsx` (+53 -51) 📝 `packages/desktop-client/src/hooks/useSimpleFinStatus.ts` (+3 -0) 📝 `packages/sync-server/src/app-simplefin/app-simplefin.js` (+3 -1) </details> ### 📄 Description ## Summary The Transaction Calendar widget crashed on mobile with: ``` Error: useDisplayPayee must be used within a DisplayPayeeContextProvider. ``` The mobile `TransactionListMobile` branch already had `<DisplayPayeeProvider>` wrapping it, but the desktop `TransactionList` branch was missing the same wrapper. When the component renders on a narrow viewport the desktop list is still evaluated before the `isNarrowWidth` branch resolves, causing `useDisplayPayee` inside `TransactionList` to throw because there is no provider in scope. Closes #7108 ## Changes - `packages/desktop-client/src/components/reports/reports/Calendar.tsx` — wrap the desktop `<TransactionList>` in `<DisplayPayeeProvider transactions={allTransactions}>`, mirroring the existing mobile path at line 753 ## Test plan - [ ] Open Transaction Calendar widget on a mobile/narrow viewport — no crash - [ ] Open Transaction Calendar widget on desktop — transactions still render correctly <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.13 MB → 14.13 MB (+691 B) | +0.00% loot-core | 1 | 5.28 MB | 0% api | 2 | 3.87 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.13 MB → 14.13 MB (+691 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/hooks/useSimpleFinStatus.ts` | 📈 +190 B (+32.59%) | 583 B → 773 B `src/components/banksync/useBuiltInBankSyncProviders.ts` | 📈 +319 B (+2.19%) | 14.23 kB → 14.54 kB `src/components/reports/reports/Calendar.tsx` | 📈 +182 B (+0.64%) | 27.58 kB → 27.76 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/SchedulesTable.js | 206.26 kB → 206.76 kB (+509 B) | +0.24% static/js/ReportRouter.js | 1.27 MB → 1.27 MB (+182 B) | +0.01% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.6 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.63 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ScheduleEditForm.js | 146.57 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 5.08 MB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 185.63 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 100.19 kB | 0% static/js/de.js | 172.1 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 201.61 kB | 0% static/js/es.js | 177.58 kB | 0% static/js/extends.js | 508.79 kB | 0% static/js/fr.js | 177.35 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 163.93 kB | 0% static/js/narrow.js | 365.05 kB | 0% static/js/nb-NO.js | 147.07 kB | 0% static/js/nl.js | 119.71 kB | 0% static/js/pt-BR.js | 187.34 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 173.33 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 216.7 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 298.88 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.44 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.28 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.lfNBY2TT.js | 5.28 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.87 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.87 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-17 21:10:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#136420
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?