github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 22:54:03 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7998] [MERGED] [AI] Custom highlight for added sync items: transaction table and sidebar #136338

New Issue
Closed
opened 2026-06-17 21:04:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-17 21:04:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7998
Author: @Juulz
Created: 5/30/2026
Status: ✅ Merged
Merged: 5/30/2026
Merged by: @matt-fidd

Base: master ← Head: highlight-added-sync-items

📝 Commits (9)

  • 30fe4d0 Add new CSS variables for text items in dark theme
  • f7195d0 Add new CSS variables for table and sidebar items
  • c4cc676 Add new CSS variables for table and sidebar items
  • 478f4c2 Update sidebar account style for updated state
  • 96342af Enhance valueStyle with color for added items
  • 601f9cc [autofix.ci] apply automated fixes
  • a92c823 Add new theme variables for table and sidebar
  • 06e1050 Add color variables to added sync items
  • ab36517 [AI] Apply added-row styling to transaction notes cell

📊 Changes

7 files changed (+25 additions, -2 deletions)

View changed files

📝 packages/component-library/src/theme.ts (+2 -0)
📝 packages/component-library/src/themes/dark.css (+2 -0)
📝 packages/component-library/src/themes/light.css (+2 -0)
📝 packages/component-library/src/themes/midnight.css (+2 -0)
📝 packages/desktop-client/src/components/sidebar/Account.tsx (+4 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+7 -1)
➕ upcoming-release-notes/7998.md (+6 -0)

📄 Description

Description

Add color variables so added transactions from bank sync show up more than just bold, if desired. This comes up a lot on reddit and discord. Default behavior (bold only) unchanged.

transaction table, --color-tableTextItemAdded: var(--color-tableText);
sidebar, --color-sidebarItemTextUpdated: var(--color-sidebarItemText);

Although we have plenty of variables, I didn't want to reuse something that may end up the wrong saturation for the background. See screenshots - I wouldn't want to actually USE this dark a color here.

I had a little help from Cursor(Claude) to find why the color was updating except the notes field.

Sidebar:
Screenshot 2026-05-30 103116

Transaction table:
Screenshot 2026-05-30 130252

Uncategorized view:
Screenshot 2026-05-30 130321

Custom theme colors:
Screenshot 2026-05-30 103417

Related issue(s)

Fixes feature #5652 and partially fixes feature #4292

Testing

Tested with a live bank sync, see screenshots above.

Tested also with a prepended #tag and the tag rendered correctly.
Screenshot 2026-05-30 131400

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.03 MB → 14.03 MB (-1.52 kB) -0.01%
loot-core 1 5.34 MB 0%
api 2 3.97 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.03 MB → 14.03 MB (-1.52 kB) -0.01%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/component-library/src/theme.ts 📈 +120 B (+0.96%) 12.27 kB → 12.39 kB
home/runner/work/actual/actual/packages/component-library/src/themes/dark.css?inline 📈 +120 B (+0.93%) 12.58 kB → 12.7 kB
home/runner/work/actual/actual/packages/component-library/src/themes/light.css?inline 📈 +120 B (+0.93%) 12.6 kB → 12.71 kB
home/runner/work/actual/actual/packages/component-library/src/themes/midnight.css?inline 📈 +120 B (+0.92%) 12.71 kB → 12.83 kB
src/components/sidebar/Account.tsx 📈 +45 B (+0.35%) 12.66 kB → 12.71 kB
src/components/transactions/TransactionsTable.tsx 📈 +38 B (+0.04%) 90.25 kB → 90.29 kB
src/components/accounts/Account.tsx 📉 -577 B (-1.26%) 44.66 kB → 44.09 kB
src/components/accounts/Header.tsx 📉 -627 B (-2.14%) 28.61 kB → 28 kB
home/runner/work/actual/actual/packages/component-library/src/icons/v2/UploadThickBottom.tsx 🔥 -918 B (-100%) 918 B → 0 B
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/extends.js 500.61 kB → 500.96 kB (+360 B) +0.07%
static/js/theme.js 31.77 kB → 31.88 kB (+120 B) +0.37%
static/js/index.js 1.54 MB → 1.54 MB (+45 B) +0.00%

Smaller

Asset File Size % Changed
static/js/wide.js 297.28 kB → 296.1 kB (-1.18 kB) -0.40%
static/js/Value.js 5.08 MB → 5.08 MB (-880 B) -0.02%

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.98 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ReportRouter.js 1.26 MB 0%
static/js/ScheduleEditForm.js 146.44 kB 0%
static/js/SchedulesTable.js 202.7 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 186.75 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.15 kB 0%
static/js/de.js 170.77 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 198.24 kB 0%
static/js/es.js 178.68 kB 0%
static/js/fr.js 178.57 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.05 kB 0%
static/js/nl.js 106.24 kB 0%
static/js/pt-BR.js 188.43 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.48 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 207.46 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.89 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.34 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.D308xu1O.js 5.34 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.97 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7998 **Author:** [@Juulz](https://github.com/Juulz) **Created:** 5/30/2026 **Status:** ✅ Merged **Merged:** 5/30/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `highlight-added-sync-items` --- ### 📝 Commits (9) - [`30fe4d0`](https://github.com/actualbudget/actual/commit/30fe4d072c654311c8c7693d1cfc3399d2bf50e6) Add new CSS variables for text items in dark theme - [`f7195d0`](https://github.com/actualbudget/actual/commit/f7195d0677f5b265f69414ad728c50be13abf5b4) Add new CSS variables for table and sidebar items - [`c4cc676`](https://github.com/actualbudget/actual/commit/c4cc676bd03ed39f920518440298e84d9536771e) Add new CSS variables for table and sidebar items - [`478f4c2`](https://github.com/actualbudget/actual/commit/478f4c2fc0613e4a5c834ad52c930c2cd408af93) Update sidebar account style for updated state - [`96342af`](https://github.com/actualbudget/actual/commit/96342af84d288185400ffd971e67eff7c3199aca) Enhance valueStyle with color for added items - [`601f9cc`](https://github.com/actualbudget/actual/commit/601f9cc5b2a49f1df6fca520473821cdb5420479) [autofix.ci] apply automated fixes - [`a92c823`](https://github.com/actualbudget/actual/commit/a92c823df01106213e5058cbfcd72a33642ce954) Add new theme variables for table and sidebar - [`06e1050`](https://github.com/actualbudget/actual/commit/06e105042d86cae22c0fdfe6925782f3441fdab6) Add color variables to added sync items - [`ab36517`](https://github.com/actualbudget/actual/commit/ab36517bfc97499bf1b509d0eecd1b9eed1ea8c7) [AI] Apply added-row styling to transaction notes cell ### 📊 Changes **7 files changed** (+25 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/src/theme.ts` (+2 -0) 📝 `packages/component-library/src/themes/dark.css` (+2 -0) 📝 `packages/component-library/src/themes/light.css` (+2 -0) 📝 `packages/component-library/src/themes/midnight.css` (+2 -0) 📝 `packages/desktop-client/src/components/sidebar/Account.tsx` (+4 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+7 -1) ➕ `upcoming-release-notes/7998.md` (+6 -0) </details> ### 📄 Description ## Description Add color variables so added transactions from bank sync show up more than just bold, if desired. This comes up a lot on reddit and discord. Default behavior (bold only) unchanged. transaction table, --color-tableTextItemAdded: var(--color-tableText); sidebar, --color-sidebarItemTextUpdated: var(--color-sidebarItemText); Although we have plenty of variables, I didn't want to reuse something that may end up the wrong saturation for the background. See screenshots - I wouldn't want to actually USE this dark a color here. I had a little help from Cursor(Claude) to find why the color was updating except the notes field. Sidebar: <img width="233" height="163" alt="Screenshot 2026-05-30 103116" src="https://github.com/user-attachments/assets/4cb96f51-f610-4a20-adbc-55c4fa0da4a1" /> Transaction table: <img width="1777" height="73" alt="Screenshot 2026-05-30 130252" src="https://github.com/user-attachments/assets/15514f06-7733-4bdd-8c1a-7ca7fd3db1d7" /> Uncategorized view: <img width="1787" height="190" alt="Screenshot 2026-05-30 130321" src="https://github.com/user-attachments/assets/d1ee32cc-ef9f-45ac-b6cc-39bd7459c23a" /> Custom theme colors: <img width="505" height="215" alt="Screenshot 2026-05-30 103417" src="https://github.com/user-attachments/assets/e1258a00-3de4-4d54-a8cf-0a5f22e7112c" /> ## Related issue(s) Fixes feature #5652 and partially fixes feature #4292 ## Testing Tested with a live bank sync, see screenshots above. Tested also with a prepended #tag and the tag rendered correctly. <img width="1772" height="35" alt="Screenshot 2026-05-30 131400" src="https://github.com/user-attachments/assets/500eb458-c61b-4ea3-848d-86c7420e7a9d" /> ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.03 MB → 14.03 MB (-1.52 kB) | -0.01% loot-core | 1 | 5.34 MB | 0% api | 2 | 3.97 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.03 MB → 14.03 MB (-1.52 kB) | -0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/component-library/src/theme.ts` | 📈 +120 B (+0.96%) | 12.27 kB → 12.39 kB `home/runner/work/actual/actual/packages/component-library/src/themes/dark.css?inline` | 📈 +120 B (+0.93%) | 12.58 kB → 12.7 kB `home/runner/work/actual/actual/packages/component-library/src/themes/light.css?inline` | 📈 +120 B (+0.93%) | 12.6 kB → 12.71 kB `home/runner/work/actual/actual/packages/component-library/src/themes/midnight.css?inline` | 📈 +120 B (+0.92%) | 12.71 kB → 12.83 kB `src/components/sidebar/Account.tsx` | 📈 +45 B (+0.35%) | 12.66 kB → 12.71 kB `src/components/transactions/TransactionsTable.tsx` | 📈 +38 B (+0.04%) | 90.25 kB → 90.29 kB `src/components/accounts/Account.tsx` | 📉 -577 B (-1.26%) | 44.66 kB → 44.09 kB `src/components/accounts/Header.tsx` | 📉 -627 B (-2.14%) | 28.61 kB → 28 kB `home/runner/work/actual/actual/packages/component-library/src/icons/v2/UploadThickBottom.tsx` | 🔥 -918 B (-100%) | 918 B → 0 B </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/extends.js | 500.61 kB → 500.96 kB (+360 B) | +0.07% static/js/theme.js | 31.77 kB → 31.88 kB (+120 B) | +0.37% static/js/index.js | 1.54 MB → 1.54 MB (+45 B) | +0.00% **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/wide.js | 297.28 kB → 296.1 kB (-1.18 kB) | -0.40% static/js/Value.js | 5.08 MB → 5.08 MB (-880 B) | -0.02% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.98 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.26 MB | 0% static/js/ScheduleEditForm.js | 146.44 kB | 0% static/js/SchedulesTable.js | 202.7 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 186.75 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.15 kB | 0% static/js/de.js | 170.77 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 198.24 kB | 0% static/js/es.js | 178.68 kB | 0% static/js/fr.js | 178.57 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.05 kB | 0% static/js/nl.js | 106.24 kB | 0% static/js/pt-BR.js | 188.43 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.48 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 207.46 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.89 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.34 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.D308xu1O.js | 5.34 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.97 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-17 21:04:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#136338
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?