github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7749] [AI] Fix Escape to exit edit mode and clear multi-select in tables #136159

New Issue
Open
opened 2026-06-17 20:46:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-17 20:46:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7749
Author: @nikhilweee
Created: 5/8/2026
Status: 🔄 Open

Base: master ← Head: fix-escape-key-table-cells

📝 Commits (10+)

  • ded1ccb [AI] Fix Escape to exit edit mode and clear multi-select in tables
  • 21c1d2f [AI] Add release notes for #7749
  • bbfed40 [AI] Fix Escape key handling in TagAutocomplete and NotesCell
  • ab98767 [AI] fix: remove unused onUpdate prop to pass typecheck
  • aa64f43 [AI] fix: require 2 escapes to exit Notes edit mode when tag popup is open
  • 9fa731f [AI] Improve table keyboard navigation
  • a9783a7 [AI] fix: restore onUpdate in TagAutocomplete and reset DOM value on escape
  • 591699c Merge remote-tracking branch 'origin/master' into fix-escape-key-table-cells
  • 85ae69f [AI] fix: wait for transaction rows before selecting in escape e2e tests
  • 06e468a [AI] chore: retrigger CI (transient electron/sharp install timeouts)

📊 Changes

6 files changed (+419 additions, -6 deletions)

View changed files

➕ packages/desktop-client/e2e/keyboard-navigation.test.ts (+318 -0)
📝 packages/desktop-client/src/components/autocomplete/TagAutocomplete.tsx (+6 -1)
📝 packages/desktop-client/src/components/budget/BudgetTable.tsx (+3 -0)
📝 packages/desktop-client/src/components/table.tsx (+73 -4)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+13 -1)
➕ upcoming-release-notes/7749.md (+6 -0)

📄 Description

Description

Clicking a cell in the transactions, budget, payees, or tags table jumps directly into edit mode, but pressing Escape previously did nothing useful: in plain text cells it would revert the typed value but the input stayed focused; in autocomplete or date-picker cells it didn't even do that. Multi-selecting rows via checkboxes also had no keyboard escape — you had to click the checkboxes again or use the toolbar to clear the selection.

This PR makes Escape a proper "back out" key:

  • Inside an editable cell: Escape exits edit mode and reverts the typed value.
  • With rows checkbox-selected (and no cell being edited): Escape clears the selection in a single press.
  • When both states overlap (a cell is being edited and rows are checked): the first Escape exits edit, the second clears the selection.
  • Popovers (autocomplete dropdown, date picker) keep their existing Escape-to-close behavior; their handlers stop propagation, so the new Escape logic only fires once the popover is closed.

Related issue(s)

None.

Testing

Manual:

  1. Open the demo budget (View demo).
  2. Budget grid: click any budgeted cell, type a new value, press Escape — cell exits edit mode and reverts to its previous value (the total budgeted at the top should not change).
  3. Transactions table (open any account):
    • Click a notes/payee/category cell, type, press Escape ��� value reverts and cell exits.
    • Open a category cell with the autocomplete dropdown, press Escape — dropdown closes; press Escape again — cell exits.
    • Check 3 rows via checkboxes, press Escape — all unchecked, toolbar disappears.
    • Check rows, then click another cell to edit; press Escape — exit edit (rows still checked); press Escape again — rows unchecked.
  4. Payees and Tags pages: same behavior where applicable.

Automated: new packages/desktop-client/e2e/keyboard-navigation.test.ts (6 tests) covers the budget grid (test budget + demo budget), transactions table (single ESC, multi-select clear, layered peel-off), and the cell-with-existing-value scenario that surfaces the value-revert path.

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.14 MB → 14.14 MB (+1.74 kB) +0.01%
loot-core 1 5.28 MB 0%
api 2 3.87 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.14 MB → 14.14 MB (+1.74 kB) +0.01%
Changeset
File Δ Size
src/components/table.tsx 📈 +1.35 kB (+3.51%) 38.37 kB → 39.72 kB
src/components/autocomplete/TagAutocomplete.tsx 📈 +88 B (+1.36%) 6.32 kB → 6.4 kB
src/components/budget/BudgetTable.tsx 📈 +82 B (+0.80%) 9.99 kB → 10.07 kB
src/components/transactions/TransactionsTable.tsx 📈 +234 B (+0.25%) 90.38 kB → 90.61 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/Value.js 5.08 MB → 5.09 MB (+1.66 kB) +0.03%
static/js/wide.js 298.88 kB → 298.96 kB (+82 B) +0.03%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.6 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.63 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ReportRouter.js 1.27 MB 0%
static/js/ScheduleEditForm.js 146.57 kB 0%
static/js/SchedulesTable.js 206.3 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 185.63 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 100.19 kB 0%
static/js/de.js 181.63 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 201.71 kB 0%
static/js/es.js 177.58 kB 0%
static/js/extends.js 508.79 kB 0%
static/js/fr.js 177.35 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 163.93 kB 0%
static/js/narrow.js 365.05 kB 0%
static/js/nb-NO.js 147.07 kB 0%
static/js/nl.js 119.71 kB 0%
static/js/pt-BR.js 187.34 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 173.33 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.18 kB 0%
static/js/uk.js 216.7 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.44 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.28 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.Co0zOyQO.js 5.28 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.87 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.87 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7749 **Author:** [@nikhilweee](https://github.com/nikhilweee) **Created:** 5/8/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-escape-key-table-cells` --- ### 📝 Commits (10+) - [`ded1ccb`](https://github.com/actualbudget/actual/commit/ded1ccbc67171cdf2033a3783109b0053bdefa81) [AI] Fix Escape to exit edit mode and clear multi-select in tables - [`21c1d2f`](https://github.com/actualbudget/actual/commit/21c1d2f0c46736313e6c935566625c7b933f6362) [AI] Add release notes for #7749 - [`bbfed40`](https://github.com/actualbudget/actual/commit/bbfed40035cc20e92f07b7c46feddd0500f146e1) [AI] Fix Escape key handling in TagAutocomplete and NotesCell - [`ab98767`](https://github.com/actualbudget/actual/commit/ab9876749fb5910f19384689e60683e623cf4fdb) [AI] fix: remove unused onUpdate prop to pass typecheck - [`aa64f43`](https://github.com/actualbudget/actual/commit/aa64f43429bb0872ace1a4ef3850b0726a1e9c3c) [AI] fix: require 2 escapes to exit Notes edit mode when tag popup is open - [`9fa731f`](https://github.com/actualbudget/actual/commit/9fa731fd32580a46fa91717ced17c0708f6f5cad) [AI] Improve table keyboard navigation - [`a9783a7`](https://github.com/actualbudget/actual/commit/a9783a7812d33d6fc4cb037f5de136d0df482bf5) [AI] fix: restore onUpdate in TagAutocomplete and reset DOM value on escape - [`591699c`](https://github.com/actualbudget/actual/commit/591699ce9a9eaf92cd83b94f5eaf683776ec58cd) Merge remote-tracking branch 'origin/master' into fix-escape-key-table-cells - [`85ae69f`](https://github.com/actualbudget/actual/commit/85ae69f78bfbb520566da34695ccd970861537b9) [AI] fix: wait for transaction rows before selecting in escape e2e tests - [`06e468a`](https://github.com/actualbudget/actual/commit/06e468a2aeeaf3cd74c92d7a6dfc39a2ee037b09) [AI] chore: retrigger CI (transient electron/sharp install timeouts) ### 📊 Changes **6 files changed** (+419 additions, -6 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/e2e/keyboard-navigation.test.ts` (+318 -0) 📝 `packages/desktop-client/src/components/autocomplete/TagAutocomplete.tsx` (+6 -1) 📝 `packages/desktop-client/src/components/budget/BudgetTable.tsx` (+3 -0) 📝 `packages/desktop-client/src/components/table.tsx` (+73 -4) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+13 -1) ➕ `upcoming-release-notes/7749.md` (+6 -0) </details> ### 📄 Description ## Description Clicking a cell in the transactions, budget, payees, or tags table jumps directly into edit mode, but pressing **Escape** previously did nothing useful: in plain text cells it would revert the typed value but the input stayed focused; in autocomplete or date-picker cells it didn't even do that. Multi-selecting rows via checkboxes also had no keyboard escape — you had to click the checkboxes again or use the toolbar to clear the selection. This PR makes Escape a proper "back out" key: - Inside an editable cell: Escape exits edit mode and reverts the typed value. - With rows checkbox-selected (and no cell being edited): Escape clears the selection in a single press. - When both states overlap (a cell is being edited *and* rows are checked): the first Escape exits edit, the second clears the selection. - Popovers (autocomplete dropdown, date picker) keep their existing Escape-to-close behavior; their handlers stop propagation, so the new Escape logic only fires once the popover is closed. ## Related issue(s) None. ## Testing Manual: 1. Open the demo budget (View demo). 2. **Budget grid**: click any budgeted cell, type a new value, press Escape — cell exits edit mode and reverts to its previous value (the total budgeted at the top should not change). 3. **Transactions table** (open any account): - Click a notes/payee/category cell, type, press Escape ��� value reverts and cell exits. - Open a category cell with the autocomplete dropdown, press Escape — dropdown closes; press Escape again — cell exits. - Check 3 rows via checkboxes, press Escape — all unchecked, toolbar disappears. - Check rows, then click another cell to edit; press Escape — exit edit (rows still checked); press Escape again — rows unchecked. 4. **Payees** and **Tags** pages: same behavior where applicable. Automated: new `packages/desktop-client/e2e/keyboard-navigation.test.ts` (6 tests) covers the budget grid (test budget + demo budget), transactions table (single ESC, multi-select clear, layered peel-off), and the cell-with-existing-value scenario that surfaces the value-revert path. ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.14 MB → 14.14 MB (+1.74 kB) | +0.01% loot-core | 1 | 5.28 MB | 0% api | 2 | 3.87 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.14 MB → 14.14 MB (+1.74 kB) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/table.tsx` | 📈 +1.35 kB (+3.51%) | 38.37 kB → 39.72 kB `src/components/autocomplete/TagAutocomplete.tsx` | 📈 +88 B (+1.36%) | 6.32 kB → 6.4 kB `src/components/budget/BudgetTable.tsx` | 📈 +82 B (+0.80%) | 9.99 kB → 10.07 kB `src/components/transactions/TransactionsTable.tsx` | 📈 +234 B (+0.25%) | 90.38 kB → 90.61 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/Value.js | 5.08 MB → 5.09 MB (+1.66 kB) | +0.03% static/js/wide.js | 298.88 kB → 298.96 kB (+82 B) | +0.03% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.6 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.63 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.27 MB | 0% static/js/ScheduleEditForm.js | 146.57 kB | 0% static/js/SchedulesTable.js | 206.3 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 185.63 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 100.19 kB | 0% static/js/de.js | 181.63 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 201.71 kB | 0% static/js/es.js | 177.58 kB | 0% static/js/extends.js | 508.79 kB | 0% static/js/fr.js | 177.35 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 163.93 kB | 0% static/js/narrow.js | 365.05 kB | 0% static/js/nb-NO.js | 147.07 kB | 0% static/js/nl.js | 119.71 kB | 0% static/js/pt-BR.js | 187.34 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 173.33 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.18 kB | 0% static/js/uk.js | 216.7 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.44 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.28 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.Co0zOyQO.js | 5.28 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.87 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.87 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-17 20:46:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#136159
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?