github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-08 21:12:08 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6438] [MERGED] fix(privacy): hide currency symbols in redacted overlay #13579

New Issue
Closed
opened 2026-04-10 21:58:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 21:58:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6438
Author: @StephenBrown2
Created: 12/17/2025
Status: ✅ Merged
Merged: 1/13/2026
Merged by: @matt-fidd

Base: master ← Head: redacted-content-currency-symbol

📝 Commits (2)

  • 71e25df fix(privacy): hide currency symbols in redacted overlay
  • a19cda9 refactor: simplify RedactedContent text node processing loop

📊 Changes

2 files changed (+40 additions, -2 deletions)

View changed files

📝 packages/desktop-client/src/components/PrivacyFilter.tsx (+34 -2)
➕ upcoming-release-notes/6438.md (+6 -0)

📄 Description

Add RedactedContent component that uses useLayoutEffect to walk the DOM and replace non-alphanumeric characters (like currency symbols) with spaces. This ensures characters not rendered by Redacted Script font are hidden, regardless of how deeply nested they are in the component tree.

Addresses an issue I saw in discord:
https://discord.com/channels/937901803608096828/1033401142601859112/1450314521137647688

Here's a before and after screenshot with Pesos enabled in Currency settings:

Before:

Screenshot from 2025-12-17 15-03-21

After:

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6438 **Author:** [@StephenBrown2](https://github.com/StephenBrown2) **Created:** 12/17/2025 **Status:** ✅ Merged **Merged:** 1/13/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `redacted-content-currency-symbol` --- ### 📝 Commits (2) - [`71e25df`](https://github.com/actualbudget/actual/commit/71e25dfa7d575e356312380184279dcb309dfee4) fix(privacy): hide currency symbols in redacted overlay - [`a19cda9`](https://github.com/actualbudget/actual/commit/a19cda9485bae9b8b99e2093623f757a88d5f853) refactor: simplify RedactedContent text node processing loop ### 📊 Changes **2 files changed** (+40 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/PrivacyFilter.tsx` (+34 -2) ➕ `upcoming-release-notes/6438.md` (+6 -0) </details> ### 📄 Description Add RedactedContent component that uses useLayoutEffect to walk the DOM and replace non-alphanumeric characters (like currency symbols) with spaces. This ensures characters not rendered by Redacted Script font are hidden, regardless of how deeply nested they are in the component tree. Addresses an issue I saw in discord: https://discord.com/channels/937901803608096828/1033401142601859112/1450314521137647688 Here's a before and after screenshot with Pesos enabled in Currency settings: Before: <img width="713" height="645" alt="Screenshot from 2025-12-17 15-03-21" src="https://github.com/user-attachments/assets/1269cc49-8ba2-4f01-a04d-2c53729e43e7" /> After: <img width="713" height="645" alt="image" src="https://github.com/user-attachments/assets/82bb290f-c1ce-41b8-82e2-19ea35b3f626" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 21:58:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#13579
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?