github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-13 17:43:23 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6240] Fix merging split transactions #13458

New Issue
Closed
opened 2026-04-10 21:54:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 21:54:37 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/actualbudget/actual/pull/6240

State: closed
Merged: Yes

Fixes https://github.com/actualbudget/actual/issues/5781

This resolves the lint and testing issues identified in https://github.com/actualbudget/actual/pull/5856, which was closed for inactivity. The following description is taken from that PR:

Changes

  • Modified mergeTransactions to load subtransactions for both transactions being merged
  • When the kept transaction doesn't have splits but the dropped one does, transfer all subtransactions by updating their parent_id
  • Mark the kept transaction as is_parent and clear its category (parent transactions with splits shouldn't have a direct category)
  • Added comprehensive test covering this scenario

Test Plan

Added test preserves split categories when merging split transaction with uncategorized imported transaction which:

  • Creates a manual parent transaction with 2 subtransactions (different categories)
  • Creates an imported transaction without splits
  • Merges them
  • Verifies subtransactions are transferred with correct parent_id
  • Verifies no orphaned subtransactions remain
**Original Pull Request:** https://github.com/actualbudget/actual/pull/6240 **State:** closed **Merged:** Yes --- Fixes https://github.com/actualbudget/actual/issues/5781 This resolves the lint and testing issues identified in https://github.com/actualbudget/actual/pull/5856, which was closed for inactivity. The following description is taken from that PR: ## Changes - Modified mergeTransactions to load subtransactions for both transactions being merged - When the kept transaction doesn't have splits but the dropped one does, transfer all subtransactions by updating their parent_id - Mark the kept transaction as is_parent and clear its category (parent transactions with splits shouldn't have a direct category) - Added comprehensive test covering this scenario ## Test Plan Added test preserves split categories when merging split transaction with uncategorized imported transaction which: - Creates a manual parent transaction with 2 subtransactions (different categories) - Creates an imported transaction without splits - Merges them - Verifies subtransactions are transferred with correct parent_id - Verifies no orphaned subtransactions remain
GiteaMirror added the pull-request label 2026-04-10 21:54:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#13458