github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #1427] [CLOSED] ♻️ (selectors) added reselect state selectors #132527

New Issue
Closed
opened 2026-06-17 14:36:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-17 14:36:55 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1427
Author: @MatissJanis
Created: 7/30/2023
Status: ❌ Closed

Base: master ← Head: matiss/add-selectors

📝 Commits (3)

  • 9466ca3 ♻️ (selectors) added reselect state selectors
  • d31298d Release notes
  • 4c43018 Remove budgetMonth

📊 Changes

52 files changed (+433 additions, -174 deletions)

View changed files

📝 packages/desktop-client/src/components/App.js (+8 -7)
📝 packages/desktop-client/src/components/BankSyncStatus.js (+3 -1)
📝 packages/desktop-client/src/components/FloatableSidebar.js (+4 -6)
📝 packages/desktop-client/src/components/LoggedInUser.js (+3 -1)
📝 packages/desktop-client/src/components/ManageRules.js (+9 -4)
📝 packages/desktop-client/src/components/MobileWebMessage.js (+3 -3)
📝 packages/desktop-client/src/components/Modals.tsx (+10 -6)
📝 packages/desktop-client/src/components/SidebarWithData.js (+12 -7)
📝 packages/desktop-client/src/components/Titlebar.js (+10 -6)
📝 packages/desktop-client/src/components/UpdateNotification.js (+7 -4)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.js (+7 -2)
📝 packages/desktop-client/src/components/accounts/MobileAccount.js (+2 -1)
📝 packages/desktop-client/src/components/accounts/MobileAccounts.js (+14 -10)
📝 packages/desktop-client/src/components/budget/DynamicBudgetTable.js (+3 -1)
📝 packages/desktop-client/src/components/budget/MobileBudget.js (+10 -8)
📝 packages/desktop-client/src/components/budget/index.js (+8 -5)
📝 packages/desktop-client/src/components/filters/FiltersMenu.js (+2 -5)
📝 packages/desktop-client/src/components/manager/ManagementApp.js (+3 -1)
📝 packages/desktop-client/src/components/modals/EditField.js (+10 -6)
📝 packages/desktop-client/src/components/modals/EditRule.js (+2 -3)

...and 32 more files

📄 Description

Apologies for the large PR. The scope, however, is pretty limited so I hope this to be a pain-less review.

Functionally there should be no changes. I'm just moving the state selectors from manually defined to common selectors defined with reselect.

Not all selectors are moved with this PR. There are still a lot remaining that I will pick up as a follow-up PR to reduce the scope here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1427 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 7/30/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `matiss/add-selectors` --- ### 📝 Commits (3) - [`9466ca3`](https://github.com/actualbudget/actual/commit/9466ca3224adb53361e0a3444f01e6651eb8d505) :recycle: (selectors) added reselect state selectors - [`d31298d`](https://github.com/actualbudget/actual/commit/d31298db25cf76aa1bcf6a2c170531e0b7e4e3bb) Release notes - [`4c43018`](https://github.com/actualbudget/actual/commit/4c43018f5148838850152d7e84e7df4c0e17896a) Remove budgetMonth ### 📊 Changes **52 files changed** (+433 additions, -174 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/App.js` (+8 -7) 📝 `packages/desktop-client/src/components/BankSyncStatus.js` (+3 -1) 📝 `packages/desktop-client/src/components/FloatableSidebar.js` (+4 -6) 📝 `packages/desktop-client/src/components/LoggedInUser.js` (+3 -1) 📝 `packages/desktop-client/src/components/ManageRules.js` (+9 -4) 📝 `packages/desktop-client/src/components/MobileWebMessage.js` (+3 -3) 📝 `packages/desktop-client/src/components/Modals.tsx` (+10 -6) 📝 `packages/desktop-client/src/components/SidebarWithData.js` (+12 -7) 📝 `packages/desktop-client/src/components/Titlebar.js` (+10 -6) 📝 `packages/desktop-client/src/components/UpdateNotification.js` (+7 -4) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.js` (+7 -2) 📝 `packages/desktop-client/src/components/accounts/MobileAccount.js` (+2 -1) 📝 `packages/desktop-client/src/components/accounts/MobileAccounts.js` (+14 -10) 📝 `packages/desktop-client/src/components/budget/DynamicBudgetTable.js` (+3 -1) 📝 `packages/desktop-client/src/components/budget/MobileBudget.js` (+10 -8) 📝 `packages/desktop-client/src/components/budget/index.js` (+8 -5) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.js` (+2 -5) 📝 `packages/desktop-client/src/components/manager/ManagementApp.js` (+3 -1) 📝 `packages/desktop-client/src/components/modals/EditField.js` (+10 -6) 📝 `packages/desktop-client/src/components/modals/EditRule.js` (+2 -3) _...and 32 more files_ </details> ### 📄 Description Apologies for the large PR. The scope, however, is pretty limited so I hope this to be a pain-less review. Functionally there should be no changes. I'm just moving the state selectors from manually defined to common selectors defined with `reselect`. Not all selectors are moved with this PR. There are still a lot remaining that I will pick up as a follow-up PR to reduce the scope here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-17 14:36:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#132527