github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 14:43:36 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8228] [CLOSED] [WIP] fix(rules): prevent append/prepend-notes rules from being ignored when note already exists #131763

New Issue
Closed
opened 2026-06-16 00:34:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-16 00:34:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8228
Author: @okxint
Created: 6/15/2026
Status: ❌ Closed

Base: master ← Head: fix/append-notes-existing-note

📝 Commits (6)

  • 72fe53b Add release notes for PR #7177
  • d7116a2 Fix append/prepend notes rule not working when note already exists
  • 9a1b186 Add release notes for #7568
  • a6a6653 fix(rules): prevent duplicate _forceApplyFields entries for append/prepend-notes
  • c57c6c3 refactor(rules): return forceFields separately from runRules instead of tagging transaction
  • a525692 [autofix.ci] apply automated fixes

📊 Changes

12 files changed (+139 additions, -29 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx (+8 -3)
📝 packages/desktop-client/src/components/transactions/TransactionList.tsx (+5 -1)
📝 packages/loot-core/src/server/accounts/sync.ts (+2 -2)
📝 packages/loot-core/src/server/forecast/forecast-schedules.ts (+2 -2)
📝 packages/loot-core/src/server/rules/action.ts (+3 -1)
📝 packages/loot-core/src/server/rules/app.ts (+1 -1)
📝 packages/loot-core/src/server/rules/index.test.ts (+60 -0)
📝 packages/loot-core/src/server/rules/rule.ts (+28 -12)
📝 packages/loot-core/src/server/transactions/transaction-rules.test.ts (+6 -1)
📝 packages/loot-core/src/server/transactions/transaction-rules.ts (+15 -5)
📝 packages/loot-core/src/server/transactions/transfer.ts (+3 -1)
➕ upcoming-release-notes/7568.md (+6 -0)

📄 Description

What

append-notes and prepend-notes rule actions had no effect when the transaction already had a note. The UI only applied rule-computed values to empty fields, so the appended text was silently discarded.

Fix

  • Added _forceApplyFields metadata so the UI knows to always apply changes from append/prepend operations even when a field is non-empty (fixes #7303)
  • Fixed a bug where duplicate entries could accumulate in _forceApplyFields
  • Refactored runRules to return a dedicated forceFields: Set<string> alongside the transaction, instead of attaching execution metadata directly to the transaction object — keeps domain data clean and avoids leaking internal rule-runner state (fixes #7568)

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 13.23 MB → 13.23 MB (+248 B) +0.00%
loot-core 1 4.86 MB → 4.86 MB (+442 B) +0.01%
api 2 3.87 MB → 3.87 MB (+436 B) +0.01%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 13.23 MB → 13.23 MB (+248 B) +0.00%
Changeset
File Δ Size
src/components/transactions/TransactionList.tsx 📈 +107 B (+0.60%) 17.29 kB → 17.39 kB
src/components/mobile/transactions/TransactionEdit.tsx 📈 +141 B (+0.19%) 71.47 kB → 71.61 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/TransactionEdit.js 90.63 kB → 90.76 kB (+141 B) +0.15%
static/js/Value.js 4.49 MB → 4.49 MB (+107 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.58 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 814.39 kB 0%
static/js/ManageRules.js 46.47 kB 0%
static/js/PayeeRuleCountLabel.js 7.1 kB 0%
static/js/ReportRouter.js 1.25 MB 0%
static/js/ScheduleEditForm.js 146.51 kB 0%
static/js/SchedulesTable.js 203.52 kB 0%
static/js/TransactionList.js 82.8 kB 0%
static/js/_baseIsEqual.js 76.76 kB 0%
static/js/ca.js 185.63 kB 0%
static/js/client.js 450.92 kB 0%
static/js/da.js 100.19 kB 0%
static/js/de.js 182.38 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 202.14 kB 0%
static/js/es.js 177.58 kB 0%
static/js/extends.js 473.99 kB 0%
static/js/fr.js 177.35 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 163.93 kB 0%
static/js/narrow.js 364.55 kB 0%
static/js/nb-NO.js 147.07 kB 0%
static/js/nl.js 119.71 kB 0%
static/js/pt-BR.js 187.34 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 173.33 kB 0%
static/js/theme.js 31.01 kB 0%
static/js/toString.js 638.95 kB 0%
static/js/uk.js 216.7 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 298.23 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.44 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.86 MB → 4.86 MB (+442 B) +0.01%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/rules/rule.ts 📈 +130 B (+2.84%) 4.47 kB → 4.59 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/action.ts 📈 +83 B (+1.01%) 8.06 kB → 8.14 kB
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts 📈 +144 B (+0.66%) 21.17 kB → 21.31 kB
home/runner/work/actual/actual/packages/loot-core/src/server/forecast/forecast-schedules.ts 📈 +34 B (+0.53%) 6.32 kB → 6.35 kB
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transfer.ts 📈 +17 B (+0.45%) 3.68 kB → 3.7 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts 📈 +34 B (+0.13%) 24.8 kB → 24.83 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.BERqxF_5.js 0 B → 4.86 MB (+4.86 MB) -

Removed

Asset File Size % Changed
kcab.worker.DhLbg59B.js 4.86 MB → 0 B (-4.86 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
2 3.87 MB → 3.87 MB (+436 B) +0.01%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/rules/rule.ts 📈 +130 B (+3.02%) 4.2 kB → 4.33 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/action.ts 📈 +81 B (+1.04%) 7.6 kB → 7.68 kB
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts 📈 +140 B (+0.66%) 20.75 kB → 20.89 kB
home/runner/work/actual/actual/packages/loot-core/src/server/forecast/forecast-schedules.ts 📈 +34 B (+0.53%) 6.28 kB → 6.32 kB
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transfer.ts 📈 +17 B (+0.46%) 3.58 kB → 3.6 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts 📈 +34 B (+0.14%) 24.32 kB → 24.35 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.87 MB → 3.87 MB (+436 B) +0.01%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8228 **Author:** [@okxint](https://github.com/okxint) **Created:** 6/15/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/append-notes-existing-note` --- ### 📝 Commits (6) - [`72fe53b`](https://github.com/actualbudget/actual/commit/72fe53b2956788cbf0776fcefa6904001dcd3765) Add release notes for PR #7177 - [`d7116a2`](https://github.com/actualbudget/actual/commit/d7116a2bb8abface117f1ea08612d56dc647fbab) Fix append/prepend notes rule not working when note already exists - [`9a1b186`](https://github.com/actualbudget/actual/commit/9a1b1862a43931b2e1416e1a3bb1ef153f4940b5) Add release notes for #7568 - [`a6a6653`](https://github.com/actualbudget/actual/commit/a6a6653794ceebc7504f805e9f05ca953bdd552d) fix(rules): prevent duplicate _forceApplyFields entries for append/prepend-notes - [`c57c6c3`](https://github.com/actualbudget/actual/commit/c57c6c3e79fe61fed140fb68f1f05d4af76d1aee) refactor(rules): return forceFields separately from runRules instead of tagging transaction - [`a525692`](https://github.com/actualbudget/actual/commit/a525692718821cb131804700df367b698d00b47d) [autofix.ci] apply automated fixes ### 📊 Changes **12 files changed** (+139 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx` (+8 -3) 📝 `packages/desktop-client/src/components/transactions/TransactionList.tsx` (+5 -1) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+2 -2) 📝 `packages/loot-core/src/server/forecast/forecast-schedules.ts` (+2 -2) 📝 `packages/loot-core/src/server/rules/action.ts` (+3 -1) 📝 `packages/loot-core/src/server/rules/app.ts` (+1 -1) 📝 `packages/loot-core/src/server/rules/index.test.ts` (+60 -0) 📝 `packages/loot-core/src/server/rules/rule.ts` (+28 -12) 📝 `packages/loot-core/src/server/transactions/transaction-rules.test.ts` (+6 -1) 📝 `packages/loot-core/src/server/transactions/transaction-rules.ts` (+15 -5) 📝 `packages/loot-core/src/server/transactions/transfer.ts` (+3 -1) ➕ `upcoming-release-notes/7568.md` (+6 -0) </details> ### 📄 Description ## What `append-notes` and `prepend-notes` rule actions had no effect when the transaction already had a note. The UI only applied rule-computed values to empty fields, so the appended text was silently discarded. ## Fix - Added `_forceApplyFields` metadata so the UI knows to always apply changes from append/prepend operations even when a field is non-empty (fixes #7303) - Fixed a bug where duplicate entries could accumulate in `_forceApplyFields` - Refactored `runRules` to return a dedicated `forceFields: Set<string>` alongside the transaction, instead of attaching execution metadata directly to the transaction object — keeps domain data clean and avoids leaking internal rule-runner state (fixes #7568) <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 13.23 MB → 13.23 MB (+248 B) | +0.00% loot-core | 1 | 4.86 MB → 4.86 MB (+442 B) | +0.01% api | 2 | 3.87 MB → 3.87 MB (+436 B) | +0.01% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 13.23 MB → 13.23 MB (+248 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/transactions/TransactionList.tsx` | 📈 +107 B (+0.60%) | 17.29 kB → 17.39 kB `src/components/mobile/transactions/TransactionEdit.tsx` | 📈 +141 B (+0.19%) | 71.47 kB → 71.61 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/TransactionEdit.js | 90.63 kB → 90.76 kB (+141 B) | +0.15% static/js/Value.js | 4.49 MB → 4.49 MB (+107 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.58 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 814.39 kB | 0% static/js/ManageRules.js | 46.47 kB | 0% static/js/PayeeRuleCountLabel.js | 7.1 kB | 0% static/js/ReportRouter.js | 1.25 MB | 0% static/js/ScheduleEditForm.js | 146.51 kB | 0% static/js/SchedulesTable.js | 203.52 kB | 0% static/js/TransactionList.js | 82.8 kB | 0% static/js/_baseIsEqual.js | 76.76 kB | 0% static/js/ca.js | 185.63 kB | 0% static/js/client.js | 450.92 kB | 0% static/js/da.js | 100.19 kB | 0% static/js/de.js | 182.38 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 202.14 kB | 0% static/js/es.js | 177.58 kB | 0% static/js/extends.js | 473.99 kB | 0% static/js/fr.js | 177.35 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 163.93 kB | 0% static/js/narrow.js | 364.55 kB | 0% static/js/nb-NO.js | 147.07 kB | 0% static/js/nl.js | 119.71 kB | 0% static/js/pt-BR.js | 187.34 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 173.33 kB | 0% static/js/theme.js | 31.01 kB | 0% static/js/toString.js | 638.95 kB | 0% static/js/uk.js | 216.7 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 298.23 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.44 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.86 MB → 4.86 MB (+442 B) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/rules/rule.ts` | 📈 +130 B (+2.84%) | 4.47 kB → 4.59 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/action.ts` | 📈 +83 B (+1.01%) | 8.06 kB → 8.14 kB `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts` | 📈 +144 B (+0.66%) | 21.17 kB → 21.31 kB `home/runner/work/actual/actual/packages/loot-core/src/server/forecast/forecast-schedules.ts` | 📈 +34 B (+0.53%) | 6.32 kB → 6.35 kB `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transfer.ts` | 📈 +17 B (+0.45%) | 3.68 kB → 3.7 kB `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts` | 📈 +34 B (+0.13%) | 24.8 kB → 24.83 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BERqxF_5.js | 0 B → 4.86 MB (+4.86 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DhLbg59B.js | 4.86 MB → 0 B (-4.86 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.87 MB → 3.87 MB (+436 B) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/rules/rule.ts` | 📈 +130 B (+3.02%) | 4.2 kB → 4.33 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/action.ts` | 📈 +81 B (+1.04%) | 7.6 kB → 7.68 kB `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts` | 📈 +140 B (+0.66%) | 20.75 kB → 20.89 kB `home/runner/work/actual/actual/packages/loot-core/src/server/forecast/forecast-schedules.ts` | 📈 +34 B (+0.53%) | 6.28 kB → 6.32 kB `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transfer.ts` | 📈 +17 B (+0.46%) | 3.58 kB → 3.6 kB `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts` | 📈 +34 B (+0.14%) | 24.32 kB → 24.35 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.87 MB → 3.87 MB (+436 B) | +0.01% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-16 00:34:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#131763
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?