github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-11 11:59:55 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8227] [CLOSED] [WIP] fix(reports): apply correct filters when drilling down from Transfer/Uncategorized bars #131762

New Issue
Closed
opened 2026-06-16 00:34:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-16 00:34:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8227
Author: @okxint
Created: 6/15/2026
Status: ❌ Closed

Base: master ← Head: fix/report-drill-down-transfer-filter

📝 Commits (2)

  • f1289f2 fix(reports): apply correct filters when drilling down from Transfer/Uncategorized bars
  • 494cf22 fix(reports): resolve TypeScript type errors in BarGraph and DonutGraph for uncategorized_id

📊 Changes

10 files changed (+87 additions, -27 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/graphs/BarGraph.tsx (+24 -18)
📝 packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx (+9 -1)
📝 packages/desktop-client/src/components/reports/graphs/LineGraph.tsx (+2 -0)
📝 packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx (+1 -0)
📝 packages/desktop-client/src/components/reports/graphs/showActivity.ts (+25 -7)
📝 packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableRow.tsx (+4 -0)
📝 packages/desktop-client/src/components/reports/spreadsheets/calculateLegend.ts (+9 -1)
📝 packages/desktop-client/src/components/reports/spreadsheets/recalculate.ts (+3 -0)
📝 packages/loot-core/src/types/models/reports.ts (+4 -0)
➕ upcoming-release-notes/7999.md (+6 -0)

📄 Description

What

Clicking a Transfer, Off-budget, or Uncategorized bar in a Custom Report chart opened the transaction drill-down with no category filter applied — showing all transactions for the period instead of the relevant subset.

These are pseudo-categories with id: '', which is falsy, so showActivity silently skipped the filter.

Fix

Thread an uncategorized_id value (transfer | off_budget | other) from UncategorizedEntity through GroupedEntity → LegendEntity → showActivity. In showActivity, pseudo-categories now receive the correct filters:

  • transfer: { field: 'transfer', op: 'is', value: true }
  • other: { field: 'category', op: 'is', value: null } + transfer is false

Also fixes TypeScript type errors in BarGraph and DonutGraph for uncategorized_id.

Fixes #7999

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8227 **Author:** [@okxint](https://github.com/okxint) **Created:** 6/15/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/report-drill-down-transfer-filter` --- ### 📝 Commits (2) - [`f1289f2`](https://github.com/actualbudget/actual/commit/f1289f267d7e68eecebfefacb98df0ae49d28bc9) fix(reports): apply correct filters when drilling down from Transfer/Uncategorized bars - [`494cf22`](https://github.com/actualbudget/actual/commit/494cf22d9876ee4c01a44e510e65bb80975db31b) fix(reports): resolve TypeScript type errors in BarGraph and DonutGraph for uncategorized_id ### 📊 Changes **10 files changed** (+87 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/graphs/BarGraph.tsx` (+24 -18) 📝 `packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx` (+9 -1) 📝 `packages/desktop-client/src/components/reports/graphs/LineGraph.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/reports/graphs/showActivity.ts` (+25 -7) 📝 `packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableRow.tsx` (+4 -0) 📝 `packages/desktop-client/src/components/reports/spreadsheets/calculateLegend.ts` (+9 -1) 📝 `packages/desktop-client/src/components/reports/spreadsheets/recalculate.ts` (+3 -0) 📝 `packages/loot-core/src/types/models/reports.ts` (+4 -0) ➕ `upcoming-release-notes/7999.md` (+6 -0) </details> ### 📄 Description ## What Clicking a Transfer, Off-budget, or Uncategorized bar in a Custom Report chart opened the transaction drill-down with no category filter applied — showing all transactions for the period instead of the relevant subset. These are pseudo-categories with `id: ''`, which is falsy, so `showActivity` silently skipped the filter. ## Fix Thread an `uncategorized_id` value (`transfer | off_budget | other`) from `UncategorizedEntity` through `GroupedEntity` → `LegendEntity` → `showActivity`. In `showActivity`, pseudo-categories now receive the correct filters: - `transfer`: `{ field: 'transfer', op: 'is', value: true }` - `other`: `{ field: 'category', op: 'is', value: null }` + transfer is false Also fixes TypeScript type errors in `BarGraph` and `DonutGraph` for `uncategorized_id`. Fixes #7999 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-16 00:34:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#131762
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?