[Bug]: Re-Linking Bank Account (simpleFIN) to Actual Account not fetching transactions and producing error + report to Github dialogue #1317

New Issue

@latetedemelon commented on GitHub (Aug 11, 2024):

I'm having the same happen since the upgrade to 24.8.0. In fact, after (re)linking an account the account linking screen becomes blank afterwards. Upgrading to edge has the same symptoms.

@latetedemelon commented on GitHub (Aug 11, 2024): I'm having the same happen since the upgrade to 24.8.0. In fact, after (re)linking an account the account linking screen becomes blank afterwards. Upgrading to edge has the same symptoms.

GiteaMirror commented

@palermog commented on GitHub (Sep 4, 2024):

I'm having the same issue where the account linking screen becomes blank.

@palermog commented on GitHub (Sep 4, 2024): I'm having the same issue where the account linking screen becomes blank.

GiteaMirror commented

@muammar commented on GitHub (Sep 5, 2024):

I'm having the same issue where the account linking screen becomes blank.

Same here. It all was working perfectly fine before this last update.

@muammar commented on GitHub (Sep 5, 2024): > I'm having the same issue where the account linking screen becomes blank. Same here. It all was working perfectly fine before this last update.

GiteaMirror commented

@gittyup883 commented on GitHub (Sep 15, 2024):

Same issue. Kept getting "Failed syncing account" error messaged, so I reset SimpleFin token and tried unlinking and relinking accounts. But not can't relink as page is blank.

@gittyup883 commented on GitHub (Sep 15, 2024): Same issue. Kept getting "Failed syncing account" error messaged, so I reset SimpleFin token and tried unlinking and relinking accounts. But not can't relink as page is blank.

GiteaMirror commented

@latetedemelon commented on GitHub (Sep 15, 2024):

Can you try callling the API manually? I suspect you’re running into rate limiting. (529 error).

From: gittyup883 @.>
Sent: Saturday, September 14, 2024 8:02:24 PM
To: actualbudget/actual @.>
Cc: Rob @.>; Comment @.>
Subject: Re: [actualbudget/actual] [Bug]: Re-Linking Bank Account (simpleFIN) to Actual Account not fetching transactions and producing error + report to Github dialogue (Issue #3228)

Same issue. Kept getting "Failed syncing account" error messaged, so I reset SimpleFin token and tried unlinking and relinking accounts. But not can't relink as page is blank.

—
Reply to this email directly, view it on GitHubhttps://github.com/actualbudget/actual/issues/3228#issuecomment-2351326115, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACDYM2NLPJIXWT6FY3ROIS3ZWT2EBAVCNFSM6AAAAABMJSSHBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRGMZDMMJRGU.
You are receiving this because you commented.Message ID: @.***>

@latetedemelon commented on GitHub (Sep 15, 2024): Can you try callling the API manually? I suspect you’re running into rate limiting. (529 error). ________________________________ From: gittyup883 ***@***.***> Sent: Saturday, September 14, 2024 8:02:24 PM To: actualbudget/actual ***@***.***> Cc: Rob ***@***.***>; Comment ***@***.***> Subject: Re: [actualbudget/actual] [Bug]: Re-Linking Bank Account (simpleFIN) to Actual Account not fetching transactions and producing error + report to Github dialogue (Issue #3228) Same issue. Kept getting "Failed syncing account" error messaged, so I reset SimpleFin token and tried unlinking and relinking accounts. But not can't relink as page is blank. — Reply to this email directly, view it on GitHub<https://github.com/actualbudget/actual/issues/3228#issuecomment-2351326115>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACDYM2NLPJIXWT6FY3ROIS3ZWT2EBAVCNFSM6AAAAABMJSSHBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRGMZDMMJRGU>. You are receiving this because you commented.Message ID: ***@***.***>

GiteaMirror commented

@Houndie commented on GitHub (Sep 19, 2024):

I've also run into this error, and for me it does look like I've been rate limited.

╰─➤ curl $ACCESS_URL/accounts
{"errors":["Too many requests. SimpleFIN data is only refreshed once every 24 hours. Expected usage of this API is 24 requests per day."],"accounts":[]}%

Suggest at minimum making sure this error gets logged if it isn't already. The solution does seem pretty simple, wait until no longer rate limited. I'll wait a day or two and try again and report back.

@Houndie commented on GitHub (Sep 19, 2024): I've also run into this error, and for me it does look like I've been rate limited. ``` ╰─➤ curl $ACCESS_URL/accounts {"errors":["Too many requests. SimpleFIN data is only refreshed once every 24 hours. Expected usage of this API is 24 requests per day."],"accounts":[]}% ``` Suggest at minimum making sure this error gets logged if it isn't already. The solution does seem pretty simple, wait until no longer rate limited. I'll wait a day or two and try again and report back.

GiteaMirror commented

@Houndie commented on GitHub (Sep 21, 2024):

Great: I've waited a little over 24 hours, and while I still receive an error popup when syncing accounts, it does appear to still work, so rate limiting does seem to be the error reported by the poster.

That said: When I sync all accounts, the app appears to sync one account at a time. When reading the simplefin api, it appears that the accounts endpoint gives you financial data on all of your accounts. If Actual isn't already batching the syncs together when the user requests to sync multiple actual accounts simultaneously (such as when syncing "all accounts", which I would guess is a pretty common operation), it would probably be useful to do that to avoid this rate limit. If SimpleFIN Bridge doesn't want more than 24 requests in a 24 hour period, that's going to hurt users with more than 24 accounts to sync.

(That said, it's possible you do this already! This guess is based on how the app behaves, but I haven't read the code :-) )

@Houndie commented on GitHub (Sep 21, 2024): Great: I've waited a little over 24 hours, and while I still receive an error popup when syncing accounts, it does appear to still work, so rate limiting does seem to be the error reported by the poster. That said: When I sync all accounts, the app appears to sync one account at a time. When reading the simplefin api, it appears that the `accounts` endpoint gives you [financial data on all of your accounts](https://www.simplefin.org/protocol.html#get-accounts). If Actual isn't already batching the syncs together when the user requests to sync multiple actual accounts simultaneously (such as when syncing "all accounts", which I would guess is a pretty common operation), it would probably be useful to do that to avoid this rate limit. If SimpleFIN Bridge doesn't want more than 24 requests in a 24 hour period, that's going to hurt users with more than 24 accounts to sync. (That said, it's possible you do this already! This guess is based on how the app behaves, but I haven't read the code :-) )

GiteaMirror commented

@Houndie commented on GitHub (Sep 21, 2024):

If I'm reading the code correctly, it does seem like we iterate over each account here and perform a sync on each one, which results in a large number of requests to the SimpleFIN bridge.

(It looks like gocardless is account specific so the same kind of optimization may not be helpful on that side)

@Houndie commented on GitHub (Sep 21, 2024): If I'm reading the code correctly, it does seem like we iterate over each account [here](https://github.com/actualbudget/actual/blob/a1bc66b10ab0cb2e84b972a8ee49de23a2f196d1/packages/loot-core/src/server/main.ts#L1071) and perform a sync on each one, which results in a large number of requests to the SimpleFIN bridge. (It looks like gocardless is account specific so the same kind of optimization may not be helpful on that side)

GiteaMirror commented

@matt-fidd commented on GitHub (Sep 25, 2024):

The groundwork for batching more efficiently was laid in https://github.com/actualbudget/actual-server/pull/384, there's some dev work needing to be put in on the front end to make it functional though

@matt-fidd commented on GitHub (Sep 25, 2024): The groundwork for batching more efficiently was laid in https://github.com/actualbudget/actual-server/pull/384, there's some dev work needing to be put in on the front end to make it functional though

GiteaMirror commented

@Masong19hippows commented on GitHub (Sep 30, 2024):

I just came across this issue as well. Weirdly enough, it wasn't happening with 24.8.0. I upgraded to 24.9.0 to see if it would fix an unrelated issue, and now I can't edit the simplefin accounts - the screen when adding is just blank. I also can't downgrade because I get an error when accessing the file with a downgraded version that I need to update the client. Its actually pretty frustrating because I don't have most of my accounts setup properly yet, and so actualbudget is unusable for me at the moment.

What I don't understand is, how come I wasn't getting rate limited before the update? It doesn't seem like the api calls changed from one version to the next, so why is rate limiting suddenly a problem? Were the SimpleFin accounts cached or something, and so the client didn't know if it was getting rate limited or not, and this was changed?

Also, did anyone find a workaround?

@Masong19hippows commented on GitHub (Sep 30, 2024): I just came across this issue as well. Weirdly enough, it wasn't happening with 24.8.0. I upgraded to 24.9.0 to see if it would fix an unrelated issue, and now I can't edit the simplefin accounts - the screen when adding is just blank. I also can't downgrade because I get an error when accessing the file with a downgraded version that I need to update the client. Its actually pretty frustrating because I don't have most of my accounts setup properly yet, and so actualbudget is unusable for me at the moment. What I don't understand is, how come I wasn't getting rate limited before the update? It doesn't seem like the api calls changed from one version to the next, so why is rate limiting suddenly a problem? Were the SimpleFin accounts cached or something, and so the client didn't know if it was getting rate limited or not, and this was changed? Also, did anyone find a workaround?

GiteaMirror commented

@Houndie commented on GitHub (Sep 30, 2024):

Workaround afaik is to make sure you're not making more than 24 requests in a day 🤷 .

The batching feature mentioned above should help significantly with staying below that limit.

@Houndie commented on GitHub (Sep 30, 2024): Workaround afaik is to make sure you're not making more than 24 requests in a day 🤷 . The batching feature mentioned above should help significantly with staying below that limit.

GiteaMirror commented

@Masong19hippows commented on GitHub (Oct 1, 2024):

@Houndie

I emailed simplefin support and they said this

The suggested use is 24 requests/day, you will get warned at 48 requests/day and then blocked at 96 requests/day.

This is pretty high honestly. At least with my setup, it would take 10 bulk syncs of my account when I hit this limit.

I did a bulk sync of my accounts and some of the items gave an "account missing" error. I think this is just the user facing error when the limit is reached

I think I figured it out though. Whenever you link an account with simplefin, it does a bulk update of all of the accounts once you exit the page with the list of accounts. When I was using it, I linked one of my accounts and then exited, then I went back in and linked another - trying to make sure everything was correct. Every time I left the simplefin account list page though, it bulk updated all of my linked accounts. I thinks this just added up and I hit the limit.

@Masong19hippows commented on GitHub (Oct 1, 2024): @Houndie I emailed simplefin support and they said this >The suggested use is 24 requests/day, you will get warned at 48 requests/day and then blocked at 96 requests/day. This is pretty high honestly. At least with my setup, it would take 10 bulk syncs of my account when I hit this limit. I did a bulk sync of my accounts and some of the items gave an "account missing" error. I think this is just the user facing error when the limit is reached ![image](https://github.com/user-attachments/assets/3603b33e-1759-41d2-8b2c-a81319fd9d4c) I think I figured it out though. Whenever you link an account with simplefin, it does a bulk update of all of the accounts once you exit the page with the list of accounts. When I was using it, I linked one of my accounts and then exited, then I went back in and linked another - trying to make sure everything was correct. Every time I left the simplefin account list page though, it bulk updated all of my linked accounts. I thinks this just added up and I hit the limit.

GiteaMirror commented