github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-11 10:02:07 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8068] [MERGED] When resetting SimpleFIN credentials, parse error and error_code if response body exists #131694

New Issue
Closed
opened 2026-06-16 00:25:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-16 00:25:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8068
Author: @KevinIsMyName
Created: 6/3/2026
Status: ✅ Merged
Merged: 6/3/2026
Merged by: @matt-fidd

Base: master ← Head: master

📝 Commits (7)

  • 4a2b4dd Initial commit
  • 20c6b34 Add release note
  • a5da12c Update release note file name to match PR number
  • 82cf49e Flip operands when checking for 2xx
  • 18108cd Release notes grammar
  • 93ce404 Better release note for non-devs
  • fe4d4b2 Simplify to naive solution of checking on nullable response

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 packages/desktop-client/src/components/banksync/useBuiltInBankSyncProviders.ts (+2 -2)
➕ upcoming-release-notes/8068.md (+6 -0)

📄 Description

Description

When resetting bank credentials, a JS error attempting to read .error and .error_code appears because the API response returns a successful response but with no 'data' attr, causing subsequent operations like clearing simplefin_accessKey to not be reached.

What does this PR do?

Read response?.error and response?.error_code instead of response.error and response.error_code

Why is it needed? What problem is it solving?

BUG: when successfully resetting simplefin_token, response causes frontend to read response.error and response.error_code, which prevents the following reset of simplefin_accessKey.
Detailed trace of bug here (not a stack trace)

Related issue(s)

Fixes #8023

Testing

What did you test?

Regression-tested for toast error message
Regression-tested GoCardless integration set up
Regression-tested Pluggy.ai integration set up
Tested SimpleFIN integration with null existing credentials -> add credentials via "Edit setup" > reset credentials
Tested SimpleFIN integration with good existing credentials (might need to insert token and accessKey into SQLite3 db) -> reset credentials
Tested SimpleFIN integration with bad non-null accessKey (insert into SQLite3 db) -> reset credentials

Reproduce the bug:

  1. Navigate to More > Bank Sync > SimpleFIN > Set-up SimpleFIN
  2. Enter a valid (but already redeemed!) token. "Save and Continue"
  3. Click "Link bank account". Prepare your Dev Tools > Network tab to observe HTTP requests for step 6
  4. Click "Reset SimpleFIN credentials"
  5. Observe toast error message "Cannot read properties of undefined (reading' error_code')
  6. Observe that only one HTTP request was sent to clear simplefin_token=null, and missing another HTTP request for simplefin_accessKey
  7. Observe that simplefin_token was cleared but simplefin_accessKey was not by connecting SQLite3 db at ../server-files/account.sqlite and running the query select * from secrets; You might need to populate simplefin_accessKey beforehand
  8. Click "Link bank account" and repeat from step 2 until you realize you are stuck in a loop and cannot reset SimpleFIN credentials

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.04 MB → 14.04 MB (+2 B) +0.00%
loot-core 1 5.28 MB 0%
api 2 3.86 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.04 MB → 14.04 MB (+2 B) +0.00%
Changeset
File Δ Size
src/components/banksync/useBuiltInBankSyncProviders.ts 📈 +2 B (+0.02%) 11.26 kB → 11.26 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/SchedulesTable.js 202.7 kB → 202.7 kB (+2 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.55 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.64 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ReportRouter.js 1.26 MB 0%
static/js/ScheduleEditForm.js 146.44 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 5.09 MB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 186.63 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.02 kB 0%
static/js/de.js 170.87 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 199.23 kB 0%
static/js/es.js 178.57 kB 0%
static/js/extends.js 501.42 kB 0%
static/js/fr.js 178.44 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 164.87 kB 0%
static/js/narrow.js 364.5 kB 0%
static/js/nb-NO.js 147.94 kB 0%
static/js/nl.js 107 kB 0%
static/js/pt-BR.js 188.32 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.31 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 207.3 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 299.14 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.01 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.28 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.DC4epP6P.js 5.28 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.86 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.86 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8068 **Author:** [@KevinIsMyName](https://github.com/KevinIsMyName) **Created:** 6/3/2026 **Status:** ✅ Merged **Merged:** 6/3/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`4a2b4dd`](https://github.com/actualbudget/actual/commit/4a2b4dd9f76448825abcd3952f20b9884dd40435) Initial commit - [`20c6b34`](https://github.com/actualbudget/actual/commit/20c6b340796580e4b5ded288e847e50d418d1ab4) Add release note - [`a5da12c`](https://github.com/actualbudget/actual/commit/a5da12c6d4718983f5f994a5a289ed4b2a2fe724) Update release note file name to match PR number - [`82cf49e`](https://github.com/actualbudget/actual/commit/82cf49e6d6a20de4a28bc7e0085312e763a19f2a) Flip operands when checking for 2xx - [`18108cd`](https://github.com/actualbudget/actual/commit/18108cd09ad34b756c0c722e3417daf0c2a643a5) Release notes grammar - [`93ce404`](https://github.com/actualbudget/actual/commit/93ce4041201f1e3c73b26e14d2ed10f4b720944b) Better release note for non-devs - [`fe4d4b2`](https://github.com/actualbudget/actual/commit/fe4d4b2b6668fdeaa238a1fd010efc306c716840) Simplify to naive solution of checking on nullable response ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/banksync/useBuiltInBankSyncProviders.ts` (+2 -2) ➕ `upcoming-release-notes/8068.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://actualbudget.org/docs/contributing/#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description When resetting bank credentials, a JS error attempting to read `.error` and `.error_code` appears because the API response returns a successful response but with no 'data' attr, causing subsequent operations like clearing simplefin_accessKey to not be reached. ### What does this PR do? Read `response?.error` and `response?.error_code` instead of `response.error` and `response.error_code` ### Why is it needed? What problem is it solving? BUG: when successfully resetting simplefin_token, response causes frontend to read `response.error` and `response.error_code`, which prevents the following reset of simplefin_accessKey. [Detailed trace of bug here (not a stack trace)](https://github.com/actualbudget/actual/issues/8023#issuecomment-4597443444) <!-- What does this PR do? Why is it needed? Please give context on the "why?": why do we need this change? What problem is it solving for you?--> ## Related issue(s) Fixes #8023 <!-- e.g. Fixes #123, Relates to #456 --> ## Testing <!-- What did you test? How can we reproduce the issue you are fixing or how can we test the feature you built? --> ### What did you test? Regression-tested for toast error message Regression-tested GoCardless integration set up Regression-tested Pluggy.ai integration set up Tested SimpleFIN integration with null existing credentials -> add credentials via "Edit setup" > reset credentials Tested SimpleFIN integration with good existing credentials (might need to insert token and accessKey into SQLite3 db) -> reset credentials Tested SimpleFIN integration with bad non-null accessKey (insert into SQLite3 db) -> reset credentials ### Reproduce the bug: 1. Navigate to More > Bank Sync > SimpleFIN > Set-up SimpleFIN 2. Enter a valid (but already redeemed!) token. "Save and Continue" 3. Click "Link bank account". _Prepare your Dev Tools > Network tab to observe HTTP requests for step 6_ 4. Click "Reset SimpleFIN credentials" 5. Observe toast error message "Cannot read properties of undefined (reading' error_code') 6. Observe that only one HTTP request was sent to clear simplefin_token=null, and missing another HTTP request for simplefin_accessKey 7. Observe that simplefin_token was cleared but simplefin_accessKey was not by connecting SQLite3 db at `../server-files/account.sqlite` and running the query `select * from secrets;` _You might need to populate simplefin\_accessKey beforehand_ 8. Click "Link bank account" and repeat from step 2 until you realize you are stuck in a loop and cannot reset SimpleFIN credentials ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.04 MB → 14.04 MB (+2 B) | +0.00% loot-core | 1 | 5.28 MB | 0% api | 2 | 3.86 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.04 MB → 14.04 MB (+2 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/banksync/useBuiltInBankSyncProviders.ts` | 📈 +2 B (+0.02%) | 11.26 kB → 11.26 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/SchedulesTable.js | 202.7 kB → 202.7 kB (+2 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.55 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.64 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.26 MB | 0% static/js/ScheduleEditForm.js | 146.44 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 5.09 MB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 186.63 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.02 kB | 0% static/js/de.js | 170.87 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 199.23 kB | 0% static/js/es.js | 178.57 kB | 0% static/js/extends.js | 501.42 kB | 0% static/js/fr.js | 178.44 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 164.87 kB | 0% static/js/narrow.js | 364.5 kB | 0% static/js/nb-NO.js | 147.94 kB | 0% static/js/nl.js | 107 kB | 0% static/js/pt-BR.js | 188.32 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.31 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 207.3 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 299.14 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.01 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.28 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DC4epP6P.js | 5.28 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.86 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.86 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-16 00:25:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#131694
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?