github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-10 23:54:00 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7829] bcrypt -> argon2id #131527

New Issue
Open
opened 2026-06-16 00:11:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-16 00:11:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7829
Author: @matt-fidd
Created: 5/13/2026
Status: 🔄 Open

Base: master ← Head: argon2

📝 Commits (2)

📊 Changes

13 files changed (+119 additions, -41 deletions)

View changed files

📝 package.json (+4 -1)
📝 packages/desktop-electron/beforePackHook.ts (+2 -2)
📝 packages/sync-server/package.json (+1 -0)
📝 packages/sync-server/src/account-db.js (+9 -7)
📝 packages/sync-server/src/accounts/openid.ts (+1 -1)
📝 packages/sync-server/src/accounts/password.js (+50 -16)
📝 packages/sync-server/src/app-account.js (+4 -4)
📝 packages/sync-server/src/app-account.test.js (+6 -6)
📝 packages/sync-server/src/app-openid.test.ts (+1 -1)
📝 packages/sync-server/src/app-openid.ts (+1 -1)
📝 packages/sync-server/src/scripts/reset-password.js (+1 -1)
➕ upcoming-release-notes/7829.md (+6 -0)
📝 yarn.lock (+33 -1)

📄 Description

DO NOT CONNECT TO A SERVER YOU CARE ABOUT

Description

Follows OWASP recommendations, bcrypt appears to have fallen out of favour and looks to be considered more for legacy systems.
https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#introduction

The bcrypt password hashing function should only be used for password storage in legacy systems where Argon2 and scrypt are not available.The bcrypt password hashing function should only be used for password storage in legacy systems where Argon2 and scrypt are not available.

  • All new passwords will be hashed with the new algorithm, anyone that logs in with a password hashed with bcrypt will be migrated to the new one silently.
  • Ideally we'll be able to drop old algorithm support altogether in a few months, when we do we'd need to call it out in the release notes and anyone that hasn't logged in with a password since this is merged would need to reset their password manually.

Related issue(s)

Testing

Before:

Mac:actual:master% sqlite3 packages/sync-server/server-files/account.sqlite \
"SELECT method, substr(extra_data, 1, 7) AS prefix FROM auth WHERE method =
  'password';"
password|$2b$12$

After:

Mac:actual:argon2% sqlite3 packages/sync-server/server-files/account.sqlite \
"SELECT method, substr(extra_data, 1, 7) AS prefix FROM auth WHERE method =
  'password';"
password|$argon2

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 33 13.91 MB 0%
loot-core 1 5.31 MB 0%
api 2 3.94 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
33 13.91 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.97 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ReportRouter.js 1.22 MB 0%
static/js/ScheduleEditForm.js 146.45 kB 0%
static/js/TransactionEdit.js 190.43 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 4.96 MB 0%
static/js/bankSyncUtils.js 54.15 kB 0%
static/js/ca.js 187.72 kB 0%
static/js/chart-theme.js 800.08 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.28 kB 0%
static/js/de.js 170.38 kB 0%
static/js/en-GB.js 10.01 kB 0%
static/js/en.js 189.97 kB 0%
static/js/es.js 178.83 kB 0%
static/js/extends.js 519.29 kB 0%
static/js/fr.js 178.71 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.13 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.19 kB 0%
static/js/nl.js 106.34 kB 0%
static/js/pt-BR.js 189.39 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.62 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 207.56 kB 0%
static/js/useFormatList.js 4.96 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.75 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.31 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.Cozwd3bP.js 5.31 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.94 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.94 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7829 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 5/13/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `argon2` --- ### 📝 Commits (2) - [`203e943`](https://github.com/actualbudget/actual/commit/203e943e5ee58c84198aac7efa2c467d7b2208c2) bcrypt -> argon2id - [`bf7f596`](https://github.com/actualbudget/actual/commit/bf7f59631f44fb60948ed1f3e99ba8c807a18d21) coderabbit feedback ### 📊 Changes **13 files changed** (+119 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+4 -1) 📝 `packages/desktop-electron/beforePackHook.ts` (+2 -2) 📝 `packages/sync-server/package.json` (+1 -0) 📝 `packages/sync-server/src/account-db.js` (+9 -7) 📝 `packages/sync-server/src/accounts/openid.ts` (+1 -1) 📝 `packages/sync-server/src/accounts/password.js` (+50 -16) 📝 `packages/sync-server/src/app-account.js` (+4 -4) 📝 `packages/sync-server/src/app-account.test.js` (+6 -6) 📝 `packages/sync-server/src/app-openid.test.ts` (+1 -1) 📝 `packages/sync-server/src/app-openid.ts` (+1 -1) 📝 `packages/sync-server/src/scripts/reset-password.js` (+1 -1) ➕ `upcoming-release-notes/7829.md` (+6 -0) 📝 `yarn.lock` (+33 -1) </details> ### 📄 Description # DO NOT CONNECT TO A SERVER YOU CARE ABOUT <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://actualbudget.org/docs/contributing/#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description <!-- What does this PR do? Why is it needed? Please give context on the "why?": why do we need this change? What problem is it solving for you?--> Follows OWASP recommendations, bcrypt appears to have fallen out of favour and looks to be considered more for legacy systems. https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#introduction > The [bcrypt](https://en.wikipedia.org/wiki/bcrypt) password hashing function should only be used for password storage in legacy systems where Argon2 and scrypt are not available.The [bcrypt](https://en.wikipedia.org/wiki/bcrypt) password hashing function should only be used for password storage in legacy systems where Argon2 and scrypt are not available. - All new passwords will be hashed with the new algorithm, anyone that logs in with a password hashed with bcrypt will be migrated to the new one silently. - Ideally we'll be able to drop old algorithm support altogether in a few months, when we do we'd need to call it out in the release notes and anyone that hasn't logged in with a password since this is merged would need to reset their password manually. ## Related issue(s) <!-- e.g. Fixes #123, Relates to #456 --> ## Testing <!-- What did you test? How can we reproduce the issue you are fixing or how can we test the feature you built? --> Before: ``` Mac:actual:master% sqlite3 packages/sync-server/server-files/account.sqlite \ "SELECT method, substr(extra_data, 1, 7) AS prefix FROM auth WHERE method = 'password';" password|$2b$12$ ``` After: ``` Mac:actual:argon2% sqlite3 packages/sync-server/server-files/account.sqlite \ "SELECT method, substr(extra_data, 1, 7) AS prefix FROM auth WHERE method = 'password';" password|$argon2 ``` ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 33 | 13.91 MB | 0% loot-core | 1 | 5.31 MB | 0% api | 2 | 3.94 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 33 | 13.91 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.97 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ReportRouter.js | 1.22 MB | 0% static/js/ScheduleEditForm.js | 146.45 kB | 0% static/js/TransactionEdit.js | 190.43 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 4.96 MB | 0% static/js/bankSyncUtils.js | 54.15 kB | 0% static/js/ca.js | 187.72 kB | 0% static/js/chart-theme.js | 800.08 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.28 kB | 0% static/js/de.js | 170.38 kB | 0% static/js/en-GB.js | 10.01 kB | 0% static/js/en.js | 189.97 kB | 0% static/js/es.js | 178.83 kB | 0% static/js/extends.js | 519.29 kB | 0% static/js/fr.js | 178.71 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.13 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.19 kB | 0% static/js/nl.js | 106.34 kB | 0% static/js/pt-BR.js | 189.39 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.62 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 207.56 kB | 0% static/js/useFormatList.js | 4.96 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.75 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.31 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.Cozwd3bP.js | 5.31 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.94 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.94 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-16 00:11:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#131527
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?