github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #5744] Dynamic currency display options #13145

New Issue
Closed
opened 2026-04-10 21:48:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 21:48:26 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/5744

State: closed
Merged: Yes

This pull request enhances the currency settings UI by dynamically updating the currency symbol and spacing in the symbol position options, making the configuration more intuitive for users.

Currency settings UI improvements:

  • The symbol position options in CurrencySettings now update dynamically based on the selected currency and spacing preference, showing accurate examples for each configuration. (packages/desktop-client/src/components/settings/Currency.tsx, packages/desktop-client/src/components/settings/Currency.tsx L88-R103)
  • The getCurrency function from loot-core/shared/currencies is imported to retrieve the selected currency's symbol for these dynamic updates. (packages/desktop-client/src/components/settings/Currency.tsx, packages/desktop-client/src/components/settings/Currency.tsx L10-R10)
  • The translated text in the label is separated out to no longer include the amounts, so that 'Before amount', 'After amount', and 'e.g.' are separate tokens.

Screenshots
Screenshot from 2025-09-19 10-42-02
Screenshot from 2025-09-19 10-42-28
Screenshot from 2025-09-19 10-42-56

**Original Pull Request:** https://github.com/actualbudget/actual/pull/5744 **State:** closed **Merged:** Yes --- This pull request enhances the currency settings UI by dynamically updating the currency symbol and spacing in the symbol position options, making the configuration more intuitive for users. **Currency settings UI improvements:** * The symbol position options in `CurrencySettings` now update dynamically based on the selected currency and spacing preference, showing accurate examples for each configuration. (`packages/desktop-client/src/components/settings/Currency.tsx`, [packages/desktop-client/src/components/settings/Currency.tsx L88-R103](diffhunk://#diff-9b0bd6bc744bfd4afac03d8e6db423fa69216ff2dac2272f2a5dba73494e14ccL88-R103)) * The `getCurrency` function from `loot-core/shared/currencies` is imported to retrieve the selected currency's symbol for these dynamic updates. (`packages/desktop-client/src/components/settings/Currency.tsx`, [packages/desktop-client/src/components/settings/Currency.tsx L10-R10](diffhunk://#diff-9b0bd6bc744bfd4afac03d8e6db423fa69216ff2dac2272f2a5dba73494e14ccL10-R10)) * The translated text in the label is separated out to no longer include the amounts, so that `'Before amount'`, `'After amount'`, and `'e.g.'` are separate tokens. **Screenshots** <img width="547" height="168" alt="Screenshot from 2025-09-19 10-42-02" src="https://github.com/user-attachments/assets/a8029918-4d81-4b97-a424-f267e5c4f5bb" /> <img width="548" height="189" alt="Screenshot from 2025-09-19 10-42-28" src="https://github.com/user-attachments/assets/334cbdfa-281d-416d-8636-058be979ba02" /> <img width="549" height="167" alt="Screenshot from 2025-09-19 10-42-56" src="https://github.com/user-attachments/assets/c70edb3e-3c4b-4db8-a09a-ceeb48cd44c0" />
GiteaMirror added the pull-request label 2026-04-10 21:48:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#13145
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?