[PR #7646] [CLOSED] [WIP] chore: remove i18next usage from loot-core #131417

Closed
opened 2026-06-15 23:57:23 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7646
Author: @SupaSeeka
Created: 4/28/2026
Status: Closed

Base: masterHead: maintenence/remove-i18next-from-loot-core


📝 Commits (7)

  • d44bf27 chore: remove i18next usage from loot-core
  • cedd38a Added release notes
  • ce16451 [autofix.ci] apply automated fixes
  • dd392b6 Reduce usage of i18next in loot-core
  • 07ea069 chore: remove i18next from shared/errors.ts and return translatable results
  • 611f831 More translations added
  • d24ced8 [autofix.ci] apply automated fixes

📊 Changes

22 files changed (+202 additions, -178 deletions)

View changed files

📝 packages/desktop-client/src/app/appSlice.ts (+7 -1)
📝 packages/desktop-client/src/budgetfiles/budgetfilesSlice.ts (+9 -2)
📝 packages/desktop-client/src/components/admin/UserAccess/UserAccessRow.tsx (+4 -2)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx (+2 -2)
📝 packages/desktop-client/src/components/modals/CreateEncryptionKeyModal.tsx (+3 -1)
📝 packages/desktop-client/src/components/modals/EditAccess.tsx (+3 -2)
📝 packages/desktop-client/src/components/modals/FixEncryptionKeyModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/GoCardlessInitialiseModal.tsx (+2 -2)
📝 packages/desktop-client/src/components/modals/OpenIDEnableModal.tsx (+6 -1)
📝 packages/desktop-client/src/components/modals/PluggyAiInitialiseModal.tsx (+3 -3)
📝 packages/desktop-client/src/components/modals/SimpleFinInitialiseModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/TransferOwnership.tsx (+6 -1)
📝 packages/desktop-client/src/components/schedules/StatusBadge.tsx (+2 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+1 -1)
📝 packages/desktop-client/src/global-events.ts (+10 -0)
📝 packages/loot-core/src/platform/client/connection/index.ts (+7 -7)
📝 packages/loot-core/src/server/accounts/app.ts (+2 -4)
📝 packages/loot-core/src/shared/errors.ts (+56 -76)
📝 packages/loot-core/src/shared/rules.ts (+52 -53)
📝 packages/loot-core/src/shared/schedules.ts (+17 -17)

...and 2 more files

📄 Description

Description

This PR reduces the usage of t() from i18next in the loot-core section.

There is a level of regressiona this stage until I recieve clarification on how translation should be handled with variables.

Fixes issue #7633

Testing

Still WIP on this reguard, need to wait for maintainer feedback/answers to some questions.

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 35 14 MB → 14 MB (-346 B) -0.00%
loot-core 1 5.26 MB → 5.26 MB (-111 B) -0.00%
api 2 3.89 MB → 3.89 MB (-111 B) -0.00%
cli 1 7.97 MB 0%
crdt 1 41.83 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
35 14 MB → 14 MB (-346 B) -0.00%
Changeset
File Δ Size
locale/es.json 📈 +54 B (+0.03%) 182.25 kB → 182.3 kB
home/runner/work/actual/actual/packages/loot-core/src/platform/client/connection/index.ts 📉 -5 B (-0.15%) 3.35 kB → 3.34 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/errors.ts 📉 -135 B (-2.66%) 4.96 kB → 4.83 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/rules.ts 📉 -260 B (-3.54%) 7.17 kB → 6.91 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/es.js 182.25 kB → 182.3 kB (+54 B) +0.03%

Smaller

Asset File Size % Changed
static/js/Value.js 4.94 MB → 4.94 MB (-260 B) -0.01%
static/js/extends.js 518.76 kB → 518.62 kB (-140 B) -0.03%

Unchanged

Asset File Size % Changed
static/js/index.js 1.87 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/PayeeRuleCountLabel.js 52.52 kB 0%
static/js/ReportRouter.js 1.22 MB 0%
static/js/ScheduleEditForm.js 145.68 kB 0%
static/js/TransactionEdit.js 186.58 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/ca.js 191.46 kB 0%
static/js/chart-theme.js 796.5 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 104.22 kB 0%
static/js/de.js 173.88 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 176.89 kB 0%
static/js/fr.js 182.5 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 168.33 kB 0%
static/js/narrow.js 364.31 kB 0%
static/js/nb-NO.js 151.39 kB 0%
static/js/nl.js 108.46 kB 0%
static/js/pl.js 88.14 kB 0%
static/js/pt-BR.js 193.24 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/ru.js 121.6 kB 0%
static/js/th.js 178.63 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 212.03 kB 0%
static/js/useFormatList.js 8.63 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 119.88 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.26 MB → 5.26 MB (-111 B) -0.00%
Changeset
File Δ Size
node_modules/chevrotain/lib_esm/src/scan/tokens_public.js 📈 +2 B (+0.09%) 2.25 kB → 2.25 kB
node_modules/chevrotain/lib_esm/src/scan/lexer.js 📈 +18 B (+0.07%) 24.83 kB → 24.84 kB
node_modules/chevrotain/lib_esm/src/utils/utils.js 📈 +2 B (+0.02%) 8.71 kB → 8.71 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts 📉 -6 B (-0.03%) 22.02 kB → 22.01 kB
node_modules/i18next/dist/esm/i18next.js 📉 -94 B (-0.12%) 74.94 kB → 74.85 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/errors.ts 📉 -33 B (-1.26%) 2.55 kB → 2.52 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.CYe02DYH.js 0 B → 5.26 MB (+5.26 MB) -

Removed

Asset File Size % Changed
kcab.worker.B5tkfYkU.js 5.26 MB → 0 B (-5.26 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged


api

Total

Files count Total bundle size % Changed
2 3.89 MB → 3.89 MB (-111 B) -0.00%
Changeset
File Δ Size
node_modules/chevrotain/lib_esm/src/scan/tokens_public.js 📈 +2 B (+0.09%) 2.18 kB → 2.19 kB
node_modules/chevrotain/lib_esm/src/scan/lexer.js 📈 +18 B (+0.07%) 24.22 kB → 24.24 kB
node_modules/chevrotain/lib_esm/src/utils/utils.js 📈 +2 B (+0.02%) 8.4 kB → 8.41 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts 📉 -6 B (-0.03%) 21.46 kB → 21.45 kB
node_modules/i18next/dist/esm/i18next.js 📉 -94 B (-0.13%) 73.02 kB → 72.92 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/errors.ts 📉 -33 B (-1.28%) 2.52 kB → 2.49 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller

Asset File Size % Changed
index.js 3.89 MB → 3.89 MB (-111 B) -0.00%

Unchanged

Asset File Size % Changed
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 41.83 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 41.83 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7646 **Author:** [@SupaSeeka](https://github.com/SupaSeeka) **Created:** 4/28/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `maintenence/remove-i18next-from-loot-core` --- ### 📝 Commits (7) - [`d44bf27`](https://github.com/actualbudget/actual/commit/d44bf272fef41cda51cd01d03c092c52b36ef19a) chore: remove i18next usage from loot-core - [`cedd38a`](https://github.com/actualbudget/actual/commit/cedd38a40a2aa2c43b210d6087cca384109417f3) Added release notes - [`ce16451`](https://github.com/actualbudget/actual/commit/ce16451ac689d8a710ff1a809c26d65d1976be0a) [autofix.ci] apply automated fixes - [`dd392b6`](https://github.com/actualbudget/actual/commit/dd392b66dbe562ffd407eae7981f99adebf1c515) Reduce usage of i18next in loot-core - [`07ea069`](https://github.com/actualbudget/actual/commit/07ea06990e8b62cb587968eea8b5e849c7e88758) chore: remove i18next from shared/errors.ts and return translatable results - [`611f831`](https://github.com/actualbudget/actual/commit/611f83155ba54ec856c850d216b7afcfae2d7e6c) More translations added - [`d24ced8`](https://github.com/actualbudget/actual/commit/d24ced8189454baa634d66d2eb01b02a08e27399) [autofix.ci] apply automated fixes ### 📊 Changes **22 files changed** (+202 additions, -178 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/app/appSlice.ts` (+7 -1) 📝 `packages/desktop-client/src/budgetfiles/budgetfilesSlice.ts` (+9 -2) 📝 `packages/desktop-client/src/components/admin/UserAccess/UserAccessRow.tsx` (+4 -2) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/modals/CreateEncryptionKeyModal.tsx` (+3 -1) 📝 `packages/desktop-client/src/components/modals/EditAccess.tsx` (+3 -2) 📝 `packages/desktop-client/src/components/modals/FixEncryptionKeyModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/GoCardlessInitialiseModal.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/modals/OpenIDEnableModal.tsx` (+6 -1) 📝 `packages/desktop-client/src/components/modals/PluggyAiInitialiseModal.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/modals/SimpleFinInitialiseModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/TransferOwnership.tsx` (+6 -1) 📝 `packages/desktop-client/src/components/schedules/StatusBadge.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+1 -1) 📝 `packages/desktop-client/src/global-events.ts` (+10 -0) 📝 `packages/loot-core/src/platform/client/connection/index.ts` (+7 -7) 📝 `packages/loot-core/src/server/accounts/app.ts` (+2 -4) 📝 `packages/loot-core/src/shared/errors.ts` (+56 -76) 📝 `packages/loot-core/src/shared/rules.ts` (+52 -53) 📝 `packages/loot-core/src/shared/schedules.ts` (+17 -17) _...and 2 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description <!-- What does this PR do? Why is it needed? Please give context on the "why?": why do we need this change? What problem is it solving for you?--> This PR reduces the usage of `t()` from `i18next` in the `loot-core` section. There is a level of regressiona this stage until I recieve clarification on how translation should be handled with variables. ## Related issue(s) Fixes issue #7633 ## Testing Still WIP on this reguard, need to wait for maintainer feedback/answers to some questions. ## Checklist - [x] Release notes added (see link above) - [ ] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 35 | 14 MB → 14 MB (-346 B) | -0.00% loot-core | 1 | 5.26 MB → 5.26 MB (-111 B) | -0.00% api | 2 | 3.89 MB → 3.89 MB (-111 B) | -0.00% cli | 1 | 7.97 MB | 0% crdt | 1 | 41.83 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 35 | 14 MB → 14 MB (-346 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `locale/es.json` | 📈 +54 B (+0.03%) | 182.25 kB → 182.3 kB `home/runner/work/actual/actual/packages/loot-core/src/platform/client/connection/index.ts` | 📉 -5 B (-0.15%) | 3.35 kB → 3.34 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/errors.ts` | 📉 -135 B (-2.66%) | 4.96 kB → 4.83 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/rules.ts` | 📉 -260 B (-3.54%) | 7.17 kB → 6.91 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/es.js | 182.25 kB → 182.3 kB (+54 B) | +0.03% **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/Value.js | 4.94 MB → 4.94 MB (-260 B) | -0.01% static/js/extends.js | 518.76 kB → 518.62 kB (-140 B) | -0.03% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.87 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/PayeeRuleCountLabel.js | 52.52 kB | 0% static/js/ReportRouter.js | 1.22 MB | 0% static/js/ScheduleEditForm.js | 145.68 kB | 0% static/js/TransactionEdit.js | 186.58 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/ca.js | 191.46 kB | 0% static/js/chart-theme.js | 796.5 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 104.22 kB | 0% static/js/de.js | 173.88 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 176.89 kB | 0% static/js/fr.js | 182.5 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 168.33 kB | 0% static/js/narrow.js | 364.31 kB | 0% static/js/nb-NO.js | 151.39 kB | 0% static/js/nl.js | 108.46 kB | 0% static/js/pl.js | 88.14 kB | 0% static/js/pt-BR.js | 193.24 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/ru.js | 121.6 kB | 0% static/js/th.js | 178.63 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 212.03 kB | 0% static/js/useFormatList.js | 8.63 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 119.88 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.26 MB → 5.26 MB (-111 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `node_modules/chevrotain/lib_esm/src/scan/tokens_public.js` | 📈 +2 B (+0.09%) | 2.25 kB → 2.25 kB `node_modules/chevrotain/lib_esm/src/scan/lexer.js` | 📈 +18 B (+0.07%) | 24.83 kB → 24.84 kB `node_modules/chevrotain/lib_esm/src/utils/utils.js` | 📈 +2 B (+0.02%) | 8.71 kB → 8.71 kB `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts` | 📉 -6 B (-0.03%) | 22.02 kB → 22.01 kB `node_modules/i18next/dist/esm/i18next.js` | 📉 -94 B (-0.12%) | 74.94 kB → 74.85 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/errors.ts` | 📉 -33 B (-1.26%) | 2.55 kB → 2.52 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.CYe02DYH.js | 0 B → 5.26 MB (+5.26 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.B5tkfYkU.js | 5.26 MB → 0 B (-5.26 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.89 MB → 3.89 MB (-111 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `node_modules/chevrotain/lib_esm/src/scan/tokens_public.js` | 📈 +2 B (+0.09%) | 2.18 kB → 2.19 kB `node_modules/chevrotain/lib_esm/src/scan/lexer.js` | 📈 +18 B (+0.07%) | 24.22 kB → 24.24 kB `node_modules/chevrotain/lib_esm/src/utils/utils.js` | 📈 +2 B (+0.02%) | 8.4 kB → 8.41 kB `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts` | 📉 -6 B (-0.03%) | 21.46 kB → 21.45 kB `node_modules/i18next/dist/esm/i18next.js` | 📉 -94 B (-0.13%) | 73.02 kB → 72.92 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/errors.ts` | 📉 -33 B (-1.28%) | 2.52 kB → 2.49 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.89 MB → 3.89 MB (-111 B) | -0.00% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 41.83 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 41.83 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-15 23:57:23 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#131417