github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #5671] Fixes schedules date picker popup closing when clicking outside underlying popup #13114

New Issue
Closed
opened 2026-04-10 21:47:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 21:47:43 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/5671

State: closed
Merged: No

Fixes #5638

  • The date picker popup used to close when clicking slightly outside the underlying popup, I fixed this by changing the shouldCloseOnInteractOutside default value to false.
  • I also added onMouseDown event handler to open the datepicker when clicked on Input element.

TODO: This solves the issue but now only selecting a date will close the datepicker, need to implement the functionality that clicking outside of the datepicker to close it.

**Original Pull Request:** https://github.com/actualbudget/actual/pull/5671 **State:** closed **Merged:** No --- Fixes #5638 - The date picker popup used to close when clicking slightly outside the underlying popup, I fixed this by changing the shouldCloseOnInteractOutside default value to false. - I also added onMouseDown event handler to open the datepicker when clicked on `Input` element. TODO: This solves the issue but now only selecting a date will close the datepicker, need to implement the functionality that clicking outside of the datepicker to close it.
GiteaMirror added the pull-request label 2026-04-10 21:47:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#13114
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?