github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[Bug]: Wrong payeeNamee since 24.8.0 (logic) #1310

New Issue
Closed
opened 2026-02-28 19:40:00 -06:00 by GiteaMirror · 14 comments
GiteaMirror commented 2026-02-28 19:40:00 -06:00
Owner
Copy Link

Originally created by @Soulplayer on GitHub (Aug 7, 2024).

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

After upgrading from 24.7.0 to 24.8.0 I have problems with the payeeName logic. Actualbudget chooses the wrong one.

Log version 24.7.0:
[{"transactionId":"2024-08-07-10.24.47.258375","bookingDate":"2024-08-07","valueDate":"2024-08-07","transactionAmount":{"amount":"414.04","currency":"EUR"},"creditorName":"name-name S & I","creditorAccount":{"iban":"Accountnumber","currency":"EUR"},"debtorName":"FONS (VUTG) - GROEIPAKKET","debtorAccount":{"iban":"Accountnumber","currency":"EUR"},"remittanceInformationUnstructured":"FONS (VUTG) - GROEIPAKKET Overschrijving TRIERSTRAAT 9 1000 BRUSSEL BE46 3751 1175 9136 BIC: BBRUBEBB /C/ GROEIPAKKET - 1.00.318.245 GEZINSBIJSLAGEN 07/2024","bankTransactionCode":"code","internalTransactionId":"code","date":"2024-08-07"

screenshot from actual 24.7.0
image

Log version 24.8.0:
[{"transactionId":"2024-08-07-10.24.47.258375","bookingDate":"2024-08-07","valueDate":"2024-08-07","transactionAmount":{"amount":"414.04","currency":"EUR"},"creditorName":"name-name S & I","creditorAccount":{"iban":"Accountnumber","currency":"EUR"},"debtorName":"FONS (VUTG) - GROEIPAKKET","debtorAccount":{"iban":"Accountnumber","currency":"EUR"},"remittanceInformationUnstructured":"FONS (VUTG) - GROEIPAKKET Overschrijving TRIERSTRAAT 9 1000 BRUSSEL Accountnumber BIC: BBRUBEBB /C/ GROEIPAKKET - 1.00.318.245 GEZINSBIJSLAGEN 07/2024","bankTransactionCode":"PMNT-RCDT-ESCT","proprietaryBankTransactionCode":"0150000","internalTransactionId":"8e0909d3ef902f82721696f6eea042e0","**payeeName":"name-name S & I (BE47 XXX 5180)","date":"2024-08-07"},**

screenshot from actual 24.8.0 - same transaction fresh banksync
image

https://discordapp.com/channels/937901803608096828/1270082226750754977

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Windows 11

Originally created by @Soulplayer on GitHub (Aug 7, 2024). ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? After upgrading from 24.7.0 to 24.8.0 I have problems with the payeeName logic. Actualbudget chooses the wrong one. Log version 24.7.0: `[{"transactionId":"2024-08-07-10.24.47.258375","bookingDate":"2024-08-07","valueDate":"2024-08-07","transactionAmount":{"amount":"414.04","currency":"EUR"},"creditorName":"name-name S & I","creditorAccount":{"iban":"Accountnumber","currency":"EUR"},"debtorName":"FONS (VUTG) - GROEIPAKKET","debtorAccount":{"iban":"Accountnumber","currency":"EUR"},"remittanceInformationUnstructured":"FONS (VUTG) - GROEIPAKKET Overschrijving TRIERSTRAAT 9 1000 BRUSSEL BE46 3751 1175 9136 BIC: BBRUBEBB /C/ GROEIPAKKET - 1.00.318.245 GEZINSBIJSLAGEN 07/2024","bankTransactionCode":"code","internalTransactionId":"code","date":"2024-08-07"` screenshot from actual 24.7.0 ![image](https://picsur.verhaeghe-steyaert.be/i/1ca596d1-8779-4bfd-8074-6a5cb9bef908.jpg) Log version 24.8.0: `[{"transactionId":"2024-08-07-10.24.47.258375","bookingDate":"2024-08-07","valueDate":"2024-08-07","transactionAmount":{"amount":"414.04","currency":"EUR"},"creditorName":"name-name S & I","creditorAccount":{"iban":"Accountnumber","currency":"EUR"},"debtorName":"FONS (VUTG) - GROEIPAKKET","debtorAccount":{"iban":"Accountnumber","currency":"EUR"},"remittanceInformationUnstructured":"FONS (VUTG) - GROEIPAKKET Overschrijving TRIERSTRAAT 9 1000 BRUSSEL Accountnumber BIC: BBRUBEBB /C/ GROEIPAKKET - 1.00.318.245 GEZINSBIJSLAGEN 07/2024","bankTransactionCode":"PMNT-RCDT-ESCT","proprietaryBankTransactionCode":"0150000","internalTransactionId":"8e0909d3ef902f82721696f6eea042e0","**payeeName":"name-name S & I (BE47 XXX 5180)","date":"2024-08-07"},**` screenshot from actual 24.8.0 - same transaction fresh banksync ![image](https://picsur.verhaeghe-steyaert.be/i/34dc88d7-4269-4f17-9383-c98c3d98c963.jpg) https://discordapp.com/channels/937901803608096828/1270082226750754977 ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Firefox ### Operating System Windows 11
GiteaMirror added the bug label 2026-02-28 19:40:00 -06:00
GiteaMirror commented 2026-02-28 19:40:00 -06:00
Author
Owner
Copy Link

@psybers commented on GitHub (Aug 7, 2024):

@matt-fidd This might be related to #2721?

@psybers commented on GitHub (Aug 7, 2024): @matt-fidd This might be related to #2721?
GiteaMirror commented 2026-02-28 19:40:01 -06:00
Author
Owner
Copy Link

@Soulplayer commented on GitHub (Aug 7, 2024):

Paypal and revolut work as expected but two of my banks are not:
KBC - KREDBEBB
VDK - VDSPBE22XXX

@Soulplayer commented on GitHub (Aug 7, 2024): Paypal and revolut work as expected but two of my banks are not: KBC - KREDBEBB VDK - VDSPBE22XXX
GiteaMirror commented 2026-02-28 19:40:01 -06:00
Author
Owner
Copy Link

@MMichotte commented on GitHub (Aug 8, 2024):

Got the same issue after updating to 24.8.0.
Payee is now always my own account instead of the actual payee..
Bank:
CBC - CREGBEBBXXX

@MMichotte commented on GitHub (Aug 8, 2024): Got the same issue after updating to 24.8.0. Payee is now always my own account instead of the actual payee.. Bank: CBC - CREGBEBBXXX
GiteaMirror commented 2026-02-28 19:40:01 -06:00
Author
Owner
Copy Link

@Soulplayer commented on GitHub (Aug 16, 2024):

Not to sound ungrateful because I love actualbudget, but is this being looked at? This is a really annoying bug for me :( .

@Soulplayer commented on GitHub (Aug 16, 2024): Not to sound ungrateful because I love actualbudget, but is this being looked at? This is a really annoying bug for me :( .
GiteaMirror commented 2026-02-28 19:40:02 -06:00
Author
Owner
Copy Link

@tcrasset commented on GitHub (Aug 16, 2024):

The logic for determining the payeeName is now all in this function baf04a4d48/src/util/payee-name.js (L7)

  if (trans.amount > 0 || Object.is(Number(trans.amount), 0)) {
    name = trans.debtorName;
    account = trans.debtorAccount;
  } else {
    name = trans.creditorName;
    account = trans.creditorAccount;
  }

  // use the correct name field if it was found
  // if not, use whatever we can find
  name =
    name ||
    trans.debtorName ||
    trans.creditorName ||
    trans.remittanceInformationUnstructured ||
    (trans.remittanceInformationUnstructuredArray || []).join(', ') ||
    trans.additionalInformation;

As far as I understand it, the only way that the creditorName is chosen even if the amount seems positive, is that the amount (trans.amount) is either parsed as a string, or is not parsed correctly and undefined is being returned, which leads to the else branch being taken,and name = trans.creditorName being used.

@tcrasset commented on GitHub (Aug 16, 2024): The logic for determining the payeeName is now all in this function https://github.com/actualbudget/actual-server/blob/baf04a4d48a6abd667874f14f978abd6e086a41e/src/util/payee-name.js#L7 ```js if (trans.amount > 0 || Object.is(Number(trans.amount), 0)) { name = trans.debtorName; account = trans.debtorAccount; } else { name = trans.creditorName; account = trans.creditorAccount; } // use the correct name field if it was found // if not, use whatever we can find name = name || trans.debtorName || trans.creditorName || trans.remittanceInformationUnstructured || (trans.remittanceInformationUnstructuredArray || []).join(', ') || trans.additionalInformation; ``` As far as I understand it, the only way that the creditorName is chosen even if the amount seems positive, is that the amount (`trans.amount`) is either parsed as a string, or is not parsed correctly and `undefined` is being returned, which leads to the else branch being taken,and `name = trans.creditorName` being used.
GiteaMirror commented 2026-02-28 19:40:02 -06:00
Author
Owner
Copy Link

@Soulplayer commented on GitHub (Aug 16, 2024):

Is there a way I can help to debug this issue?

@Soulplayer commented on GitHub (Aug 16, 2024): Is there a way I can help to debug this issue?
GiteaMirror commented 2026-02-28 19:40:03 -06:00
Author
Owner
Copy Link

@matt-fidd commented on GitHub (Aug 16, 2024):

I think I've found the bug, there's a PR up now in actual-server

@matt-fidd commented on GitHub (Aug 16, 2024): I think I've found the bug, there's a PR up now in actual-server
GiteaMirror commented 2026-02-28 19:40:03 -06:00
Author
Owner
Copy Link

@Soulplayer commented on GitHub (Aug 18, 2024):

Can i download a docker build with this fix in it?

@Soulplayer commented on GitHub (Aug 18, 2024): Can i download a docker build with this fix in it?
GiteaMirror commented 2026-02-28 19:40:04 -06:00
Author
Owner
Copy Link

@Teprifer commented on GitHub (Aug 18, 2024):

@Soulplayer There is an edge (and edge-alpine) build created daily, you can grab that. I think there is a migration in it which means you won't be able to go back to a release version until the next release.

@Teprifer commented on GitHub (Aug 18, 2024): @Soulplayer There is an edge (and edge-alpine) build created daily, you can grab that. I think there is a migration in it which means you won't be able to go back to a release version until the next release.
GiteaMirror commented 2026-02-28 19:40:04 -06:00
Author
Owner
Copy Link

@ArnaudWeyts commented on GitHub (Aug 20, 2024):

@Soulplayer, is this working for you again? I've updated to the latest edge version but new transactions still have a payee name that is one of my own accounts instead of the actual payee. Wondering if it's related to my setup 🤔

@ArnaudWeyts commented on GitHub (Aug 20, 2024): @Soulplayer, is this working for you again? I've updated to the latest edge version but new transactions still have a payee name that is one of my own accounts instead of the actual payee. Wondering if it's related to my setup 🤔
GiteaMirror commented 2026-02-28 19:40:04 -06:00
Author
Owner
Copy Link

@psybers commented on GitHub (Aug 20, 2024):

@Soulplayer, is this working for you again? I've updated to the latest edge version but new transactions still have a payee name that is one of my own accounts instead of the actual payee. Wondering if it's related to my setup 🤔

Check your rules, they might be applying to your transactions and changing the payee.

@psybers commented on GitHub (Aug 20, 2024): > @Soulplayer, is this working for you again? I've updated to the latest edge version but new transactions still have a payee name that is one of my own accounts instead of the actual payee. Wondering if it's related to my setup 🤔 Check your rules, they might be applying to your transactions and changing the payee.
GiteaMirror commented 2026-02-28 19:40:05 -06:00
Author
Owner
Copy Link

@Soulplayer commented on GitHub (Aug 20, 2024):

I thought it was fixed but I'm wrong. I'm still seeing this issue. I deleted all my rules to make sure it was not related to my setup. But I think it is only with payments now. Deposits seems to be showing the right information.

This shows the right name (with the account number from wich the deposit comes, I don't think this used to be shown):
image

Payment shows my account and name:
image

@matt-fidd can this be reopened or do I need to open a new issue?

@Soulplayer commented on GitHub (Aug 20, 2024): I thought it was fixed but I'm wrong. I'm still seeing this issue. I deleted all my rules to make sure it was not related to my setup. But I think it is only with payments now. Deposits seems to be showing the right information. This shows the right name (with the account number from wich the deposit comes, I don't think this used to be shown): ![image](https://picsur.verhaeghe-steyaert.be/i/b65d693d-5c12-4208-9152-a8b1e9525d63.jpg) Payment shows my account and name: ![image](https://picsur.verhaeghe-steyaert.be/i/86ad12ce-2464-49a9-9ca7-07ed404235e7.jpg) @matt-fidd can this be reopened or do I need to open a new issue?
GiteaMirror commented 2026-02-28 19:40:05 -06:00
Author
Owner
Copy Link

@Soulplayer commented on GitHub (Aug 28, 2024):

@Soulplayer, is this working for you again? I've updated to the latest edge version but new transactions still have a payee name that is one of my own accounts instead of the actual payee. Wondering if it's related to my setup 🤔

@ArnaudWeyts & @MMichotte Do you still have this issue? I'm now only seeing it with KBC (so I made a new issue).

@Soulplayer commented on GitHub (Aug 28, 2024): > @Soulplayer, is this working for you again? I've updated to the latest edge version but new transactions still have a payee name that is one of my own accounts instead of the actual payee. Wondering if it's related to my setup 🤔 @ArnaudWeyts & @MMichotte Do you still have this issue? I'm now only seeing it with KBC (so I made a new issue).
GiteaMirror commented 2026-02-28 19:40:06 -06:00
Author
Owner
Copy Link

@ArnaudWeyts commented on GitHub (Aug 28, 2024):

@Soulplayer, I'm indeed still seeing this issue. Upvoted your new issue, deposits are fixed but not payments.

@ArnaudWeyts commented on GitHub (Aug 28, 2024): @Soulplayer, I'm indeed still seeing this issue. Upvoted your new issue, deposits are fixed but not payments.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#1310
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?