[PR #5600] Add conditional to schedules logic in rules page - improve VRT stability #13079

New Issue

2026-04-10T21:46:39-05:00

GiteaMirror commented

2026-04-10 21:46:39 -05:00

Original Pull Request: https://github.com/actualbudget/actual/pull/5600

State: closed
Merged: Yes

Refactor schedule handling in ManageRules component

Updated the ManageRules component to use ScheduleEntity type for schedules.
Improved the describeSchedule function to include type annotations for better clarity.
Added a conditional check to handle cases where the schedule may not exist, ensuring robust functionality.

This has been making the rules VRT tests flaky. For example: https://github.com/actualbudget/actual/actions/runs/17114788611/job/48543539731?pr=5587

**Original Pull Request:** https://github.com/actualbudget/actual/pull/5600 **State:** closed **Merged:** Yes --- Refactor schedule handling in ManageRules component - Updated the ManageRules component to use ScheduleEntity type for schedules. - Improved the describeSchedule function to include type annotations for better clarity. - Added a conditional check to handle cases where the schedule may not exist, ensuring robust functionality. **This has been making the rules VRT tests flaky. For example: https://github.com/actualbudget/actual/actions/runs/17114788611/job/48543539731?pr=5587**

GiteaMirror added the pull-request label 2026-04-10 21:46:39 -05:00

GiteaMirror closed this issue

2026-04-10 21:46:40 -05:00

Sign in to join this conversation.

Branches Tags

master

matiss/enable-banking-pending-and-rate-limit

claude/lucid-turing-br8zwl

jfdoming/api-key-shared-bank-sync

worktree-pr-description-rules

ios-ci-launch-test

worktree-count-points-gh-bot

theme-number-contrast

theme-contrast-test

fix/automatic-bank-sync-mobile-app

future-buffer

carryover-chain

copilot/fix-failing-github-actions-job

copilot/fix-failing-github-actions-job-compare

fix/hide-sab-warning-in-capacitor

release

tabedzki/feat/docker-non-root

ios-home-screen-widgets

mobile-budget-redesign

ai/fix-mobile-carryover-arrow-alignment

jfdoming/provider-identity-update

jfdoming/electron-signin-update

jfdoming/openid-flow-update

release-update/26.10.1

release-notes/26.10.1

matiss/dazzling-babbage-b9rjwi

react-query-rules

ai/add-loan-formula-autocomplete

claude/pr-8519-regression-testing-fhvrrh

speed-up-transaction-list-and-schedules

fix-slow-balance-recompute-on-transaction-edit

jfdoming/opfs-sahpool-mobile

jfdoming/opfs-sahpool

fix-8612-schedule-delete-menu

jfdoming/api-tokens-part-8

jfdoming/api-tokens-part-7

jfdoming/api-tokens-part-6

jfdoming/api-tokens-part-5

jfdoming/mobile-safe-area-header

jfdoming/api-tokens-part-4

jfdoming/mobile-splash-lifecycle

jfdoming/api-tokens-part-3

jfdoming/mobile-shared-array-buffer

jfdoming/api-tokens-part-2

jfdoming/api-tokens-part-1

persist-transaction-filters

claude/modernize-transactions-tanstack-orgrze

bank-sync-per-file-03-pluggy-loot-core

claude/auto-close-prs-no-profile-pic-mjqpsy

cross-version-sync-stage2

claude/react-table-library-research-afx83z

tolerate-newer-migrations

claude/verify-migration-guardrails-i82c8m

tabedzki/feat/replacing-month-picker-with-day-picker

delay-initial-sync-until-loaded

cross-version-sync-compat

jfdoming/mobile-app-updates

claude/budget-version-migration-compat-151jlr

claude/worker-error-serialization-9iqtl7

claude/issue-8401-regression-test-9nw9l3

jfdoming/mobile-app-foundation-part-1

jfdoming/mobile-app-scaffold

ai-fix-cleanup-def-8290

claude/relaxed-shannon-jusywa

claude/fervent-keller-s6f2fq

claude/determined-feynman-st1y9z

claude/wizardly-einstein-vi2wce

claude/sweet-albattani-7nseio

feat/bank-sync-per-budget-file

claude/affectionate-cannon-y0kc82

claude/dependabot-findings-m9pgmb

claude/mac-app-ios-publish-zjs1lz

claude/vigilant-tesla-aiiyos

claude/quirky-cerf-v5qck7

claude/animation-removal-alternative-2etfh1

claude/netlify-preview-comments-consolidate-9XPYa

osc/7391-error-boundaries-reports

claude/pensive-dijkstra-7DYui

claude/server-app-version-mismatch-HTCGv

claude/pr-8027-review-feedback-mELuO

claude/zealous-wozniak-e5pO0

claude/intelligent-heisenberg-BSHJq

claude/translation-download-refactor-jFRsO

claude/mobile-performance-ideas-G9PAO

claude/github-issue-7988-5A5ly

blacksmith-migration-ff70d2d

claude/great-mayer-KRvOk

claude/react-native-ios-compilation-fcJh5

claude/serene-goldberg-58xv0

claude/kind-euler-LVG3K

release-automation/edge-nightly

7710-bundle-migrations

claude/fix-docker-build-error-WMfed

claude/llm-compatible-release-notes-t20Nr

7710-tests-tdd

cursor/transaction-table-rewrite-f077

claude/plan-ci-secure-context-OtEe1

claude/fix-issue-7667-DPXi3

cursor/resolve-pr-7449-ee11

claude/fix-typescript-build-error-JPtZ5

copilot/add-repository-configs-to-packages

worktree-compressed-drifting-ritchie

claude/api-consumer-verification-kfz1K

pr-7454

claude/fix-issue-7410-LLLQ4

revert-7281-generate-icons

react-query-useSchedules

copilot/sub-pr-6140

package-upgrades

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/actual#13079