github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6437] [MERGED] Fix schedule upcoming length years off-by-1 calculation #130630

New Issue
Closed
opened 2026-06-15 22:39:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-15 22:39:31 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6437
Author: @Ani07-05
Created: 12/17/2025
Status: ✅ Merged
Merged: 12/17/2025
Merged by: @youngcw

Base: master ← Head: fix/schedule-upcoming-years-calculation

📝 Commits (2)

  • c427122 Fix schedule upcoming length years off-by-1 calculation
  • 94a9ae0 Fix syntax error in schedules.test.ts and add release notes

📊 Changes

3 files changed (+10 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/shared/schedules.test.ts (+3 -0)
📝 packages/loot-core/src/shared/schedules.ts (+1 -1)
➕ upcoming-release-notes/6437.md (+6 -0)

📄 Description

  • Replace addYears with addMonths(value * 12) to preserve day precision
  • Fixes issue where year-based upcoming schedules always calculated from Jan 1st
  • Add test cases for mid-year dates to prevent regression

Fixes #6435

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6437 **Author:** [@Ani07-05](https://github.com/Ani07-05) **Created:** 12/17/2025 **Status:** ✅ Merged **Merged:** 12/17/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix/schedule-upcoming-years-calculation` --- ### 📝 Commits (2) - [`c427122`](https://github.com/actualbudget/actual/commit/c427122ac4385672ab992839801d6249940f831f) Fix schedule upcoming length years off-by-1 calculation - [`94a9ae0`](https://github.com/actualbudget/actual/commit/94a9ae012e78a127732f86bec5ccdbf19b810925) Fix syntax error in schedules.test.ts and add release notes ### 📊 Changes **3 files changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/shared/schedules.test.ts` (+3 -0) 📝 `packages/loot-core/src/shared/schedules.ts` (+1 -1) ➕ `upcoming-release-notes/6437.md` (+6 -0) </details> ### 📄 Description - Replace addYears with addMonths(value * 12) to preserve day precision - Fixes issue where year-based upcoming schedules always calculated from Jan 1st - Add test cases for mid-year dates to prevent regression Fixes #6435 <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-15 22:39:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#130630