github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-13 17:43:23 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #5754] [CLOSED] Remove maxHeight property on CategoryList #130203

New Issue
Closed
opened 2026-06-15 22:00:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-15 22:00:59 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5754
Author: @patmagauran
Created: 9/20/2025
Status: ❌ Closed

Base: master ← Head: cateogry-list-height

📝 Commits (3)

  • a97d6e8 Remove maxHeight property on CategoryList and allow it to auto size based on screen size
  • c9abfaf Merge branch 'master' into cateogry-list-height
  • 8349c30 Update VRT

📊 Changes

5 files changed (+6 additions, -1 deletions)

View changed files

📝 packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+0 -1)
➕ upcoming-release-notes/5754.md (+6 -0)

📄 Description

When clicking on the category for a transaction in the transactions list, the menu that appears is frustratingly short, especially if you have created a lot of categories. This removes the maxHeight style property and allows it to auto size appropriately. If there is a reason for the height to be limited in certain scenarios I can revisit to settle on a better value or responsive value.

I am attaching some before and after screenshots below. I have added a bunch of extra "dummy" categories to highlight the change.

Before
image

After
image

Verification in responsive mode
image

Verification in mobile mode
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5754 **Author:** [@patmagauran](https://github.com/patmagauran) **Created:** 9/20/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cateogry-list-height` --- ### 📝 Commits (3) - [`a97d6e8`](https://github.com/actualbudget/actual/commit/a97d6e8d3cdd12a1e2af21bcc4d20de79cd7b326) Remove maxHeight property on CategoryList and allow it to auto size based on screen size - [`c9abfaf`](https://github.com/actualbudget/actual/commit/c9abfafe3d57530d2e7427b7ccc23c9238f2519b) Merge branch 'master' into cateogry-list-height - [`8349c30`](https://github.com/actualbudget/actual/commit/8349c30a0532fc0694bb552bff555c83f91e7dd8) Update VRT ### 📊 Changes **5 files changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+0 -1) ➕ `upcoming-release-notes/5754.md` (+6 -0) </details> ### 📄 Description When clicking on the category for a transaction in the transactions list, the menu that appears is frustratingly short, especially if you have created a lot of categories. This removes the maxHeight style property and allows it to auto size appropriately. If there is a reason for the height to be limited in certain scenarios I can revisit to settle on a better value or responsive value. I am attaching some before and after screenshots below. I have added a bunch of extra "dummy" categories to highlight the change. Before <img width="1827" height="1336" alt="image" src="https://github.com/user-attachments/assets/3d2db72d-de4f-4507-a104-f9b2178b5cfd" /> After <img width="1827" height="1333" alt="image" src="https://github.com/user-attachments/assets/3f1fe7ee-9107-4902-8b1a-56cefc97ef72" /> Verification in responsive mode <img width="1237" height="883" alt="image" src="https://github.com/user-attachments/assets/d9abe39e-1781-4de5-9fb4-cb8784750ef6" /> Verification in mobile mode <img width="1128" height="1114" alt="image" src="https://github.com/user-attachments/assets/450ab249-5213-4995-821d-fdb6404e2797" /> <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-15 22:00:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#130203