github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 23:26:48 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #3507] [MERGED] ♻️ (typescript) migrated ManagePayees and LoadBackupModal files #129002

New Issue
Closed
opened 2026-06-15 20:13:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-15 20:13:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3507
Author: @MatissJanis
Created: 9/25/2024
Status: ✅ Merged
Merged: 10/9/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/ts-migration

📝 Commits (8)

  • be0eccd ♻️ (typescript) migrate LoadBackupModal to ts
  • 87ee246 ♻️ (typescript) migrated ManagePayees and LoadBackupModal files
  • 1e4b4a8 Address bot feedback
  • 5147e47 Merge branch 'master' into matiss/ts-migration
  • 3849b85 Patch typechecker
  • 2bd0669 Feedback: favorite as number
  • 612d68a Merge branch 'master' into matiss/ts-migration
  • fc8c512 Merge branch 'master' into matiss/ts-migration

📊 Changes

16 files changed (+391 additions, -475 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.test.tsx (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/LoadBackupModal.tsx (+45 -41)
➖ packages/desktop-client/src/components/payees/ManagePayees.jsx (+0 -355)
➕ packages/desktop-client/src/components/payees/ManagePayees.tsx (+284 -0)
📝 packages/desktop-client/src/components/payees/ManagePayeesWithData.jsx (+1 -3)
📝 packages/desktop-client/src/components/payees/PayeeMenu.tsx (+1 -1)
📝 packages/desktop-client/src/components/payees/PayeeTable.tsx (+39 -47)
📝 packages/desktop-client/src/components/payees/PayeeTableRow.tsx (+3 -3)
📝 packages/desktop-client/src/components/table.tsx (+1 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx (+3 -3)
➖ packages/desktop-client/src/hooks/useStableCallback.ts (+0 -16)
📝 packages/loot-core/src/shared/util.ts (+3 -1)
📝 packages/loot-core/src/types/models/payee.d.ts (+1 -1)
📝 packages/loot-core/src/types/server-events.d.ts (+2 -1)
➕ upcoming-release-notes/3507.md (+6 -0)

📄 Description

https://github.com/actualbudget/actual/issues/1483

Also significantly cleaned up ManagePayees codebase. Removed a lot of functionality that has been broken for ages (since open sourcing I think) - row highlighting, scroll-to effects and some table animations. None of these functionalities worked.. and since nobody has noticed that it doesn't work - might as well clean it up.

Planing to merge after the release is out (subject to approvals).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3507 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 9/25/2024 **Status:** ✅ Merged **Merged:** 10/9/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/ts-migration` --- ### 📝 Commits (8) - [`be0eccd`](https://github.com/actualbudget/actual/commit/be0eccda0188f7bbc324c12bcd85f565f9ec5068) :recycle: (typescript) migrate LoadBackupModal to ts - [`87ee246`](https://github.com/actualbudget/actual/commit/87ee246d593c82ef57a091b6caa2ba82adbb2f3e) :recycle: (typescript) migrated ManagePayees and LoadBackupModal files - [`1e4b4a8`](https://github.com/actualbudget/actual/commit/1e4b4a84c95090ffad135b41ea96bb8835ecbda5) Address bot feedback - [`5147e47`](https://github.com/actualbudget/actual/commit/5147e4736e37d733ac6abe6d0511852581622adb) Merge branch 'master' into matiss/ts-migration - [`3849b85`](https://github.com/actualbudget/actual/commit/3849b85a5567e0942fc8cc435b8db362d728d839) Patch typechecker - [`2bd0669`](https://github.com/actualbudget/actual/commit/2bd06694ec64a56c9c892ac05ad31268724b4033) Feedback: favorite as number - [`612d68a`](https://github.com/actualbudget/actual/commit/612d68a2e087cd9faffb4a296744caa9823c359b) Merge branch 'master' into matiss/ts-migration - [`fc8c512`](https://github.com/actualbudget/actual/commit/fc8c512dd31111d8a0c4fef9955686b41c122bba) Merge branch 'master' into matiss/ts-migration ### 📊 Changes **16 files changed** (+391 additions, -475 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.test.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/LoadBackupModal.tsx` (+45 -41) ➖ `packages/desktop-client/src/components/payees/ManagePayees.jsx` (+0 -355) ➕ `packages/desktop-client/src/components/payees/ManagePayees.tsx` (+284 -0) 📝 `packages/desktop-client/src/components/payees/ManagePayeesWithData.jsx` (+1 -3) 📝 `packages/desktop-client/src/components/payees/PayeeMenu.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/payees/PayeeTable.tsx` (+39 -47) 📝 `packages/desktop-client/src/components/payees/PayeeTableRow.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/table.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx` (+3 -3) ➖ `packages/desktop-client/src/hooks/useStableCallback.ts` (+0 -16) 📝 `packages/loot-core/src/shared/util.ts` (+3 -1) 📝 `packages/loot-core/src/types/models/payee.d.ts` (+1 -1) 📝 `packages/loot-core/src/types/server-events.d.ts` (+2 -1) ➕ `upcoming-release-notes/3507.md` (+6 -0) </details> ### 📄 Description https://github.com/actualbudget/actual/issues/1483 Also significantly cleaned up `ManagePayees` codebase. Removed a lot of functionality that has been broken for ages (since open sourcing I think) - row highlighting, scroll-to effects and some table animations. None of these functionalities worked.. and since nobody has noticed that it doesn't work - might as well clean it up. Planing to merge after the release is out (subject to approvals). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-15 20:13:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#129002
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?