github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #731] [CLOSED] Reporting Overhaul #127394

New Issue
Closed
opened 2026-06-15 17:35:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-15 17:35:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/731
Author: @carkom
Created: 3/8/2023
Status: ❌ Closed

Base: master ← Head: reporting

📝 Commits (10+)

  • 3616c59 Reporting Overhaul
  • b888961 build errors
  • dd91ac2 Merge branch 'master' into reporting
  • aa9190c build errors
  • 85fc9c1 Changed spreadsheet functions
  • 87d3206 Fixed bug that was causing crash
  • db222d2 Updated Donut labels and tooltips
  • 9854f03 Final formatting changes.
  • a1e5256 Renamed and reorganized components
  • d006d26 Merge branch 'master' into reporting

📊 Changes

26 files changed (+1697 additions, -50 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.js (+3 -3)
📝 packages/desktop-client/src/components/accounts/Filters.js (+10 -8)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.js (+1 -2)
➕ packages/desktop-client/src/components/reports/AllReports.js (+245 -0)
📝 packages/desktop-client/src/components/reports/CashFlow.js (+3 -3)
➕ packages/desktop-client/src/components/reports/CashFlowReport.js (+103 -0)
➕ packages/desktop-client/src/components/reports/Charts.js (+168 -0)
📝 packages/desktop-client/src/components/reports/Header.js (+105 -20)
➕ packages/desktop-client/src/components/reports/IncomeExpenseReport.js (+188 -0)
📝 packages/desktop-client/src/components/reports/NetWorth.js (+3 -3)
➕ packages/desktop-client/src/components/reports/NetWorthReport.js (+70 -0)
📝 packages/desktop-client/src/components/reports/Overview.js (+2 -2)
📝 packages/desktop-client/src/components/reports/Tooltip.js (+1 -2)
📝 packages/desktop-client/src/components/reports/chart-theme.js (+6 -0)
➕ packages/desktop-client/src/components/reports/graphs/BarGraph.js (+63 -0)
➕ packages/desktop-client/src/components/reports/graphs/BarLineGraph.js (+63 -0)
📝 packages/desktop-client/src/components/reports/graphs/CashFlowGraph.js (+1 -2)
➕ packages/desktop-client/src/components/reports/graphs/DonutGraph.js (+52 -0)
➕ packages/desktop-client/src/components/reports/graphs/LineGraph.js (+129 -0)
📝 packages/desktop-client/src/components/reports/graphs/NetWorthGraph.js (+1 -2)

...and 6 more files

📄 Description

Okay, so I went back to the drawing board and tried to create something more useful.

In order to improve convenience and user interface I decided to try having it all on one space rather than having multiple sheets that you have to navigate around from one page to the next. This essentially creates a "tabbed" view where changing reports is really quick and easy.

The filter was given it's own dedicated space for all graphs then just disabled for some where it isn't useful to have. This avoids constant jumping of the main graph area as the header shrunk and expanded to accomodate the filter disappearing.

I've tried to keep NetWorth and CashFlow pretty much the same. The main addition (other than layout and usability) is the addition of the "Income & Expenses" view. Here we get a "totals" graph in donut form and a trend graph in bar form (both filterable with existing filter code). Based on previous discussions I wanted to make "expenses, income and net" available here so chose a drop down menu for that.

**Big thing missing that I spent hours troubleshooting but couldn't figure out is the labels/tooltips on the donut graph. Any help would be appreciated.

There are some bugs I'd like to get help with sorting out. Mainly it's when switching from the "totals" view to NetWorth or CashFlow. The change in grouping of the data doesn't render before the code requests a date or an income which then throws a "cannot convert" error because x axis was "category" and it's changing to a date.**

Notes:

  • I've also changed the way the spreadsheets and graphs are organized and named so that future creation of graphs will be much easier as they are all more standardized.
  • I've removed the "Back" button in the reports page as it was a duplicate of the "reports" sidebar link at they were right next to eachother on the page.
  • I've updated some colors to make the look of "accounts" page match with "reports" page.
  • Fixed issue [Bug]: Transaction selection checkbox no longer appears on hover (#375)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/731 **Author:** [@carkom](https://github.com/carkom) **Created:** 3/8/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `reporting` --- ### 📝 Commits (10+) - [`3616c59`](https://github.com/actualbudget/actual/commit/3616c59cb8aff3424a117fa4fbd5ec0982abc01f) Reporting Overhaul - [`b888961`](https://github.com/actualbudget/actual/commit/b888961a9ab46fe3fcb60536560e1e675f757cde) build errors - [`dd91ac2`](https://github.com/actualbudget/actual/commit/dd91ac2bf4c5d478bf7fd575f65ccdff37ae5dd1) Merge branch 'master' into reporting - [`aa9190c`](https://github.com/actualbudget/actual/commit/aa9190c153c5dd8547640f1a8a31b5da66bed049) build errors - [`85fc9c1`](https://github.com/actualbudget/actual/commit/85fc9c1716e74bce2104df3bcfa94df265748934) Changed spreadsheet functions - [`87d3206`](https://github.com/actualbudget/actual/commit/87d3206071a2a60b01efa4a5633e8b6e0e7e217e) Fixed bug that was causing crash - [`db222d2`](https://github.com/actualbudget/actual/commit/db222d2621974ac663f73d8ce8f697b8c937c56c) Updated Donut labels and tooltips - [`9854f03`](https://github.com/actualbudget/actual/commit/9854f03c6e34ba1b009de77938d8e19c78783e6b) Final formatting changes. - [`a1e5256`](https://github.com/actualbudget/actual/commit/a1e5256d4a812eeb47be91b5dbb424943b19be84) Renamed and reorganized components - [`d006d26`](https://github.com/actualbudget/actual/commit/d006d26fb629c873b12b4c318e9d7753564247a6) Merge branch 'master' into reporting ### 📊 Changes **26 files changed** (+1697 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.js` (+3 -3) 📝 `packages/desktop-client/src/components/accounts/Filters.js` (+10 -8) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.js` (+1 -2) ➕ `packages/desktop-client/src/components/reports/AllReports.js` (+245 -0) 📝 `packages/desktop-client/src/components/reports/CashFlow.js` (+3 -3) ➕ `packages/desktop-client/src/components/reports/CashFlowReport.js` (+103 -0) ➕ `packages/desktop-client/src/components/reports/Charts.js` (+168 -0) 📝 `packages/desktop-client/src/components/reports/Header.js` (+105 -20) ➕ `packages/desktop-client/src/components/reports/IncomeExpenseReport.js` (+188 -0) 📝 `packages/desktop-client/src/components/reports/NetWorth.js` (+3 -3) ➕ `packages/desktop-client/src/components/reports/NetWorthReport.js` (+70 -0) 📝 `packages/desktop-client/src/components/reports/Overview.js` (+2 -2) 📝 `packages/desktop-client/src/components/reports/Tooltip.js` (+1 -2) 📝 `packages/desktop-client/src/components/reports/chart-theme.js` (+6 -0) ➕ `packages/desktop-client/src/components/reports/graphs/BarGraph.js` (+63 -0) ➕ `packages/desktop-client/src/components/reports/graphs/BarLineGraph.js` (+63 -0) 📝 `packages/desktop-client/src/components/reports/graphs/CashFlowGraph.js` (+1 -2) ➕ `packages/desktop-client/src/components/reports/graphs/DonutGraph.js` (+52 -0) ➕ `packages/desktop-client/src/components/reports/graphs/LineGraph.js` (+129 -0) 📝 `packages/desktop-client/src/components/reports/graphs/NetWorthGraph.js` (+1 -2) _...and 6 more files_ </details> ### 📄 Description Okay, so I went back to the drawing board and tried to create something more useful. In order to improve convenience and user interface I decided to try having it all on one space rather than having multiple sheets that you have to navigate around from one page to the next. This essentially creates a "tabbed" view where changing reports is really quick and easy. The filter was given it's own dedicated space for all graphs then just disabled for some where it isn't useful to have. This avoids constant jumping of the main graph area as the header shrunk and expanded to accomodate the filter disappearing. I've tried to keep NetWorth and CashFlow pretty much the same. The main addition (other than layout and usability) is the addition of the "Income & Expenses" view. Here we get a "totals" graph in donut form and a trend graph in bar form (both filterable with existing filter code). Based on previous discussions I wanted to make "expenses, income and net" available here so chose a drop down menu for that. **Big thing missing that I spent hours troubleshooting but couldn't figure out is the labels/tooltips on the donut graph. Any help would be appreciated. There are some bugs I'd like to get help with sorting out. Mainly it's when switching from the "totals" view to NetWorth or CashFlow. The change in grouping of the data doesn't render before the code requests a date or an income which then throws a "cannot convert" error because x axis was "category" and it's changing to a date.** Notes: - I've also changed the way the spreadsheets and graphs are organized and named so that future creation of graphs will be much easier as they are all more standardized. - I've removed the "Back" button in the reports page as it was a duplicate of the "reports" sidebar link at they were right next to eachother on the page. - I've updated some colors to make the look of "accounts" page match with "reports" page. - Fixed issue #375 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-15 17:35:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#127394
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?