github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8211] [MERGED] :electron: Fix desktop app workflow for windows builds #127074

New Issue
Closed
opened 2026-06-14 06:37:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-14 06:37:35 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8211
Author: @MikesGlitch
Created: 6/13/2026
Status: ✅ Merged
Merged: 6/13/2026
Merged by: @MikesGlitch

Base: master ← Head: fix/desktop-app-workflow-windows

📝 Commits (5)

  • 8c5448b fix desktop app workflow for windows builds
  • d1012ff release notes
  • df18df3 append variable to github env so its available in other steps
  • 2ee286e pin to 2022
  • 8291fdc release notes

📊 Changes

3 files changed (+8 additions, -2 deletions)

View changed files

📝 .github/workflows/electron-master.yml (+1 -1)
📝 .github/workflows/electron-pr.yml (+1 -1)
➕ upcoming-release-notes/8211.md (+6 -0)

📄 Description

Description

windows-latest on GitHub Actions recently switched to windows-2025. This broke the windows electron builds.

Pinning us to 2022 to fix the issue, we can try the upgrade at a later time.

Related issue(s)

Testing

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I have read every line of this diff and can explain what each change does and why it is needed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8211 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 6/13/2026 **Status:** ✅ Merged **Merged:** 6/13/2026 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `fix/desktop-app-workflow-windows` --- ### 📝 Commits (5) - [`8c5448b`](https://github.com/actualbudget/actual/commit/8c5448b4a71d1f125ee1a528091b8b46f8e1c399) fix desktop app workflow for windows builds - [`d1012ff`](https://github.com/actualbudget/actual/commit/d1012ff8ed45bfff8d16835cdf2ad1b8d1113775) release notes - [`df18df3`](https://github.com/actualbudget/actual/commit/df18df3ee920cf1d11ee7f8100eb9558eea3bf19) append variable to github env so its available in other steps - [`2ee286e`](https://github.com/actualbudget/actual/commit/2ee286e1888118d0c41bff627a3589e776466a14) pin to 2022 - [`8291fdc`](https://github.com/actualbudget/actual/commit/8291fdc98470b32e9c29f6f78071ff581541a0fa) release notes ### 📊 Changes **3 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/electron-master.yml` (+1 -1) 📝 `.github/workflows/electron-pr.yml` (+1 -1) ➕ `upcoming-release-notes/8211.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://actualbudget.org/docs/contributing/#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description <!-- What does this PR do? Why is it needed? Please give context on the "why?": why do we need this change? What problem is it solving for you?--> windows-latest on GitHub Actions recently switched to windows-2025. This broke the windows electron builds. Pinning us to 2022 to fix the issue, we can try the upgrade at a later time. <!-- If AI tools wrote a significant part of this change, please disclose it here and name the tool you used. See https://actualbudget.org/docs/contributing/ai-usage-policy --> ## Related issue(s) <!-- e.g. Fixes #123, Relates to #456 --> ## Testing <!-- What did you test? How can we reproduce the issue you are fixing or how can we test the feature you built? --> ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I have read every line of this diff and can explain what each change does and why it is needed <!--- actual-bot-sections ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-14 06:37:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#127074