mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-16 07:04:23 -05:00
Open
opened 2026-06-14 06:34:03 -05:00 by GiteaMirror
·
0 comments
No Branch/Tag Specified
master
dependabot/npm_and_yarn/npm_and_yarn-cd62b4b37a
api-browser-custom-data-dir
tabedzki/feat/replacing-month-picker-with-day-picker
delay-initial-sync-until-loaded
jfdoming/mobile-app-build
cross-version-sync-compat
jfdoming/api-tokens-part-1
jfdoming/api-tokens-part-2
jfdoming/api-tokens-part-3
jfdoming/mobile-app-updates
claude/budget-version-migration-compat-151jlr
claude/worker-error-serialization-9iqtl7
claude/react-table-library-research-afx83z
claude/issue-8401-regression-test-9nw9l3
jfdoming/mobile-app-foundation-part-1
jfdoming/mobile-app-scaffold
release
ai-fix-cleanup-def-8290
claude/relaxed-shannon-jusywa
claude/fervent-keller-s6f2fq
claude/determined-feynman-st1y9z
claude/wizardly-einstein-vi2wce
claude/sweet-albattani-7nseio
feat/bank-sync-per-budget-file
claude/affectionate-cannon-y0kc82
claude/dependabot-findings-m9pgmb
claude/mac-app-ios-publish-zjs1lz
claude/vigilant-tesla-aiiyos
depot-migrate-secrets-1781296330308
claude/quirky-cerf-v5qck7
claude/animation-removal-alternative-2etfh1
claude/netlify-preview-comments-consolidate-9XPYa
osc/7391-error-boundaries-reports
claude/pensive-dijkstra-7DYui
claude/server-app-version-mismatch-HTCGv
claude/pr-8027-review-feedback-mELuO
claude/zealous-wozniak-e5pO0
claude/intelligent-heisenberg-BSHJq
claude/translation-download-refactor-jFRsO
claude/mobile-performance-ideas-G9PAO
claude/github-issue-7988-5A5ly
blacksmith-migration-ff70d2d
claude/great-mayer-KRvOk
claude/react-native-ios-compilation-fcJh5
claude/serene-goldberg-58xv0
claude/kind-euler-LVG3K
release-automation/edge-nightly
7710-bundle-migrations
claude/fix-docker-build-error-WMfed
claude/llm-compatible-release-notes-t20Nr
7710-tests-tdd
cursor/transaction-table-rewrite-f077
claude/plan-ci-secure-context-OtEe1
claude/fix-issue-7667-DPXi3
cursor/resolve-pr-7449-ee11
claude/fix-typescript-build-error-JPtZ5
copilot/add-repository-configs-to-packages
worktree-compressed-drifting-ritchie
claude/api-consumer-verification-kfz1K
pr-7454
claude/fix-issue-7410-LLLQ4
revert-7281-generate-icons
react-query-useSchedules
copilot/sub-pr-6140
package-upgrades
v26.7.0
v26.6.0
v26.5.2
v26.5.1
v26.5.0
v26.4.0
v26.3.0
v26.2.1
v26.2.0
v26.1.0
v25.12.0
v25.11.0
v25.10.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.1
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.1
v25.2.0
v25.1.0
v24.12.0
v24.11.0
v24.10.1
v24.10.0
v24.9.0
v24.8.0
v24.7.0
v24.6.0
v24.5.0
v24.4.0
v24.3.0
v24.2.0
v24.1.0
v23.12.0
v23.11.0
v23.10.0
v23.9.0
v23.8.1
v23.8.0
v23.7.2
v23.7.1
v23.7.0
v23.6.0
v23.5.0
v23.4.2
v23.4.1
v23.4.0
v23.3.2
v23.3.0
v23.2.9
v23.2.5
v23.1.12
v22.12.9
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
Mirrored from GitHub Pull Request
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#127045
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/actualbudget/actual/pull/8106
Author: @alecbakholdin
Created: 6/6/2026
Status: 🔄 Open
Base:
master← Head:improved-context-menu📝 Commits (10+)
8ce423dContext Menu is implementedc30752fallow Document and Window in ref event listener hookf86a862did stupid examples to showcase api usage2543c79recreated TransactionMenu using new context actionf42f7b3fixed styling and removed excess calls to useContextMenuActione4f7dcaremoved extra call37d7042extra imports2d7e38estarted converting files to useContextMenu4b1c065fixed context menus in reportsf14b5b2linting and formatting📊 Changes
61 files changed (+1303 additions, -1324 deletions)
View changed files
📝
.oxlintrc.json(+1 -1)📝
packages/component-library/src/Menu.tsx(+1 -0)📝
packages/desktop-client/e2e/accounts.test.ts(+20 -0)📝
packages/desktop-client/e2e/budget.test.ts(+23 -0)📝
packages/desktop-client/e2e/page-models/account-page.ts(+4 -0)📝
packages/desktop-client/e2e/page-models/budget-page.ts(+15 -0)📝
packages/desktop-client/e2e/page-models/navigation.ts(+10 -0)📝
packages/desktop-client/e2e/page-models/payees-page.ts(+8 -0)📝
packages/desktop-client/e2e/page-models/reports-page.ts(+6 -0)📝
packages/desktop-client/e2e/page-models/rules-page.ts(+8 -0)📝
packages/desktop-client/e2e/page-models/schedules-page.ts(+4 -0)📝
packages/desktop-client/e2e/payees.test.ts(+10 -0)📝
packages/desktop-client/e2e/reports.test.ts(+7 -0)📝
packages/desktop-client/e2e/rules.test.ts(+8 -0)📝
packages/desktop-client/e2e/schedules.test.ts(+15 -0)➖
packages/desktop-client/e2e/tsconfig.json(+0 -9)📝
packages/desktop-client/package.json(+1 -0)➕
packages/desktop-client/src/components/ContextMenu.tsx(+81 -0)📝
packages/desktop-client/src/components/FinancesApp.tsx(+2 -0)📝
packages/desktop-client/src/components/budget/SidebarCategory.tsx(+21 -40)...and 41 more files
📄 Description
Description
This PR introduces a new global
ContextMenu.tsxcomponent designed to dramatically reduce code duplication when implementing right-click context menus, and migrates the dashboard report cards and several major lists to utilize it.Key Changes & Benefits:
ContextMenu: Created a centralizedContextMenu.tsxsystem utilizing auseContextMenuActionhook, allowing nested components to synchronously register contextual actions that are rendered in a single, globally-managed popover.TransactionsTable, we can now define row-level actions while simultaneously defining cell-specific actions (like right-clicking a category cell to "Add to Filter").ref, completely removing the need to drillmenuItemsarrays down through multiple layers of components.ReportCard: UpdatedReportCard.tsxto handle standard actions (Rename, Remove, Copy) internally driven by awidgetIdprop. This eliminated repetitive boilerplate and custom popover state management from every single child dashboard card (NetWorthCard,CashFlowCard,SpendingCard, etc.).Global stuff
packages/desktop-client/src/components/ContextMenu.tsx(New)packages/desktop-client/src/components/FinancesApp.tsxSwitched to using new hook
packages/desktop-client/src/components/budget/SidebarGroup.tsxpackages/desktop-client/src/components/payees/PayeeTableRow.tsxpackages/desktop-client/src/components/rules/RuleRow.tsxpackages/desktop-client/src/components/schedules/SchedulesTable.tsxpackages/desktop-client/src/components/sidebar/Account.tsxpackages/desktop-client/src/components/sidebar/BudgetName.tsxpackages/desktop-client/src/components/table.tsxpackages/desktop-client/src/components/tags/ManageTags.tsxpackages/desktop-client/src/components/tags/TagRow.tsxpackages/desktop-client/src/components/tags/TagsList.tsxpackages/desktop-client/src/components/transactions/TransactionsTable.tsxpackages/desktop-client/src/components/transactions/useTransactionRowContextActions.tsReport card refactor
packages/desktop-client/src/components/reports/Overview.tsxpackages/desktop-client/src/components/reports/ReportCard.tsxpackages/desktop-client/src/components/reports/reports/*(All 14 report cards migrated)Related issue(s)
Refactoring / Tech Debt. Addresses code duplication around context menus, standardizes context menu functionality across the application, and enables nested context support.
I can also imagine this being useful for the table refactor. One thing that would make the table easier to work with in the future is keeping functionality as local as possible. This hook helps accomplish that by allowing someone to specify a context action as close to the source as possible.
Testing
ref.Checklist
Bundle Stats
View detailed bundle stats
desktop-client
Total
Changeset
node_modules/lodash/lodash.jssrc/components/transactions/useTransactionRowContextActions.tssrc/components/ContextMenu.tsxsrc/contextmenu/contextMenuSlice.tshome/runner/work/actual/actual/packages/loot-core/src/shared/platform.tssrc/components/reports/ReportCard.tsxsrc/components/budget/envelope/budgetsummary/ToBudget.tsxsrc/hooks/useContextMenu.tssrc/components/budget/envelope/EnvelopeBudgetComponents.tsxsrc/components/budget/SidebarGroup.tsxsrc/redux/store.tssrc/components/sidebar/Account.tsxsrc/components/FinancesApp.tsxpackage.jsonhome/runner/work/actual/actual/packages/component-library/src/Menu.tsxsrc/components/table.tsxnode_modules/react-hotkeys-hook/dist/index.jssrc/components/autocomplete/CategoryAutocomplete.tsxsrc/components/tags/TagRow.tsxsrc/components/transactions/TransactionsTable.tsxsrc/components/tags/ManageTags.tsxsrc/hooks/useInputRefValue.tssrc/components/payees/PayeeTableRow.tsxsrc/components/reports/reports/CalendarCard.tsxsrc/hooks/useRefEventListener.tssrc/components/reports/reports/BalanceForecastCard.tsxsrc/components/reports/reports/MarkdownCard.tsxsrc/components/schedules/SchedulesTable.tsxsrc/components/tags/TagsList.tsxsrc/components/reports/Overview.tsxsrc/components/reports/reports/SankeyCard.tsxsrc/hooks/useCursorPosition.tssrc/components/reports/reports/CrossoverCard.tsxsrc/components/reports/reports/CashFlowCard.tsxsrc/tags/mutations.tssrc/components/reports/reports/AgeOfMoneyCard.tsxsrc/components/reports/reports/CustomReportListCards.tsxsrc/components/reports/reports/SpendingCard.tsxsrc/components/rules/RuleRow.tsxsrc/components/reports/reports/NetWorthCard.tsxsrc/components/budget/SidebarCategory.tsxsrc/components/reports/reports/BudgetAnalysisCard.tsxsrc/components/reports/reports/FormulaCard.tsxsrc/components/reports/reports/SummaryCard.tsxsrc/components/sidebar/BudgetName.tsxsrc/components/reports/reports/MissingReportCard.tsxsrc/components/transactions/TransactionMenu.tsxsrc/components/reports/useDashboardWidgetCopyMenu.tsView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Smaller
Unchanged
loot-core
Total
Changeset
home/runner/work/actual/actual/packages/loot-core/src/shared/platform.tsView detailed bundle breakdown
Added
Removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
No assets were unchanged
api
Total
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
cli
Total
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
crdt
Total
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.