[PR #8021] Per budget file bank Sync #126987

Open
opened 2026-06-14 06:29:17 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8021
Author: @lelemm
Created: 6/1/2026
Status: 🔄 Open

Base: masterHead: feat/bank-sync-per-budget-file


📝 Commits (10+)

📊 Changes

53 files changed (+2240 additions, -674 deletions)

View changed files

📝 packages/desktop-client/src/accounts/mutations.ts (+45 -1)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx (+9 -3)
📝 packages/desktop-client/src/components/banksync/AccountsList.tsx (+0 -2)
📝 packages/desktop-client/src/components/banksync/BuiltInProviders.tsx (+42 -4)
📝 packages/desktop-client/src/components/banksync/index.tsx (+5 -4)
📝 packages/desktop-client/src/components/banksync/useBuiltInBankSyncProviders.ts (+207 -95)
📝 packages/desktop-client/src/components/modals/AkahuInitialiseModal.tsx (+62 -14)
📝 packages/desktop-client/src/components/modals/EnableBankingExternalMsgModal.tsx (+14 -10)
📝 packages/desktop-client/src/components/modals/EnableBankingInitialiseModal.tsx (+30 -0)
📝 packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.test.tsx (+2 -1)
📝 packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.tsx (+15 -8)
📝 packages/desktop-client/src/components/modals/GoCardlessInitialiseModal.tsx (+43 -12)
📝 packages/desktop-client/src/components/modals/PluggyAiInitialiseModal.tsx (+65 -26)
📝 packages/desktop-client/src/components/modals/SimpleFinInitialiseModal.tsx (+30 -0)
📝 packages/desktop-client/src/enablebanking.ts (+6 -0)
📝 packages/desktop-client/src/gocardless.ts (+7 -0)
📝 packages/desktop-client/src/hooks/useAkahuStatus.ts (+18 -14)
📝 packages/desktop-client/src/hooks/useEnableBankingStatus.ts (+21 -20)
📝 packages/desktop-client/src/hooks/useGoCardlessStatus.ts (+16 -15)
📝 packages/desktop-client/src/hooks/usePluggyAiStatus.ts (+16 -15)

...and 33 more files

📄 Description

This PR enables bank sync per budget file.

Current behavior:

  • Bank sync is system wide. all budget files share same bank sync credentials

New behavior:

  • Bank sync is per budget file. For every new budget file, a new setup must be done

For existing credentials, it will fanout the current credentials to all files.

Tested:

  • Pluggy.ai
  • SimpleFin

Not tested (need feedback):

  • GoCardless
  • Enable banking

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 13.23 MB → 13.25 MB (+12.64 kB) +0.09%
loot-core 1 4.86 MB → 4.87 MB (+2.17 kB) +0.04%
api 2 3.87 MB → 3.87 MB (+2.06 kB) +0.05%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 13.23 MB → 13.25 MB (+12.64 kB) +0.09%
Changeset
File Δ Size
src/components/modals/AkahuInitialiseModal.tsx 📈 +1.71 kB (+37.37%) 4.57 kB → 6.28 kB
src/components/modals/SimpleFinInitialiseModal.tsx 📈 +1.17 kB (+32.65%) 3.59 kB → 4.76 kB
src/components/modals/GoCardlessInitialiseModal.tsx 📈 +1.18 kB (+24.65%) 4.79 kB → 5.97 kB
src/components/banksync/BuiltInProviders.tsx 📈 +1.56 kB (+23.86%) 6.53 kB → 8.09 kB
src/hooks/useEnableBankingStatus.ts 📈 +163 B (+22.03%) 740 B → 903 B
src/components/modals/PluggyAiInitialiseModal.tsx 📈 +1.24 kB (+21.16%) 5.86 kB → 7.1 kB
src/components/banksync/useBuiltInBankSyncProviders.ts 📈 +2.72 kB (+19.12%) 14.23 kB → 16.95 kB
src/hooks/useGoCardlessStatus.ts 📈 +108 B (+18.31%) 590 B → 698 B
src/hooks/useSimpleFinStatus.ts 📈 +104 B (+17.84%) 583 B → 687 B
src/hooks/usePluggyAiStatus.ts 📈 +100 B (+17.36%) 576 B → 676 B
src/hooks/useAkahuStatus.ts 📈 +99 B (+16.45%) 602 B → 701 B
src/components/modals/EnableBankingInitialiseModal.tsx 📈 +846 B (+15.11%) 5.47 kB → 6.29 kB
src/gocardless.ts 📈 +85 B (+9.33%) 911 B → 996 B
src/accounts/mutations.ts 📈 +892 B (+6.16%) 14.14 kB → 15.01 kB
src/enablebanking.ts 📈 +62 B (+2.77%) 2.19 kB → 2.25 kB
src/components/modals/GoCardlessExternalMsgModal.tsx 📈 +264 B (+2.33%) 11.05 kB → 11.31 kB
src/components/modals/EnableBankingExternalMsgModal.tsx 📈 +248 B (+2.13%) 11.35 kB → 11.59 kB
src/components/accounts/AccountSyncCheck.tsx 📈 +158 B (+1.78%) 8.68 kB → 8.84 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 1.58 MB → 1.59 MB (+6.78 kB) +0.42%
static/js/SchedulesTable.js 203.52 kB → 208.5 kB (+4.98 kB) +2.45%
static/js/extends.js 473.99 kB → 475.21 kB (+1.21 kB) +0.26%

Smaller

Asset File Size % Changed
static/js/Value.js 4.49 MB → 4.49 MB (-352 B) -0.01%

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 814.39 kB 0%
static/js/ManageRules.js 46.47 kB 0%
static/js/PayeeRuleCountLabel.js 7.1 kB 0%
static/js/ReportRouter.js 1.25 MB 0%
static/js/ScheduleEditForm.js 146.51 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 82.8 kB 0%
static/js/_baseIsEqual.js 76.76 kB 0%
static/js/ca.js 185.63 kB 0%
static/js/client.js 450.92 kB 0%
static/js/da.js 100.19 kB 0%
static/js/de.js 182.38 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 202.14 kB 0%
static/js/es.js 177.58 kB 0%
static/js/fr.js 177.35 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 163.93 kB 0%
static/js/narrow.js 364.55 kB 0%
static/js/nb-NO.js 147.07 kB 0%
static/js/nl.js 119.71 kB 0%
static/js/pt-BR.js 187.34 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 173.33 kB 0%
static/js/theme.js 31.01 kB 0%
static/js/toString.js 638.95 kB 0%
static/js/uk.js 216.7 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 298.23 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.44 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.86 MB → 4.87 MB (+2.17 kB) +0.04%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts 📈 +1.42 kB (+4.78%) 29.84 kB → 31.26 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts 📈 +418 B (+1.65%) 24.8 kB → 25.21 kB
home/runner/work/actual/actual/packages/loot-core/src/server/api.ts 📈 +341 B (+1.42%) 23.51 kB → 23.84 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.ByaT4JtM.js 0 B → 4.87 MB (+4.87 MB) -

Removed

Asset File Size % Changed
kcab.worker.DhLbg59B.js 4.86 MB → 0 B (-4.86 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged


api

Total

Files count Total bundle size % Changed
2 3.87 MB → 3.87 MB (+2.06 kB) +0.05%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts 📈 +1.35 kB (+4.62%) 29.3 kB → 30.66 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts 📈 +397 B (+1.59%) 24.32 kB → 24.7 kB
home/runner/work/actual/actual/packages/loot-core/src/server/api.ts 📈 +326 B (+1.39%) 22.89 kB → 23.21 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.87 MB → 3.87 MB (+2.06 kB) +0.05%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8021 **Author:** [@lelemm](https://github.com/lelemm) **Created:** 6/1/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `feat/bank-sync-per-budget-file` --- ### 📝 Commits (10+) - [`a978676`](https://github.com/actualbudget/actual/commit/a97867688500dfe2ef0d54789209ac915f26231d) Per budget file bank Sync - [`6a09a87`](https://github.com/actualbudget/actual/commit/6a09a87242f0fff3112afaa92d43c19f7cef9b33) code review - [`d2adc2e`](https://github.com/actualbudget/actual/commit/d2adc2e05a0b42507e8f88459a0d032949c8752a) code review - [`f779f56`](https://github.com/actualbudget/actual/commit/f779f56f97c8e0f635d86dfa9e4a72218a4a8d01) Update VRT screenshots - [`3bd37a7`](https://github.com/actualbudget/actual/commit/3bd37a723f0fae35a738b3310ac70ec3de6084e8) e2e errors - [`e554009`](https://github.com/actualbudget/actual/commit/e554009ffd4462a174bebc7069db9d36afaf8bf0) Update VRT screenshots - [`7631939`](https://github.com/actualbudget/actual/commit/76319398fabf54c9371fd929cfb5f49f7472d346) attempt to fix e2e and bring enable banking to per budget bank sync - [`bfb0c93`](https://github.com/actualbudget/actual/commit/bfb0c9366c8a27443e4d5115dcc2a23bbfc7865e) fix on tests - [`912972f`](https://github.com/actualbudget/actual/commit/912972f7d1acc64c2120ee51db0b592a6207d600) [autofix.ci] apply automated fixes - [`34fa227`](https://github.com/actualbudget/actual/commit/34fa227d3b2f4f3b2d934ad4efd97f77cb0bdee3) Update VRT screenshots ### 📊 Changes **53 files changed** (+2240 additions, -674 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/accounts/mutations.ts` (+45 -1) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx` (+9 -3) 📝 `packages/desktop-client/src/components/banksync/AccountsList.tsx` (+0 -2) 📝 `packages/desktop-client/src/components/banksync/BuiltInProviders.tsx` (+42 -4) 📝 `packages/desktop-client/src/components/banksync/index.tsx` (+5 -4) 📝 `packages/desktop-client/src/components/banksync/useBuiltInBankSyncProviders.ts` (+207 -95) 📝 `packages/desktop-client/src/components/modals/AkahuInitialiseModal.tsx` (+62 -14) 📝 `packages/desktop-client/src/components/modals/EnableBankingExternalMsgModal.tsx` (+14 -10) 📝 `packages/desktop-client/src/components/modals/EnableBankingInitialiseModal.tsx` (+30 -0) 📝 `packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.test.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.tsx` (+15 -8) 📝 `packages/desktop-client/src/components/modals/GoCardlessInitialiseModal.tsx` (+43 -12) 📝 `packages/desktop-client/src/components/modals/PluggyAiInitialiseModal.tsx` (+65 -26) 📝 `packages/desktop-client/src/components/modals/SimpleFinInitialiseModal.tsx` (+30 -0) 📝 `packages/desktop-client/src/enablebanking.ts` (+6 -0) 📝 `packages/desktop-client/src/gocardless.ts` (+7 -0) 📝 `packages/desktop-client/src/hooks/useAkahuStatus.ts` (+18 -14) 📝 `packages/desktop-client/src/hooks/useEnableBankingStatus.ts` (+21 -20) 📝 `packages/desktop-client/src/hooks/useGoCardlessStatus.ts` (+16 -15) 📝 `packages/desktop-client/src/hooks/usePluggyAiStatus.ts` (+16 -15) _...and 33 more files_ </details> ### 📄 Description This PR enables bank sync per budget file. Current behavior: - Bank sync is system wide. all budget files share same bank sync credentials New behavior: - Bank sync is per budget file. For every new budget file, a new setup must be done For existing credentials, it will fanout the current credentials to all files. Tested: - Pluggy.ai - SimpleFin Not tested (need feedback): - GoCardless - Enable banking <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 13.23 MB → 13.25 MB (+12.64 kB) | +0.09% loot-core | 1 | 4.86 MB → 4.87 MB (+2.17 kB) | +0.04% api | 2 | 3.87 MB → 3.87 MB (+2.06 kB) | +0.05% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 13.23 MB → 13.25 MB (+12.64 kB) | +0.09% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/modals/AkahuInitialiseModal.tsx` | 📈 +1.71 kB (+37.37%) | 4.57 kB → 6.28 kB `src/components/modals/SimpleFinInitialiseModal.tsx` | 📈 +1.17 kB (+32.65%) | 3.59 kB → 4.76 kB `src/components/modals/GoCardlessInitialiseModal.tsx` | 📈 +1.18 kB (+24.65%) | 4.79 kB → 5.97 kB `src/components/banksync/BuiltInProviders.tsx` | 📈 +1.56 kB (+23.86%) | 6.53 kB → 8.09 kB `src/hooks/useEnableBankingStatus.ts` | 📈 +163 B (+22.03%) | 740 B → 903 B `src/components/modals/PluggyAiInitialiseModal.tsx` | 📈 +1.24 kB (+21.16%) | 5.86 kB → 7.1 kB `src/components/banksync/useBuiltInBankSyncProviders.ts` | 📈 +2.72 kB (+19.12%) | 14.23 kB → 16.95 kB `src/hooks/useGoCardlessStatus.ts` | 📈 +108 B (+18.31%) | 590 B → 698 B `src/hooks/useSimpleFinStatus.ts` | 📈 +104 B (+17.84%) | 583 B → 687 B `src/hooks/usePluggyAiStatus.ts` | 📈 +100 B (+17.36%) | 576 B → 676 B `src/hooks/useAkahuStatus.ts` | 📈 +99 B (+16.45%) | 602 B → 701 B `src/components/modals/EnableBankingInitialiseModal.tsx` | 📈 +846 B (+15.11%) | 5.47 kB → 6.29 kB `src/gocardless.ts` | 📈 +85 B (+9.33%) | 911 B → 996 B `src/accounts/mutations.ts` | 📈 +892 B (+6.16%) | 14.14 kB → 15.01 kB `src/enablebanking.ts` | 📈 +62 B (+2.77%) | 2.19 kB → 2.25 kB `src/components/modals/GoCardlessExternalMsgModal.tsx` | 📈 +264 B (+2.33%) | 11.05 kB → 11.31 kB `src/components/modals/EnableBankingExternalMsgModal.tsx` | 📈 +248 B (+2.13%) | 11.35 kB → 11.59 kB `src/components/accounts/AccountSyncCheck.tsx` | 📈 +158 B (+1.78%) | 8.68 kB → 8.84 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.58 MB → 1.59 MB (+6.78 kB) | +0.42% static/js/SchedulesTable.js | 203.52 kB → 208.5 kB (+4.98 kB) | +2.45% static/js/extends.js | 473.99 kB → 475.21 kB (+1.21 kB) | +0.26% **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/Value.js | 4.49 MB → 4.49 MB (-352 B) | -0.01% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 814.39 kB | 0% static/js/ManageRules.js | 46.47 kB | 0% static/js/PayeeRuleCountLabel.js | 7.1 kB | 0% static/js/ReportRouter.js | 1.25 MB | 0% static/js/ScheduleEditForm.js | 146.51 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 82.8 kB | 0% static/js/_baseIsEqual.js | 76.76 kB | 0% static/js/ca.js | 185.63 kB | 0% static/js/client.js | 450.92 kB | 0% static/js/da.js | 100.19 kB | 0% static/js/de.js | 182.38 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 202.14 kB | 0% static/js/es.js | 177.58 kB | 0% static/js/fr.js | 177.35 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 163.93 kB | 0% static/js/narrow.js | 364.55 kB | 0% static/js/nb-NO.js | 147.07 kB | 0% static/js/nl.js | 119.71 kB | 0% static/js/pt-BR.js | 187.34 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 173.33 kB | 0% static/js/theme.js | 31.01 kB | 0% static/js/toString.js | 638.95 kB | 0% static/js/uk.js | 216.7 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 298.23 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.44 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.86 MB → 4.87 MB (+2.17 kB) | +0.04% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts` | 📈 +1.42 kB (+4.78%) | 29.84 kB → 31.26 kB `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts` | 📈 +418 B (+1.65%) | 24.8 kB → 25.21 kB `home/runner/work/actual/actual/packages/loot-core/src/server/api.ts` | 📈 +341 B (+1.42%) | 23.51 kB → 23.84 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.ByaT4JtM.js | 0 B → 4.87 MB (+4.87 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DhLbg59B.js | 4.86 MB → 0 B (-4.86 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.87 MB → 3.87 MB (+2.06 kB) | +0.05% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts` | 📈 +1.35 kB (+4.62%) | 29.3 kB → 30.66 kB `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts` | 📈 +397 B (+1.59%) | 24.32 kB → 24.7 kB `home/runner/work/actual/actual/packages/loot-core/src/server/api.ts` | 📈 +326 B (+1.39%) | 22.89 kB → 23.21 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.87 MB → 3.87 MB (+2.06 kB) | +0.05% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-14 06:29:17 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#126987