github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-21 06:31:58 -05:00
Code Issues 2.1k Packages Projects Releases 57 Wiki Activity

[PR #4862] [MERGED] Move some .d.ts files to .ts #12684

New Issue
Closed
opened 2026-04-10 21:36:44 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 21:36:44 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4862
Author: @jfdoming
Created: 4/20/2025
Status: ✅ Merged
Merged: 4/21/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/move-d-ts-1

📝 Commits (3)

📊 Changes

25 files changed (+17 additions, -9 deletions)

View changed files

📝 packages/loot-core/src/server/main.ts (+1 -1)
📝 packages/loot-core/src/server/transactions/index.ts (+1 -0)
📝 packages/loot-core/src/types/api-handlers.ts (+3 -2)
📝 packages/loot-core/src/types/budget.ts (+0 -0)
📝 packages/loot-core/src/types/file.ts (+0 -0)
📝 packages/loot-core/src/types/handlers.ts (+0 -0)
📝 packages/loot-core/src/types/models/bank-sync.ts (+0 -0)
📝 packages/loot-core/src/types/models/category-group.ts (+0 -0)
📝 packages/loot-core/src/types/models/category.ts (+0 -0)
📝 packages/loot-core/src/types/models/dashboard.ts (+1 -1)
📝 packages/loot-core/src/types/models/gocardless.ts (+0 -0)
📝 packages/loot-core/src/types/models/index.ts (+0 -0)
📝 packages/loot-core/src/types/models/note.ts (+0 -0)
📝 packages/loot-core/src/types/models/openid.ts (+0 -0)
📝 packages/loot-core/src/types/models/payee.ts (+0 -0)
📝 packages/loot-core/src/types/models/reports.ts (+1 -1)
📝 packages/loot-core/src/types/models/rule.ts (+0 -0)
📝 packages/loot-core/src/types/models/schedule.ts (+0 -0)
📝 packages/loot-core/src/types/models/simplefin.ts (+1 -1)
📝 packages/loot-core/src/types/models/transaction-filter.ts (+0 -0)

...and 5 more files

📄 Description

A while back I discovered our .d.ts files were not being type checked due to skipLibCheck: true in our tsconfig. That can allow type errors to sneak in. This PR moves a bunch of files from .d.ts to .ts with the hope we can eventually ban .d.ts files altogether. (We can't just set skipLibCheck to false because then all our node_modules will be checked, and we have many conflicting dependencies there.)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4862 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 4/20/2025 **Status:** ✅ Merged **Merged:** 4/21/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/move-d-ts-1` --- ### 📝 Commits (3) - [`e161b77`](https://github.com/actualbudget/actual/commit/e161b77594c2e71535cd4733f88bd5f2f236b36b) Move loot-core types to `.ts` - [`dda62cd`](https://github.com/actualbudget/actual/commit/dda62cddcdcad396812bdd542de095d2926f3215) Add release notes - [`3564ef2`](https://github.com/actualbudget/actual/commit/3564ef2d5bb821398d01d8b79371c148a5964821) PR feedback ### 📊 Changes **25 files changed** (+17 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/main.ts` (+1 -1) 📝 `packages/loot-core/src/server/transactions/index.ts` (+1 -0) 📝 `packages/loot-core/src/types/api-handlers.ts` (+3 -2) 📝 `packages/loot-core/src/types/budget.ts` (+0 -0) 📝 `packages/loot-core/src/types/file.ts` (+0 -0) 📝 `packages/loot-core/src/types/handlers.ts` (+0 -0) 📝 `packages/loot-core/src/types/models/bank-sync.ts` (+0 -0) 📝 `packages/loot-core/src/types/models/category-group.ts` (+0 -0) 📝 `packages/loot-core/src/types/models/category.ts` (+0 -0) 📝 `packages/loot-core/src/types/models/dashboard.ts` (+1 -1) 📝 `packages/loot-core/src/types/models/gocardless.ts` (+0 -0) 📝 `packages/loot-core/src/types/models/index.ts` (+0 -0) 📝 `packages/loot-core/src/types/models/note.ts` (+0 -0) 📝 `packages/loot-core/src/types/models/openid.ts` (+0 -0) 📝 `packages/loot-core/src/types/models/payee.ts` (+0 -0) 📝 `packages/loot-core/src/types/models/reports.ts` (+1 -1) 📝 `packages/loot-core/src/types/models/rule.ts` (+0 -0) 📝 `packages/loot-core/src/types/models/schedule.ts` (+0 -0) 📝 `packages/loot-core/src/types/models/simplefin.ts` (+1 -1) 📝 `packages/loot-core/src/types/models/transaction-filter.ts` (+0 -0) _...and 5 more files_ </details> ### 📄 Description A while back I discovered our .d.ts files were not being type checked due to `skipLibCheck: true` in our tsconfig. That can allow type errors to sneak in. This PR moves a bunch of files from .d.ts to .ts with the hope we can eventually ban .d.ts files altogether. (We can't just set `skipLibCheck` to false because then all our `node_modules` will be checked, and we have many conflicting dependencies there.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 21:36:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#12684
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?