github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 15:14:02 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7814] [MERGED] Fix split transaction popover wrapping #126838

New Issue
Closed
opened 2026-06-14 06:16:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-14 06:16:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7814
Author: @impetus82
Created: 5/12/2026
Status: ✅ Merged
Merged: 5/13/2026
Merged by: @matt-fidd

Base: master ← Head: fix-split-popup-layout

📝 Commits (3)

  • 92e5704 Fix split transaction popover wrapping
  • bcee4b2 Add release note for split popover fix
  • 56e210c Uncap split popover width

📊 Changes

2 files changed (+10 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+4 -4)
➕ upcoming-release-notes/7814.md (+6 -0)

📄 Description

Summary

  • removes the fixed 38px max height from the split transaction error popover
  • allows the error row to wrap when translated button labels need more space
  • replaces fixed left margins between controls with a small gap

Notes

This targets the issue where the split transaction popover can show scrollbars or hide buttons with longer translated labels, especially in German/high-DPI layouts.

Verification

  • git diff --check
  • Not run: full app build/test. This workspace uses a sparse checkout because cloning the full repository repeatedly hit network resets.

Fixes #7738

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 33 13.91 MB → 13.91 MB (-189 B) -0.00%
loot-core 1 5.31 MB 0%
api 2 3.94 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
33 13.91 MB → 13.91 MB (-189 B) -0.00%
Changeset
File Δ Size
src/components/transactions/TransactionsTable.tsx 📉 -189 B (-0.21%) 88.46 kB → 88.28 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller

Asset File Size % Changed
static/js/Value.js 4.96 MB → 4.96 MB (-189 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/index.js 1.97 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ReportRouter.js 1.22 MB 0%
static/js/ScheduleEditForm.js 146.45 kB 0%
static/js/TransactionEdit.js 190.43 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/bankSyncUtils.js 54.15 kB 0%
static/js/ca.js 187.76 kB 0%
static/js/chart-theme.js 800.08 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.28 kB 0%
static/js/de.js 170.42 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 190.1 kB 0%
static/js/es.js 178.87 kB 0%
static/js/extends.js 519.29 kB 0%
static/js/fr.js 178.76 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.17 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.23 kB 0%
static/js/nl.js 106.39 kB 0%
static/js/pt-BR.js 189.45 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.62 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 207.63 kB 0%
static/js/useFormatList.js 4.96 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.79 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.31 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.Cozwd3bP.js 5.31 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.94 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.94 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7814 **Author:** [@impetus82](https://github.com/impetus82) **Created:** 5/12/2026 **Status:** ✅ Merged **Merged:** 5/13/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `fix-split-popup-layout` --- ### 📝 Commits (3) - [`92e5704`](https://github.com/actualbudget/actual/commit/92e57043a3a26fa0974afed5b77a3b5c3ee63fe0) Fix split transaction popover wrapping - [`bcee4b2`](https://github.com/actualbudget/actual/commit/bcee4b24c36f43c203afd6fe172905753adc76f9) Add release note for split popover fix - [`56e210c`](https://github.com/actualbudget/actual/commit/56e210c297ccf858ca9f7484c62897f63da43e33) Uncap split popover width ### 📊 Changes **2 files changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+4 -4) ➕ `upcoming-release-notes/7814.md` (+6 -0) </details> ### 📄 Description ## Summary - removes the fixed 38px max height from the split transaction error popover - allows the error row to wrap when translated button labels need more space - replaces fixed left margins between controls with a small `gap` ## Notes This targets the issue where the split transaction popover can show scrollbars or hide buttons with longer translated labels, especially in German/high-DPI layouts. ## Verification - `git diff --check` - Not run: full app build/test. This workspace uses a sparse checkout because cloning the full repository repeatedly hit network resets. Fixes #7738 <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 33 | 13.91 MB → 13.91 MB (-189 B) | -0.00% loot-core | 1 | 5.31 MB | 0% api | 2 | 3.94 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 33 | 13.91 MB → 13.91 MB (-189 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/transactions/TransactionsTable.tsx` | 📉 -189 B (-0.21%) | 88.46 kB → 88.28 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/Value.js | 4.96 MB → 4.96 MB (-189 B) | -0.00% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.97 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ReportRouter.js | 1.22 MB | 0% static/js/ScheduleEditForm.js | 146.45 kB | 0% static/js/TransactionEdit.js | 190.43 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/bankSyncUtils.js | 54.15 kB | 0% static/js/ca.js | 187.76 kB | 0% static/js/chart-theme.js | 800.08 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.28 kB | 0% static/js/de.js | 170.42 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 190.1 kB | 0% static/js/es.js | 178.87 kB | 0% static/js/extends.js | 519.29 kB | 0% static/js/fr.js | 178.76 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.17 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.23 kB | 0% static/js/nl.js | 106.39 kB | 0% static/js/pt-BR.js | 189.45 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.62 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 207.63 kB | 0% static/js/useFormatList.js | 4.96 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.79 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.31 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.Cozwd3bP.js | 5.31 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.94 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.94 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-14 06:16:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#126838
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?