mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-11 11:59:55 -05:00
Closed
opened 2026-06-14 05:27:34 -05:00 by GiteaMirror
·
0 comments
No Branch/Tag Specified
master
tabedzki/feat/replacing-month-picker-with-day-picker
enforce-append-only-migrations-ci
delay-initial-sync-until-loaded
jfdoming/mobile-app-build
claude/error-codes-worker-boundary-26i5uu
jfdoming/api-tokens-part-1
jfdoming/api-tokens-part-2
jfdoming/api-tokens-part-3
jfdoming/mobile-app-updates
ai/simplify-categories-get-api
api-browser-custom-data-dir
claude/budget-version-migration-compat-151jlr
claude/worker-error-serialization-9iqtl7
claude/react-table-library-research-afx83z
claude/issue-8401-regression-test-9nw9l3
jfdoming/mobile-app-foundation-part-1
jfdoming/mobile-app-scaffold
release
ai-fix-cleanup-def-8290
claude/relaxed-shannon-jusywa
claude/fervent-keller-s6f2fq
claude/determined-feynman-st1y9z
claude/wizardly-einstein-vi2wce
claude/sweet-albattani-7nseio
feat/bank-sync-per-budget-file
claude/affectionate-cannon-y0kc82
claude/dependabot-findings-m9pgmb
claude/mac-app-ios-publish-zjs1lz
claude/vigilant-tesla-aiiyos
depot-migrate-secrets-1781296330308
claude/quirky-cerf-v5qck7
claude/animation-removal-alternative-2etfh1
claude/netlify-preview-comments-consolidate-9XPYa
osc/7391-error-boundaries-reports
claude/pensive-dijkstra-7DYui
claude/server-app-version-mismatch-HTCGv
claude/pr-8027-review-feedback-mELuO
claude/zealous-wozniak-e5pO0
claude/intelligent-heisenberg-BSHJq
claude/translation-download-refactor-jFRsO
claude/mobile-performance-ideas-G9PAO
claude/github-issue-7988-5A5ly
blacksmith-migration-ff70d2d
claude/great-mayer-KRvOk
claude/react-native-ios-compilation-fcJh5
claude/serene-goldberg-58xv0
claude/kind-euler-LVG3K
release-automation/edge-nightly
7710-bundle-migrations
claude/fix-docker-build-error-WMfed
claude/llm-compatible-release-notes-t20Nr
7710-tests-tdd
cursor/transaction-table-rewrite-f077
claude/plan-ci-secure-context-OtEe1
claude/fix-issue-7667-DPXi3
cursor/resolve-pr-7449-ee11
claude/fix-typescript-build-error-JPtZ5
copilot/add-repository-configs-to-packages
worktree-compressed-drifting-ritchie
claude/api-consumer-verification-kfz1K
pr-7454
claude/fix-issue-7410-LLLQ4
revert-7281-generate-icons
react-query-useSchedules
copilot/sub-pr-6140
package-upgrades
v26.7.0
v26.6.0
v26.5.2
v26.5.1
v26.5.0
v26.4.0
v26.3.0
v26.2.1
v26.2.0
v26.1.0
v25.12.0
v25.11.0
v25.10.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.1
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.1
v25.2.0
v25.1.0
v24.12.0
v24.11.0
v24.10.1
v24.10.0
v24.9.0
v24.8.0
v24.7.0
v24.6.0
v24.5.0
v24.4.0
v24.3.0
v24.2.0
v24.1.0
v23.12.0
v23.11.0
v23.10.0
v23.9.0
v23.8.1
v23.8.0
v23.7.2
v23.7.1
v23.7.0
v23.6.0
v23.5.0
v23.4.2
v23.4.1
v23.4.0
v23.3.2
v23.3.0
v23.2.9
v23.2.5
v23.1.12
v22.12.9
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
Mirrored from GitHub Pull Request
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#126270
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/actualbudget/actual/pull/6954
Author: @StephenBrown2
Created: 2/12/2026
Status: ❌ Closed
Base:
master← Head:push-woswwuqwuwru📝 Commits (2)
945ea93[AI] feat(currency): honor per-currency decimal places across core and UIa74fe75Update VRT screenshots workflow📊 Changes
62 files changed (+1395 additions, -208 deletions)
View changed files
📝
.github/workflows/e2e-vrt-comment.yml(+64 -1)📝
.github/workflows/vrt-update-generate.yml(+24 -3)📝
.gitignore(+1 -0)📝
package.json(+1 -0)📝
packages/desktop-client/README.md(+3 -0)➕
packages/desktop-client/bin/prune-vrt-snapshots.mjs(+61 -0)📝
packages/desktop-client/e2e/accounts.test.ts(+47 -14)📝
packages/desktop-client/e2e/budget.test.ts(+25 -0)➕
packages/desktop-client/e2e/currency-precision.ts(+153 -0)📝
packages/desktop-client/e2e/fixtures.ts(+48 -1)📝
packages/desktop-client/e2e/onboarding.test.ts(+9 -0)📝
packages/desktop-client/e2e/page-models/settings-page.ts(+73 -5)➕
packages/desktop-client/e2e/playwright-env.ts(+10 -0)📝
packages/desktop-client/e2e/transactions.test.ts(+109 -0)📝
packages/desktop-client/package.json(+1 -0)📝
packages/desktop-client/src/accounts/mutations.ts(+8 -1)📝
packages/desktop-client/src/components/accounts/Account.tsx(+21 -0)📝
packages/desktop-client/src/components/accounts/BalanceHistoryGraph.tsx(+6 -2)📝
packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx(+9 -2)📝
packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx(+10 -2)...and 42 more files
📄 Description
Sorry for yet another PR, but I noticed that Vietnamese Dong got added with the wrong decimal places, due to the longstanding issue with not handling other than 2 decimal places.
I originally included sync-server adapter work here, but that was decided to be out of scope, so this PR now focuses on desktop-client + loot-core currency precision only.
Summary
This PR fixes the "everything assumes 2 decimal places" problem.
Amounts now use each currency's
decimalPlacesacross account creation, transaction editing/table flows, search/formula paths, and budget-related UI code. This avoids the x10/x100/x1000 inflation issues when using zero-decimal or three-decimal currencies.I also corrected VND metadata to use
decimalPlaces: 0.IMPORTANT: If this is merged and released at the same time as #6902, there will be no db migration needed. If after, a DB migration MAY be needed to fix the 100x issue on existing values.
Tests added/updated
packages/desktop-client/src/components/transactions/table/utils.test.ts)integerToCurrencyWithDecimalappendDecimals(packages/loot-core/src/shared/util.test.ts)JPY,VND):packages/desktop-client/e2e/accounts.test.ts)Issues addressed
This PR is aimed at the non-2-decimal currency requests:
Test plan
yarn testyarn typecheckJPY/VND)AI assistance
This change was made with the help of GPT-5.3 Codex.
Bundle Stats
View detailed bundle stats
desktop-client
Total
Changeset
src/components/mobile/transactions/FocusableAmountInput.tsxsrc/components/transactions/table/utils.tshome/runner/work/actual/actual/packages/loot-core/src/shared/util.tssrc/queries/index.tssrc/hooks/useTransactionsSearch.tshome/runner/work/actual/actual/packages/loot-core/src/shared/currencies.tssrc/components/budget/envelope/CoverMenu.tsxsrc/components/modals/EditFieldModal.tsxsrc/components/modals/TrackingBudgetMenuModal.tsxsrc/components/modals/EnvelopeBudgetMenuModal.tsxsrc/components/modals/CreateLocalAccountModal.tsxsrc/components/autocomplete/CategoryAutocomplete.tsxpackage.jsonsrc/components/mobile/transactions/TransactionListItem.tsxsrc/components/settings/Currency.tsxsrc/components/budget/BalanceWithCarryover.tsxsrc/components/mobile/transactions/TransactionEdit.tsxsrc/components/accounts/BalanceHistoryGraph.tsxsrc/components/modals/CloseAccountModal.tsxsrc/hooks/useFormulaExecution.tssrc/components/accounts/Account.tsxsrc/components/transactions/TransactionsTable.tsxhome/runner/work/actual/actual/packages/loot-core/src/server/rules/customFunctions.tssrc/components/mobile/transactions/TransactionList.tsxsrc/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsxsrc/components/budget/util.tssrc/accounts/mutations.tsView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Smaller
No assets were smaller
Unchanged
loot-core
Total
Changeset
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/export/export-to-csv.tshome/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab5.tshome/runner/work/actual/actual/packages/loot-core/src/shared/currencies.tshome/runner/work/actual/actual/packages/loot-core/src/shared/util.tshome/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.tshome/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab4.tshome/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.tshome/runner/work/actual/actual/packages/loot-core/src/server/api.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/schedule-template.tshome/runner/work/actual/actual/packages/loot-core/src/server/rules/customFunctions.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/category-template-context.tshome/runner/work/actual/actual/packages/loot-core/src/server/rules/action.tshome/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/actions.tsView detailed bundle breakdown
Added
Removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
No assets were unchanged
api
Total
Changeset
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/export/export-to-csv.tshome/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab5.tshome/runner/work/actual/actual/packages/loot-core/src/shared/currencies.tshome/runner/work/actual/actual/packages/loot-core/src/shared/util.tshome/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.tshome/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab4.tshome/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.tshome/runner/work/actual/actual/packages/loot-core/src/server/api.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/schedule-template.tshome/runner/work/actual/actual/packages/loot-core/src/server/rules/customFunctions.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/category-template-context.tshome/runner/work/actual/actual/packages/loot-core/src/server/rules/action.tshome/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/actions.tsView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Smaller
No assets were smaller
Unchanged
cli
Total
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.