github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6501] [MERGED] fix: Unsplit transaction without losing the parent’s data. #125999

New Issue
Closed
opened 2026-06-14 05:01:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-14 05:01:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6501
Author: @skliaruk
Created: 12/27/2025
Status: ✅ Merged
Merged: 1/6/2026
Merged by: @youngcw

Base: master ← Head: fix-unsplit

📝 Commits (4)

  • 771973b fix: Unsplit transaction without losing parent's transaction information (amount, notes, etc.)
  • 4794ff4 [autofix.ci] apply automated fixes
  • 9f49e8e fix: Refine conditional logic and update makeTransactionWithChildCategory to use Partial
  • 59586f4 fix: Correct child transaction reference in unsplit logic

📊 Changes

3 files changed (+58 additions, -0 deletions)

View changed files

📝 packages/loot-core/src/shared/transactions.test.ts (+26 -0)
📝 packages/loot-core/src/shared/transactions.ts (+26 -0)
➕ upcoming-release-notes/6501.md (+6 -0)

📄 Description

Fixed logic:

  • use the parent’s transaction with the child’s category for unsplit transactions to prevent data loss

Fixes #6271

Summary by CodeRabbit

  • Bug Fixes

    • Unsplit last remaining child transactions now correctly converts the parent into a regular transaction and preserves amount, category, notes, and related details when the final child is removed.
    • Ensures the final child is removed and the parent’s state is updated atomically to prevent orphaned or inconsistent data.

  • Tests

    • Added coverage verifying that unsplitting the final child updates the parent and deletes the child as expected.

✏️ Tip: You can customize this high-level summary in your review settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6501 **Author:** [@skliaruk](https://github.com/skliaruk) **Created:** 12/27/2025 **Status:** ✅ Merged **Merged:** 1/6/2026 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix-unsplit` --- ### 📝 Commits (4) - [`771973b`](https://github.com/actualbudget/actual/commit/771973ba0e37c37a3ac3ef3ec2a13df064748165) fix: Unsplit transaction without losing parent's transaction information (amount, notes, etc.) - [`4794ff4`](https://github.com/actualbudget/actual/commit/4794ff40055a43b3da2691d8e49e0ef4e4fb9cf1) [autofix.ci] apply automated fixes - [`9f49e8e`](https://github.com/actualbudget/actual/commit/9f49e8e336d8986efaa3c652d309c694a7076e40) fix: Refine conditional logic and update makeTransactionWithChildCategory to use Partial<TransactionEntity> - [`59586f4`](https://github.com/actualbudget/actual/commit/59586f45aa72f0c12410e252ae18754b1b99cf0e) fix: Correct child transaction reference in unsplit logic ### 📊 Changes **3 files changed** (+58 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/shared/transactions.test.ts` (+26 -0) 📝 `packages/loot-core/src/shared/transactions.ts` (+26 -0) ➕ `upcoming-release-notes/6501.md` (+6 -0) </details> ### 📄 Description Fixed logic: - use the parent’s transaction with the child’s category for unsplit transactions to prevent data loss Fixes #6271 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Unsplit last remaining child transactions now correctly converts the parent into a regular transaction and preserves amount, category, notes, and related details when the final child is removed. * Ensures the final child is removed and the parent’s state is updated atomically to prevent orphaned or inconsistent data. * **Tests** * Added coverage verifying that unsplitting the final child updates the parent and deletes the child as expected. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-14 05:01:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#125999
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?