github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 15:14:02 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8189] [WIP] fix: ignore completed schedule rules in payee counts #122399

New Issue
Open
opened 2026-06-11 21:15:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-11 21:15:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8189
Author: @Procoder1234556
Created: 6/11/2026
Status: 🔄 Open

Base: master ← Head: codex/issue-8154-transfer-placeholder

📝 Commits (4)

  • dc0e2a7 fix: translate transfer menu empty placeholder
  • 4f7ffe5 docs: add release note for transfer placeholder fix
  • dd5607e [AI] fix release note category
  • 538b120 fix: ignore completed schedule rules in payee counts

📊 Changes

4 files changed (+116 additions, -5 deletions)

View changed files

📝 packages/desktop-client/src/components/budget/envelope/TransferMenu.tsx (+4 -2)
➕ packages/loot-core/src/server/payees/app.test.ts (+67 -0)
📝 packages/loot-core/src/server/payees/app.ts (+39 -3)
➕ upcoming-release-notes/8154.md (+6 -0)

📄 Description

Closes #8134.

This patch updates the payee rule-count path so rules tied only to completed schedules are excluded from both:

  • the associated-rules count shown on the Payees page
  • the payee-specific rules list used when opening associated rules

Decision log:

  • Keep the filter in the server payees layer so the count badge and the rules lookup stay in sync.
  • Use schedule completion state from the database rather than trying to infer this in the UI.
  • Add a regression test that covers direct rules, active schedule-linked rules, and completed schedule-linked rules.

Verification:

  • yarn vitest run packages/loot-core/src/server/payees/app.test.ts
  • yarn oxfmt packages/loot-core/src/server/payees/app.ts packages/loot-core/src/server/payees/app.test.ts
  • yarn oxlint --quiet packages/loot-core/src/server/payees/app.ts packages/loot-core/src/server/payees/app.test.ts

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8189 **Author:** [@Procoder1234556](https://github.com/Procoder1234556) **Created:** 6/11/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `codex/issue-8154-transfer-placeholder` --- ### 📝 Commits (4) - [`dc0e2a7`](https://github.com/actualbudget/actual/commit/dc0e2a78ed5af72e1a48c677ab8e335a96edbd20) fix: translate transfer menu empty placeholder - [`4f7ffe5`](https://github.com/actualbudget/actual/commit/4f7ffe57d4c1848fd10a1a50c78fe30ef1a20e65) docs: add release note for transfer placeholder fix - [`dd5607e`](https://github.com/actualbudget/actual/commit/dd5607eeaf65180d706952ba85b994d269ae8c2c) [AI] fix release note category - [`538b120`](https://github.com/actualbudget/actual/commit/538b1200d18aae5d2a4f530330334876a49766b7) fix: ignore completed schedule rules in payee counts ### 📊 Changes **4 files changed** (+116 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/budget/envelope/TransferMenu.tsx` (+4 -2) ➕ `packages/loot-core/src/server/payees/app.test.ts` (+67 -0) 📝 `packages/loot-core/src/server/payees/app.ts` (+39 -3) ➕ `upcoming-release-notes/8154.md` (+6 -0) </details> ### 📄 Description Closes #8134. This patch updates the payee rule-count path so rules tied only to completed schedules are excluded from both: - the associated-rules count shown on the Payees page - the payee-specific rules list used when opening associated rules Decision log: - Keep the filter in the server payees layer so the count badge and the rules lookup stay in sync. - Use schedule completion state from the database rather than trying to infer this in the UI. - Add a regression test that covers direct rules, active schedule-linked rules, and completed schedule-linked rules. Verification: - yarn vitest run packages/loot-core/src/server/payees/app.test.ts - yarn oxfmt packages/loot-core/src/server/payees/app.ts packages/loot-core/src/server/payees/app.test.ts - yarn oxlint --quiet packages/loot-core/src/server/payees/app.ts packages/loot-core/src/server/payees/app.test.ts --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-11 21:15:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#122399
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?