github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 23:26:48 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8176] [AI] Fix category rules not applying when a rule renames the payee during transaction import #122388

New Issue
Open
opened 2026-06-11 21:14:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-11 21:14:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8176
Author: @junyuanz1
Created: 6/10/2026
Status: 🔄 Open

Base: master ← Head: fix-sync-import-category

📝 Commits (3)

  • c49cfe0 [AI] Fix category rules not applying when a rule renames the payee during import
  • 60037fb [AI] Add release notes
  • fcfce14 test

📊 Changes

3 files changed (+68 additions, -2 deletions)

View changed files

📝 packages/loot-core/src/server/transactions/transaction-rules.test.ts (+32 -0)
📝 packages/loot-core/src/server/transactions/transaction-rules.ts (+30 -2)
➕ upcoming-release-notes/8176.md (+6 -0)

📄 Description

Description

When importing transactions (e.g. via bank sync), rules run exactly once in ranked order. The ranking is based on condition specificity, with ties broken by random rule UUIDs. A rule that matches on payee (such as the category rules Actual learns automatically, or user-created "payee → category" rules) could be ranked before the renaming rule that sets that payee from imported_payee. In that case its condition was evaluated against the raw bank payee, failed, and was never re-checked — so the transaction was imported with the correct (renamed) payee but no category.

Because the ordering depends on specificity scores and UUID tie-breaking, this only affected some payees, which made it look intermittent: "sometimes the payee matches but the predefined category isn't applied."

This PR fixes it in runRules: after the main rule pass, if any rule changed the payee, rules that match on payee and did not apply in the first pass get a second chance, still in ranked order. Rules that already applied are skipped, so no action (e.g. note appending) ever runs twice.

This change was written by an AI tool: Claude Code (per the AI usage policy).

Related issue(s)

None found.

Testing

  • Added a regression test in packages/loot-core/src/server/transactions/transaction-rules.test.ts that deterministically reproduces the broken ordering: a category rule using payee oneOf [...] (specificity score 18) is ranked before a renaming rule using imported_payee is "..." (score 20). Without the fix the test fails with the payee correctly renamed but category: null; with the fix it passes.
  • All loot-core tests under server/rules, server/transactions, and server/accounts pass (236 tests).
  • yarn typecheck introduces no new errors (3 pre-existing akahu errors in sync-server exist on master as well); yarn lint reports 0 errors.

To reproduce manually: create a rule "imported_payee is <exact bank payee> → set payee X" and a rule "payee oneOf [X] → set category Y", then sync/import a transaction with that bank payee. Before this fix the transaction gets payee X but no category.

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I have read every line of this diff and can explain what each change does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.13 MB 0%
loot-core 1 5.28 MB → 5.28 MB (+492 B) +0.01%
api 2 3.87 MB → 3.87 MB (+479 B) +0.01%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.13 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.6 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.63 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ReportRouter.js 1.27 MB 0%
static/js/ScheduleEditForm.js 146.57 kB 0%
static/js/SchedulesTable.js 206.3 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 5.08 MB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 185.63 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 100.19 kB 0%
static/js/de.js 173.68 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 201.61 kB 0%
static/js/es.js 177.58 kB 0%
static/js/extends.js 508.79 kB 0%
static/js/fr.js 177.35 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 163.93 kB 0%
static/js/narrow.js 365.05 kB 0%
static/js/nb-NO.js 147.07 kB 0%
static/js/nl.js 119.71 kB 0%
static/js/pt-BR.js 187.34 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 173.33 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.18 kB 0%
static/js/uk.js 216.7 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 298.88 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.44 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.28 MB → 5.28 MB (+492 B) +0.01%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts 📈 +492 B (+2.26%) 21.28 kB → 21.76 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.BWkgdo9d.js 0 B → 5.28 MB (+5.28 MB) -

Removed

Asset File Size % Changed
kcab.worker.C3iXgrGb.js 5.28 MB → 0 B (-5.28 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
2 3.87 MB → 3.87 MB (+479 B) +0.01%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts 📈 +479 B (+2.25%) 20.75 kB → 21.22 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.87 MB → 3.87 MB (+479 B) +0.01%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8176 **Author:** [@junyuanz1](https://github.com/junyuanz1) **Created:** 6/10/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-sync-import-category` --- ### 📝 Commits (3) - [`c49cfe0`](https://github.com/actualbudget/actual/commit/c49cfe0cfd7dda882f5ab834ffb8ae0113521a0c) [AI] Fix category rules not applying when a rule renames the payee during import - [`60037fb`](https://github.com/actualbudget/actual/commit/60037fb8cae1e4dfaf69171a6a27f3f6e4320b14) [AI] Add release notes - [`fcfce14`](https://github.com/actualbudget/actual/commit/fcfce148a46cf2ca5477af6c081fcd015055dc2c) test ### 📊 Changes **3 files changed** (+68 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/transactions/transaction-rules.test.ts` (+32 -0) 📝 `packages/loot-core/src/server/transactions/transaction-rules.ts` (+30 -2) ➕ `upcoming-release-notes/8176.md` (+6 -0) </details> ### 📄 Description ## Description When importing transactions (e.g. via bank sync), rules run exactly once in ranked order. The ranking is based on condition specificity, with ties broken by random rule UUIDs. A rule that matches on `payee` (such as the category rules Actual learns automatically, or user-created "payee → category" rules) could be ranked **before** the renaming rule that sets that payee from `imported_payee`. In that case its condition was evaluated against the raw bank payee, failed, and was never re-checked — so the transaction was imported with the correct (renamed) payee but no category. Because the ordering depends on specificity scores and UUID tie-breaking, this only affected some payees, which made it look intermittent: "sometimes the payee matches but the predefined category isn't applied." This PR fixes it in `runRules`: after the main rule pass, if any rule changed the payee, rules that match on `payee` and did not apply in the first pass get a second chance, still in ranked order. Rules that already applied are skipped, so no action (e.g. note appending) ever runs twice. This change was written by an AI tool: Claude Code (per the [AI usage policy](https://actualbudget.org/docs/contributing/ai-usage-policy)). ## Related issue(s) None found. ## Testing - Added a regression test in `packages/loot-core/src/server/transactions/transaction-rules.test.ts` that deterministically reproduces the broken ordering: a category rule using `payee oneOf [...]` (specificity score 18) is ranked before a renaming rule using `imported_payee is "..."` (score 20). Without the fix the test fails with the payee correctly renamed but `category: null`; with the fix it passes. - All loot-core tests under `server/rules`, `server/transactions`, and `server/accounts` pass (236 tests). - `yarn typecheck` introduces no new errors (3 pre-existing `akahu` errors in sync-server exist on master as well); `yarn lint` reports 0 errors. To reproduce manually: create a rule "imported_payee is &lt;exact bank payee&gt; → set payee X" and a rule "payee oneOf [X] → set category Y", then sync/import a transaction with that bank payee. Before this fix the transaction gets payee X but no category. ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I have read every line of this diff and can explain what each change does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.13 MB | 0% loot-core | 1 | 5.28 MB → 5.28 MB (+492 B) | +0.01% api | 2 | 3.87 MB → 3.87 MB (+479 B) | +0.01% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.13 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.6 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.63 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.27 MB | 0% static/js/ScheduleEditForm.js | 146.57 kB | 0% static/js/SchedulesTable.js | 206.3 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 5.08 MB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 185.63 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 100.19 kB | 0% static/js/de.js | 173.68 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 201.61 kB | 0% static/js/es.js | 177.58 kB | 0% static/js/extends.js | 508.79 kB | 0% static/js/fr.js | 177.35 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 163.93 kB | 0% static/js/narrow.js | 365.05 kB | 0% static/js/nb-NO.js | 147.07 kB | 0% static/js/nl.js | 119.71 kB | 0% static/js/pt-BR.js | 187.34 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 173.33 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.18 kB | 0% static/js/uk.js | 216.7 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 298.88 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.44 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.28 MB → 5.28 MB (+492 B) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts` | 📈 +492 B (+2.26%) | 21.28 kB → 21.76 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BWkgdo9d.js | 0 B → 5.28 MB (+5.28 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.C3iXgrGb.js | 5.28 MB → 0 B (-5.28 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.87 MB → 3.87 MB (+479 B) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts` | 📈 +479 B (+2.25%) | 20.75 kB → 21.22 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.87 MB → 3.87 MB (+479 B) | +0.01% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-11 21:14:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#122388
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?