github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8151] [CLOSED] [WIP] Account header - update bare button colors to use page colors #122370

New Issue
Closed
opened 2026-06-11 21:12:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-11 21:12:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8151
Author: @Juulz
Created: 6/8/2026
Status: ❌ Closed

Base: master ← Head: account-header

📝 Commits (10+)

  • 9601d83 maintenance update for color definition location
  • 0c3cd80 Merge branch 'actualbudget:master' into master
  • 44c7cbd Merge branch 'actualbudget:master' into master
  • a3b7ce6 Merge branch 'actualbudget:master' into master
  • ec43b5b Merge branch 'actualbudget:master' into master
  • 740fb54 Add 'PAYPAL' to spelling expectations
  • 66963c2 🎨 Add YNA Theme Light
  • db74391 Update restore.md
  • 287dfd1 Add files via upload
  • 378ea43 Add color inheritance to HelpMenu style

📊 Changes

7 files changed (+25 additions, -2 deletions)

View changed files

📝 .github/actions/docs-spelling/expect.txt (+1 -0)
📝 packages/desktop-client/src/components/HelpMenu.tsx (+1 -0)
📝 packages/desktop-client/src/components/accounts/Header.tsx (+10 -1)
📝 packages/docs/docs/backup-restore/restore.md (+1 -1)
📝 packages/docs/static/img/backup-restore/restore-close-budget.webp (+0 -0)
➕ upcoming-release-notes/6627.md (+6 -0)
➕ upcoming-release-notes/7441.md (+6 -0)

📄 Description

Description

Bare button default colors may not show on pageBackground. Update just bare button color variables on Account header to use page colors.

Cursor helped with this one.

Related issue(s)

none

Testing

Visual check

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I have read every line of this diff and can explain what each change does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.13 MB → 14.13 MB (+176 B) +0.00%
loot-core 1 5.28 MB 0%
api 2 3.87 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.13 MB → 14.13 MB (+176 B) +0.00%
Changeset
File Δ Size
src/components/accounts/Header.tsx 📈 +155 B (+0.54%) 27.89 kB → 28.05 kB
src/components/HelpMenu.tsx 📈 +21 B (+0.39%) 5.33 kB → 5.35 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/wide.js 298.88 kB → 299.04 kB (+155 B) +0.05%
static/js/index.js 1.6 MB → 1.6 MB (+21 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.63 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ReportRouter.js 1.27 MB 0%
static/js/ScheduleEditForm.js 146.57 kB 0%
static/js/SchedulesTable.js 206.26 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 5.08 MB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 185.63 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 100.19 kB 0%
static/js/de.js 173.54 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 201.61 kB 0%
static/js/es.js 177.58 kB 0%
static/js/extends.js 508.79 kB 0%
static/js/fr.js 177.35 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 163.93 kB 0%
static/js/narrow.js 365.05 kB 0%
static/js/nb-NO.js 147.07 kB 0%
static/js/nl.js 119.71 kB 0%
static/js/pt-BR.js 187.34 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 173.33 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 216.7 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.44 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.28 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.BuloPXUY.js 5.28 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.87 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.87 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8151 **Author:** [@Juulz](https://github.com/Juulz) **Created:** 6/8/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `account-header` --- ### 📝 Commits (10+) - [`9601d83`](https://github.com/actualbudget/actual/commit/9601d83ee374a5165e154159cd147d4eff399191) maintenance update for color definition location - [`0c3cd80`](https://github.com/actualbudget/actual/commit/0c3cd80c7c4aa775cb5a2c510804f55d7cb0abe3) Merge branch 'actualbudget:master' into master - [`44c7cbd`](https://github.com/actualbudget/actual/commit/44c7cbda70ff641df99b88e2a1d05116f3f44577) Merge branch 'actualbudget:master' into master - [`a3b7ce6`](https://github.com/actualbudget/actual/commit/a3b7ce67eca1b069b6e4ad938543583182b8b8f2) Merge branch 'actualbudget:master' into master - [`ec43b5b`](https://github.com/actualbudget/actual/commit/ec43b5bdd13a2b3686eb483c559dc27e9519cf49) Merge branch 'actualbudget:master' into master - [`740fb54`](https://github.com/actualbudget/actual/commit/740fb54e7392e792d2f3b4010486d5fccadcf59b) Add 'PAYPAL' to spelling expectations - [`66963c2`](https://github.com/actualbudget/actual/commit/66963c2142c7ec447ca1b4644eaaa3a4b08f4c1b) 🎨 Add YNA Theme Light - [`db74391`](https://github.com/actualbudget/actual/commit/db7439154c26495fc87eb0596824ecd2cd737bbd) Update restore.md - [`287dfd1`](https://github.com/actualbudget/actual/commit/287dfd159dd8aeaaee08d39944e7d27e6d817d56) Add files via upload - [`378ea43`](https://github.com/actualbudget/actual/commit/378ea4364a04724535fa398a23d37e13b72c7118) Add color inheritance to HelpMenu style ### 📊 Changes **7 files changed** (+25 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/docs-spelling/expect.txt` (+1 -0) 📝 `packages/desktop-client/src/components/HelpMenu.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/accounts/Header.tsx` (+10 -1) 📝 `packages/docs/docs/backup-restore/restore.md` (+1 -1) 📝 `packages/docs/static/img/backup-restore/restore-close-budget.webp` (+0 -0) ➕ `upcoming-release-notes/6627.md` (+6 -0) ➕ `upcoming-release-notes/7441.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://actualbudget.org/docs/contributing/#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description Bare button default colors may not show on pageBackground. Update just bare button color variables on Account header to use page colors. Cursor helped with this one. ## Related issue(s) none ## Testing Visual check ## Checklist - [ ] Release notes added (see link above) - [ ] No obvious regressions in affected areas - [ ] Self-review has been performed - I have read every line of this diff and can explain what each change does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.13 MB → 14.13 MB (+176 B) | +0.00% loot-core | 1 | 5.28 MB | 0% api | 2 | 3.87 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.13 MB → 14.13 MB (+176 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/accounts/Header.tsx` | 📈 +155 B (+0.54%) | 27.89 kB → 28.05 kB `src/components/HelpMenu.tsx` | 📈 +21 B (+0.39%) | 5.33 kB → 5.35 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/wide.js | 298.88 kB → 299.04 kB (+155 B) | +0.05% static/js/index.js | 1.6 MB → 1.6 MB (+21 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.63 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.27 MB | 0% static/js/ScheduleEditForm.js | 146.57 kB | 0% static/js/SchedulesTable.js | 206.26 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 5.08 MB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 185.63 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 100.19 kB | 0% static/js/de.js | 173.54 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 201.61 kB | 0% static/js/es.js | 177.58 kB | 0% static/js/extends.js | 508.79 kB | 0% static/js/fr.js | 177.35 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 163.93 kB | 0% static/js/narrow.js | 365.05 kB | 0% static/js/nb-NO.js | 147.07 kB | 0% static/js/nl.js | 119.71 kB | 0% static/js/pt-BR.js | 187.34 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 173.33 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 216.7 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.44 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.28 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BuloPXUY.js | 5.28 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.87 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.87 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-11 21:12:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#122370
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?