github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8132] [CLOSED] fix(api): preserve sub-transaction fields when partially updating via API #122355

New Issue
Closed
opened 2026-06-11 21:11:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-11 21:11:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8132
Author: @64johnlee
Created: 6/7/2026
Status: ❌ Closed

Base: master ← Head: fix-api-update-subtransaction-issue-5012

📝 Commits (10+)

  • 7792cde fix(reports): show correct tooltip entries in compact widget mode
  • 269fe12 fix(transactions): anchor split-error popover to row start to prevent horizontal overflow
  • fd7ba3c fix(notifications): fix stacked notification overlap and broken opacity
  • adfbf69 fix(accounts): show running balance when sorted by date ascending
  • c86f3c8 fix(accounts): place upcoming transactions at end when sorted date ascending
  • e680573 fix(export): populate payee for split children when filtered export excludes parent
  • 1229a0d fix(api): preserve sub-transaction fields when partially updating via API
  • ba55687 [autofix.ci] apply automated fixes
  • 0dba2c6 chore: add release notes for #5012
  • e7d3573 Update VRT screenshots

📊 Changes

15 files changed (+127 additions, -40 deletions)

View changed files

📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-applies-budget-template-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-applies-budget-template-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-applies-budget-template-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Tracking-applies-budget-template-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Tracking-applies-budget-template-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Tracking-applies-budget-template-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/Notifications.tsx (+2 -2)
📝 packages/desktop-client/src/components/accounts/Account.tsx (+16 -8)
📝 packages/desktop-client/src/components/reports/graphs/LineGraph.tsx (+8 -8)
📝 packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx (+21 -19)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+1 -1)
📝 packages/loot-core/src/server/transactions/export/export-to-csv.ts (+33 -1)
📝 packages/loot-core/src/shared/transactions.test.ts (+39 -0)
📝 packages/loot-core/src/shared/transactions.ts (+1 -1)
➕ upcoming-release-notes/5012.md (+6 -0)

📄 Description

Summary

When updateTransaction was called on a child (sub-transaction) with only a subset of fields — e.g. api.updateTransaction(id, { notes: 'new note' }) — the child's amount was silently reset to 0 and its category was replaced with the parent's category.

Root cause: in updateTransaction (shared/transactions.ts), the matching child was set to child = transaction (the partial update object { id, notes }), then passed to makeChild(parent, child). makeChild defaults amount to 0 and falls back to parent.category when those keys are absent in the child argument.

Fix: child = { ...t, ...transaction } — merge the existing full child with the incoming partial update before passing to makeChild, so only the explicitly supplied fields change and all other child fields are preserved.

Closes #5012

Changes

  • packages/loot-core/src/shared/transactions.ts — one-line fix: child = { ...t, ...transaction } in the child-update branch of updateTransaction
  • packages/loot-core/src/shared/transactions.test.ts — regression test: partial update (notes only) on a sub-transaction verifies amount and category are unchanged

Test plan

  • yarn workspace @actual-app/core run test --testPathPattern="transactions.test.ts" — 805/805 pass
  • New test partially updating a sub-transaction preserves its amount and category explicitly covers the bug scenario

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.13 MB → 14.13 MB (+506 B) +0.00%
loot-core 1 5.28 MB → 5.28 MB (+664 B) +0.01%
api 2 3.87 MB → 3.87 MB (+659 B) +0.02%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.13 MB → 14.13 MB (+506 B) +0.00%
Changeset
File Δ Size
src/components/reports/graphs/StackedBarGraph.tsx 📈 +254 B (+2.52%) 9.84 kB → 10.09 kB
src/components/accounts/Account.tsx 📈 +201 B (+0.45%) 43.94 kB → 44.14 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts 📈 +27 B (+0.32%) 8.17 kB → 8.2 kB
src/components/reports/graphs/LineGraph.tsx 📈 +18 B (+0.18%) 9.89 kB → 9.91 kB
src/components/Notifications.tsx 📈 +2 B (+0.01%) 14.79 kB → 14.79 kB
src/components/reports/reports/Calendar.tsx 📈 +2 B (+0.01%) 27.58 kB → 27.59 kB
src/components/transactions/TransactionsTable.tsx 📈 +2 B (+0.00%) 90.38 kB → 90.38 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.27 MB → 1.27 MB (+274 B) +0.02%
static/js/wide.js 298.88 kB → 299.08 kB (+201 B) +0.07%
static/js/Value.js 5.08 MB → 5.08 MB (+29 B) +0.00%
static/js/index.js 1.6 MB → 1.6 MB (+2 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.63 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ScheduleEditForm.js 146.57 kB 0%
static/js/SchedulesTable.js 206.26 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 185.63 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 100.19 kB 0%
static/js/de.js 172.1 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 201.61 kB 0%
static/js/es.js 177.58 kB 0%
static/js/extends.js 508.79 kB 0%
static/js/fr.js 177.35 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 163.93 kB 0%
static/js/narrow.js 365.05 kB 0%
static/js/nb-NO.js 147.07 kB 0%
static/js/nl.js 119.71 kB 0%
static/js/pt-BR.js 187.34 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 173.33 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 216.7 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.44 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.28 MB → 5.28 MB (+664 B) +0.01%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/export/export-to-csv.ts 📈 +634 B (+22.07%) 2.81 kB → 3.42 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts 📈 +30 B (+0.48%) 6.05 kB → 6.08 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.BmOolH9-.js 0 B → 5.28 MB (+5.28 MB) -

Removed

Asset File Size % Changed
kcab.worker.lfNBY2TT.js 5.28 MB → 0 B (-5.28 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
2 3.87 MB → 3.87 MB (+659 B) +0.02%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/export/export-to-csv.ts 📈 +632 B (+22.47%) 2.75 kB → 3.36 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts 📈 +27 B (+0.45%) 5.85 kB → 5.88 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.87 MB → 3.87 MB (+659 B) +0.02%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8132 **Author:** [@64johnlee](https://github.com/64johnlee) **Created:** 6/7/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-api-update-subtransaction-issue-5012` --- ### 📝 Commits (10+) - [`7792cde`](https://github.com/actualbudget/actual/commit/7792cdee49d83a8a9fa97107aae572272e94ce9a) fix(reports): show correct tooltip entries in compact widget mode - [`269fe12`](https://github.com/actualbudget/actual/commit/269fe126e593bca3027e887d5d58251c1152281d) fix(transactions): anchor split-error popover to row start to prevent horizontal overflow - [`fd7ba3c`](https://github.com/actualbudget/actual/commit/fd7ba3c0892cfd966500ba8cfb61e93162082777) fix(notifications): fix stacked notification overlap and broken opacity - [`adfbf69`](https://github.com/actualbudget/actual/commit/adfbf6989b30ad3fcc87f71af0c8d13e249848c7) fix(accounts): show running balance when sorted by date ascending - [`c86f3c8`](https://github.com/actualbudget/actual/commit/c86f3c84b77772c8114c5b0dcfc37172069c33a9) fix(accounts): place upcoming transactions at end when sorted date ascending - [`e680573`](https://github.com/actualbudget/actual/commit/e680573d37c6361adc1eaa1dff09440ca495cfbd) fix(export): populate payee for split children when filtered export excludes parent - [`1229a0d`](https://github.com/actualbudget/actual/commit/1229a0dd44a31d855ca169bbae9c9be5f86799d7) fix(api): preserve sub-transaction fields when partially updating via API - [`ba55687`](https://github.com/actualbudget/actual/commit/ba556875fc60a3d3ad22ddde7206eeb512c7d018) [autofix.ci] apply automated fixes - [`0dba2c6`](https://github.com/actualbudget/actual/commit/0dba2c6cc2a9f7cde9aca6497fcc6bd04e91fe3f) chore: add release notes for #5012 - [`e7d3573`](https://github.com/actualbudget/actual/commit/e7d3573bf66581f01c0175f01473037bdd2e60a7) Update VRT screenshots ### 📊 Changes **15 files changed** (+127 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-applies-budget-template-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-applies-budget-template-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-applies-budget-template-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Tracking-applies-budget-template-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Tracking-applies-budget-template-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Tracking-applies-budget-template-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/Notifications.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+16 -8) 📝 `packages/desktop-client/src/components/reports/graphs/LineGraph.tsx` (+8 -8) 📝 `packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx` (+21 -19) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+1 -1) 📝 `packages/loot-core/src/server/transactions/export/export-to-csv.ts` (+33 -1) 📝 `packages/loot-core/src/shared/transactions.test.ts` (+39 -0) 📝 `packages/loot-core/src/shared/transactions.ts` (+1 -1) ➕ `upcoming-release-notes/5012.md` (+6 -0) </details> ### 📄 Description ## Summary When `updateTransaction` was called on a child (sub-transaction) with only a subset of fields — e.g. `api.updateTransaction(id, { notes: 'new note' })` — the child's `amount` was silently reset to 0 and its `category` was replaced with the parent's category. Root cause: in `updateTransaction` (`shared/transactions.ts`), the matching child was set to `child = transaction` (the partial update object `{ id, notes }`), then passed to `makeChild(parent, child)`. `makeChild` defaults `amount` to 0 and falls back to `parent.category` when those keys are absent in the child argument. Fix: `child = { ...t, ...transaction }` — merge the existing full child with the incoming partial update before passing to `makeChild`, so only the explicitly supplied fields change and all other child fields are preserved. Closes #5012 ## Changes - `packages/loot-core/src/shared/transactions.ts` — one-line fix: `child = { ...t, ...transaction }` in the child-update branch of `updateTransaction` - `packages/loot-core/src/shared/transactions.test.ts` — regression test: partial update (`notes` only) on a sub-transaction verifies `amount` and `category` are unchanged ## Test plan - [x] `yarn workspace @actual-app/core run test --testPathPattern="transactions.test.ts"` — 805/805 pass - [x] New test `partially updating a sub-transaction preserves its amount and category` explicitly covers the bug scenario <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.13 MB → 14.13 MB (+506 B) | +0.00% loot-core | 1 | 5.28 MB → 5.28 MB (+664 B) | +0.01% api | 2 | 3.87 MB → 3.87 MB (+659 B) | +0.02% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.13 MB → 14.13 MB (+506 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/reports/graphs/StackedBarGraph.tsx` | 📈 +254 B (+2.52%) | 9.84 kB → 10.09 kB `src/components/accounts/Account.tsx` | 📈 +201 B (+0.45%) | 43.94 kB → 44.14 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts` | 📈 +27 B (+0.32%) | 8.17 kB → 8.2 kB `src/components/reports/graphs/LineGraph.tsx` | 📈 +18 B (+0.18%) | 9.89 kB → 9.91 kB `src/components/Notifications.tsx` | 📈 +2 B (+0.01%) | 14.79 kB → 14.79 kB `src/components/reports/reports/Calendar.tsx` | 📈 +2 B (+0.01%) | 27.58 kB → 27.59 kB `src/components/transactions/TransactionsTable.tsx` | 📈 +2 B (+0.00%) | 90.38 kB → 90.38 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/ReportRouter.js | 1.27 MB → 1.27 MB (+274 B) | +0.02% static/js/wide.js | 298.88 kB → 299.08 kB (+201 B) | +0.07% static/js/Value.js | 5.08 MB → 5.08 MB (+29 B) | +0.00% static/js/index.js | 1.6 MB → 1.6 MB (+2 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.63 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ScheduleEditForm.js | 146.57 kB | 0% static/js/SchedulesTable.js | 206.26 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 185.63 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 100.19 kB | 0% static/js/de.js | 172.1 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 201.61 kB | 0% static/js/es.js | 177.58 kB | 0% static/js/extends.js | 508.79 kB | 0% static/js/fr.js | 177.35 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 163.93 kB | 0% static/js/narrow.js | 365.05 kB | 0% static/js/nb-NO.js | 147.07 kB | 0% static/js/nl.js | 119.71 kB | 0% static/js/pt-BR.js | 187.34 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 173.33 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 216.7 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.44 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.28 MB → 5.28 MB (+664 B) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/export/export-to-csv.ts` | 📈 +634 B (+22.07%) | 2.81 kB → 3.42 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts` | 📈 +30 B (+0.48%) | 6.05 kB → 6.08 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BmOolH9-.js | 0 B → 5.28 MB (+5.28 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.lfNBY2TT.js | 5.28 MB → 0 B (-5.28 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.87 MB → 3.87 MB (+659 B) | +0.02% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/export/export-to-csv.ts` | 📈 +632 B (+22.47%) | 2.75 kB → 3.36 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts` | 📈 +27 B (+0.45%) | 5.85 kB → 5.88 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.87 MB → 3.87 MB (+659 B) | +0.02% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-11 21:11:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#122355
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?