github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-11 11:13:11 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8079] [MERGED] Make payee & categories searching to be case-insentive #122311

New Issue
Closed
opened 2026-06-11 21:06:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-11 21:06:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8079
Author: @jdcorona96
Created: 6/4/2026
Status: ✅ Merged
Merged: 6/5/2026
Merged by: @matt-fidd

Base: master ← Head: bugfix/fzf-search-case-sensitivity

📝 Commits (7)

  • 6928651 make payee & categories searching to be case-insentive
  • 59fff70 add release notes
  • c15a5b7 [autofix.ci] apply automated fixes
  • 13541fd Update VRT screenshots
  • 6d9abeb update release-note
  • ca20113 [autofix.ci] apply automated fixes
  • 8d15de3 fix release-note format

📊 Changes

6 files changed (+9 additions, -0 deletions)

View changed files

📝 packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-7-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-8-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-9-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+1 -0)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+2 -0)
➕ upcoming-release-notes/8079.md (+6 -0)

📄 Description

Description

The fzf library introduced in #7261 defaults to casing: "smart-case", which makes the search case-sensitive as soon as any uppercase letter appears in the input. While this is a useful behavior in some contexts, it causes a frustrating experience in the transaction autocomplete — particularly on mobile, where keyboards automatically capitalize the first letter of each word.
This means that if a user has payees stored in lowercase, like me (e.g. amazon, netflix) and starts typing naturally on their phone, the capitalized input (search:"Amazon"/"Netflix") will return no results at all. The same applies to anyone who types without paying attention to casing, which is the expected behavior for an autocomplete field.
This PR fixes the issue by setting casing: 'case-insensitive' on the Fzf instances in PayeeAutocomplete and CategoryAutocomplete, so search results are always returned regardless of how the user capitalizes their input. no other update made

Related issue(s)

Fixes #8078
Relates to #7261

Testing

Open any account
Add or edit a transaction and focus the Payee field
Type a payee name using uppercase letters (e.g. Amazon for a stored payee amazon, or REST for Restaurants)
Verify that results now appear regardless of casing
Repeat with the Category field
Verify that fuzzy matching still works as expected (e.g. hdep still surfaces Home Depot)

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.05 MB → 14.05 MB (+92 B) +0.00%
loot-core 1 5.28 MB 0%
api 2 3.86 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.05 MB → 14.05 MB (+92 B) +0.00%
Changeset
File Δ Size
src/components/autocomplete/PayeeAutocomplete.tsx 📈 +62 B (+0.26%) 22.93 kB → 22.99 kB
src/components/autocomplete/CategoryAutocomplete.tsx 📈 +30 B (+0.19%) 15.49 kB → 15.52 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/Value.js 5.08 MB → 5.08 MB (+92 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.56 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.6 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ReportRouter.js 1.26 MB 0%
static/js/ScheduleEditForm.js 146.44 kB 0%
static/js/SchedulesTable.js 202.7 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 186.63 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.02 kB 0%
static/js/de.js 170.87 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 199.45 kB 0%
static/js/es.js 178.57 kB 0%
static/js/extends.js 508.06 kB 0%
static/js/fr.js 178.44 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 164.87 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 147.94 kB 0%
static/js/nl.js 107 kB 0%
static/js/pt-BR.js 188.32 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.31 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 209.01 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 298.88 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.01 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.28 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.8g6UP_wl.js 5.28 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.86 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.86 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8079 **Author:** [@jdcorona96](https://github.com/jdcorona96) **Created:** 6/4/2026 **Status:** ✅ Merged **Merged:** 6/5/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `bugfix/fzf-search-case-sensitivity` --- ### 📝 Commits (7) - [`6928651`](https://github.com/actualbudget/actual/commit/692865104c213113981e40131dd6ec20c89171c7) make payee & categories searching to be case-insentive - [`59fff70`](https://github.com/actualbudget/actual/commit/59fff70c50854cb62c1a542a6efecbc01f57ac58) add release notes - [`c15a5b7`](https://github.com/actualbudget/actual/commit/c15a5b7206d8a56bee393c1e5b33a5ed97b59ccc) [autofix.ci] apply automated fixes - [`13541fd`](https://github.com/actualbudget/actual/commit/13541fd022a8418d83dd41f57c8490d0d3272724) Update VRT screenshots - [`6d9abeb`](https://github.com/actualbudget/actual/commit/6d9abeb47e528116a64f9cce8206876cbccc6229) update release-note - [`ca20113`](https://github.com/actualbudget/actual/commit/ca20113aff9582b4be705b986f112e393821181e) [autofix.ci] apply automated fixes - [`8d15de3`](https://github.com/actualbudget/actual/commit/8d15de3b173d5b5772e5940ba2727ac3274323c8) fix release-note format ### 📊 Changes **6 files changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-7-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-8-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-9-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+2 -0) ➕ `upcoming-release-notes/8079.md` (+6 -0) </details> ### 📄 Description ## Description The fzf library introduced in #7261 defaults to casing: "smart-case", which makes the search case-sensitive as soon as any uppercase letter appears in the input. While this is a useful behavior in some contexts, it causes a frustrating experience in the transaction autocomplete — particularly on mobile, where keyboards automatically capitalize the first letter of each word. This means that if a user has payees stored in lowercase, like me (e.g. amazon, netflix) and starts typing naturally on their phone, the capitalized input (search:"Amazon"/"Netflix") will return no results at all. The same applies to anyone who types without paying attention to casing, which is the expected behavior for an autocomplete field. This PR fixes the issue by setting casing: 'case-insensitive' on the `Fzf` instances in `PayeeAutocomplete` and `CategoryAutocomplete`, so search results are always returned regardless of how the user capitalizes their input. no other update made ## Related issue(s) Fixes #8078 Relates to #7261 ## Testing Open any account Add or edit a transaction and focus the Payee field Type a payee name using uppercase letters (e.g. Amazon for a stored payee amazon, or REST for Restaurants) Verify that results now appear regardless of casing Repeat with the Category field Verify that fuzzy matching still works as expected (e.g. hdep still surfaces Home Depot) ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.05 MB → 14.05 MB (+92 B) | +0.00% loot-core | 1 | 5.28 MB | 0% api | 2 | 3.86 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.05 MB → 14.05 MB (+92 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/autocomplete/PayeeAutocomplete.tsx` | 📈 +62 B (+0.26%) | 22.93 kB → 22.99 kB `src/components/autocomplete/CategoryAutocomplete.tsx` | 📈 +30 B (+0.19%) | 15.49 kB → 15.52 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/Value.js | 5.08 MB → 5.08 MB (+92 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.56 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.6 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.26 MB | 0% static/js/ScheduleEditForm.js | 146.44 kB | 0% static/js/SchedulesTable.js | 202.7 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 186.63 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.02 kB | 0% static/js/de.js | 170.87 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 199.45 kB | 0% static/js/es.js | 178.57 kB | 0% static/js/extends.js | 508.06 kB | 0% static/js/fr.js | 178.44 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 164.87 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 147.94 kB | 0% static/js/nl.js | 107 kB | 0% static/js/pt-BR.js | 188.32 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.31 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 209.01 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 298.88 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.01 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.28 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.8g6UP_wl.js | 5.28 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.86 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.86 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-11 21:06:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#122311
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?