github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #4075] [MERGED] Fix: update toolbar server status on sync #12230

New Issue
Closed
opened 2026-04-10 21:23:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 21:23:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4075
Author: @p-payet
Created: 1/2/2025
Status: ✅ Merged
Merged: 1/19/2025
Merged by: @joel-jeremy

Base: master ← Head: fix-3128/update-server-status-on-sync

📝 Commits (9)

  • 3446ebc fix/#3128: listen to 'sync-event' to update user data when sync status changed, so 'userData.offline' is up to date and server status displayed is valid
  • 2b6549d add upcoming release note
  • 6db80f7 fix: use of optional chaining for 'userData.offline' to fix typecheck errors
  • b24a7e5 fix: replace 'userData?.offline' by 'userDate' in useEffect's dependencies
  • b8743b3 fix: add error handling for 'initializeUserData' method
  • 5e73089 fix: remove optional chaining for 'userData.offline' and directly check if userData is not null
  • e254fc6 Merge branch 'master' into fix-3128/update-server-status-on-sync
  • dab622f Merge branch 'master' into fix-3128/update-server-status-on-sync
  • eb8e341 fix: eslint warning "loot-core/client/actions import should occur before import of loot-core/src/platform/client/fetch"

📊 Changes

2 files changed (+37 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/LoggedInUser.tsx (+31 -3)
➕ upcoming-release-notes/4075.md (+6 -0)

📄 Description

Fixes #3128

Listen to sync-event to update user data when sync status changed, so userData.offline is up to date and server status displayed is valid.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4075 **Author:** [@p-payet](https://github.com/p-payet) **Created:** 1/2/2025 **Status:** ✅ Merged **Merged:** 1/19/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `fix-3128/update-server-status-on-sync` --- ### 📝 Commits (9) - [`3446ebc`](https://github.com/actualbudget/actual/commit/3446ebc62fa99f6815b828e6cb75070e4a242d76) fix/#3128: listen to 'sync-event' to update user data when sync status changed, so 'userData.offline' is up to date and server status displayed is valid - [`2b6549d`](https://github.com/actualbudget/actual/commit/2b6549dba5d06b76918c9884020bdc05c4536a73) add upcoming release note - [`6db80f7`](https://github.com/actualbudget/actual/commit/6db80f70180ae3c9402c49acf650678032527572) fix: use of optional chaining for 'userData.offline' to fix typecheck errors - [`b24a7e5`](https://github.com/actualbudget/actual/commit/b24a7e548b055514c4aa52e0fabf920848f395d2) fix: replace 'userData?.offline' by 'userDate' in useEffect's dependencies - [`b8743b3`](https://github.com/actualbudget/actual/commit/b8743b37540fae4f2c7fc68c06b53f262d65940c) fix: add error handling for 'initializeUserData' method - [`5e73089`](https://github.com/actualbudget/actual/commit/5e73089bca2b6b552566551cf54bab80e4607307) fix: remove optional chaining for 'userData.offline' and directly check if userData is not null - [`e254fc6`](https://github.com/actualbudget/actual/commit/e254fc6203cb98b652964305810e5b48e2193b8e) Merge branch 'master' into fix-3128/update-server-status-on-sync - [`dab622f`](https://github.com/actualbudget/actual/commit/dab622f4d24e410ff0e3f028caa6bd25bf63ba68) Merge branch 'master' into fix-3128/update-server-status-on-sync - [`eb8e341`](https://github.com/actualbudget/actual/commit/eb8e341970472a6697c543c21a9ba9527a14efe9) fix: eslint warning "`loot-core/client/actions` import should occur before import of `loot-core/src/platform/client/fetch`" ### 📊 Changes **2 files changed** (+37 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/LoggedInUser.tsx` (+31 -3) ➕ `upcoming-release-notes/4075.md` (+6 -0) </details> ### 📄 Description Fixes #3128 Listen to `sync-event` to update user data when sync status changed, so `userData.offline` is up to date and server status displayed is valid. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 21:23:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#12230
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?