github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-11 11:13:11 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8044] [MERGED] [AI] Scope Electron update to v41 #122291

New Issue
Closed
opened 2026-06-11 21:04:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-11 21:04:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8044
Author: @Copilot
Created: 6/2/2026
Status: ✅ Merged
Merged: 6/3/2026
Merged by: @MikesGlitch

Base: master ← Head: copilot/update-electron-version

📝 Commits (10+)

  • bceb3cc Initial plan
  • 48484dc Bump desktop Electron runtime to v42.3.0
  • 308e14f Add release notes entry for PR #8044
  • a1d251a Change author from Copilot to MikesGlitch
  • b9acbb7 Update node-abi mappings to support Electron 42 ABI detection
  • 5db3dd1 Address validation feedback for Electron update PR
  • 45acc9a Add better-sqlite3 Electron 42 patch
  • 80a7675 Update lockfile for better-sqlite3 patch
  • 98d43a6 Remove better-sqlite patch protocol and target Electron 41
  • 0f143f1 Align release note with Electron 41.7.1 change

📊 Changes

3 files changed (+31 additions, -18 deletions)

View changed files

📝 packages/desktop-electron/package.json (+1 -1)
➕ upcoming-release-notes/8044.md (+6 -0)
📝 yarn.lock (+24 -17)

📄 Description

This change narrows the dependency update to the requested scope: move desktop Electron to the 41 line and avoid introducing a new better-sqlite3 version pin. It also removes the custom better-sqlite3 patch protocol while preserving the existing version range behavior.

  • Electron target

    • Updated /packages/desktop-electron/package.json from electron: 42.3.0 to electron: 41.7.1.

  • better-sqlite3 versioning policy

    • Replaced patched dependency spec with the normal semver range ^12.8.0 in:
      • /packages/api/package.json
      • /packages/sync-server/package.json
      • /packages/desktop-electron/package.json
      • /packages/loot-core/package.json
    • Removed the custom Yarn patch artifact for better-sqlite3.
    • Refreshed yarn.lock so manifests use npm:^12.8.0 (currently resolving to 12.9.0).

  • Release note alignment

    • Updated /upcoming-release-notes/8044.md to reflect the final Electron target (41.7.1).
{
  "better-sqlite3": "^12.8.0",
  "electron": "41.7.1"
}

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.04 MB 0%
loot-core 1 5.27 MB 0%
api 2 3.85 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.04 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.54 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.64 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ReportRouter.js 1.26 MB 0%
static/js/ScheduleEditForm.js 146.44 kB 0%
static/js/SchedulesTable.js 202.7 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 5.08 MB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 186.63 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.02 kB 0%
static/js/de.js 170.87 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 199.23 kB 0%
static/js/es.js 178.57 kB 0%
static/js/extends.js 501.42 kB 0%
static/js/fr.js 178.44 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 164.87 kB 0%
static/js/narrow.js 364.25 kB 0%
static/js/nb-NO.js 147.94 kB 0%
static/js/nl.js 107 kB 0%
static/js/pt-BR.js 188.32 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.31 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 207.3 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 297.5 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.01 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.27 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.WcTGUWK6.js 5.27 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.85 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.85 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8044 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 6/2/2026 **Status:** ✅ Merged **Merged:** 6/3/2026 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `copilot/update-electron-version` --- ### 📝 Commits (10+) - [`bceb3cc`](https://github.com/actualbudget/actual/commit/bceb3cc3a1da376dab4924793a0e730f2f246419) Initial plan - [`48484dc`](https://github.com/actualbudget/actual/commit/48484dc83dd23b49ba0fbbec33d2b9b5fc9627ff) Bump desktop Electron runtime to v42.3.0 - [`308e14f`](https://github.com/actualbudget/actual/commit/308e14f67b7b2fb4accb4cdf7d4083229f9312ff) Add release notes entry for PR #8044 - [`a1d251a`](https://github.com/actualbudget/actual/commit/a1d251add5b5cef7fa5d64ec6ef9b1cb077b5abd) Change author from Copilot to MikesGlitch - [`b9acbb7`](https://github.com/actualbudget/actual/commit/b9acbb7a9aa1835d7d18d418d853fa5e63770c8a) Update node-abi mappings to support Electron 42 ABI detection - [`5db3dd1`](https://github.com/actualbudget/actual/commit/5db3dd103618ae2b290c91ca2247c8a223d03ac7) Address validation feedback for Electron update PR - [`45acc9a`](https://github.com/actualbudget/actual/commit/45acc9a093b67b89115dd4ab30df14ee03b486b2) Add better-sqlite3 Electron 42 patch - [`80a7675`](https://github.com/actualbudget/actual/commit/80a7675285d321f31d4f04a8bd71a0b907c732c1) Update lockfile for better-sqlite3 patch - [`98d43a6`](https://github.com/actualbudget/actual/commit/98d43a6245d8441d3943cb9e19a9faf20a943b7a) Remove better-sqlite patch protocol and target Electron 41 - [`0f143f1`](https://github.com/actualbudget/actual/commit/0f143f1468bbea5cafe3293c25c10ab8af8412ff) Align release note with Electron 41.7.1 change ### 📊 Changes **3 files changed** (+31 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-electron/package.json` (+1 -1) ➕ `upcoming-release-notes/8044.md` (+6 -0) 📝 `yarn.lock` (+24 -17) </details> ### 📄 Description This change narrows the dependency update to the requested scope: move desktop Electron to the 41 line and avoid introducing a new better-sqlite3 version pin. It also removes the custom better-sqlite3 patch protocol while preserving the existing version range behavior. - **Electron target** - Updated `/packages/desktop-electron/package.json` from `electron: 42.3.0` to `electron: 41.7.1`. - **better-sqlite3 versioning policy** - Replaced patched dependency spec with the normal semver range `^12.8.0` in: - `/packages/api/package.json` - `/packages/sync-server/package.json` - `/packages/desktop-electron/package.json` - `/packages/loot-core/package.json` - Removed the custom Yarn patch artifact for better-sqlite3. - Refreshed `yarn.lock` so manifests use `npm:^12.8.0` (currently resolving to `12.9.0`). - **Release note alignment** - Updated `/upcoming-release-notes/8044.md` to reflect the final Electron target (`41.7.1`). ```json { "better-sqlite3": "^12.8.0", "electron": "41.7.1" } ``` <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.04 MB | 0% loot-core | 1 | 5.27 MB | 0% api | 2 | 3.85 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.04 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.54 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.64 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.26 MB | 0% static/js/ScheduleEditForm.js | 146.44 kB | 0% static/js/SchedulesTable.js | 202.7 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 5.08 MB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 186.63 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.02 kB | 0% static/js/de.js | 170.87 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 199.23 kB | 0% static/js/es.js | 178.57 kB | 0% static/js/extends.js | 501.42 kB | 0% static/js/fr.js | 178.44 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 164.87 kB | 0% static/js/narrow.js | 364.25 kB | 0% static/js/nb-NO.js | 147.94 kB | 0% static/js/nl.js | 107 kB | 0% static/js/pt-BR.js | 188.32 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.31 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 207.3 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 297.5 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.01 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.27 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.WcTGUWK6.js | 5.27 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.85 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.85 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-11 21:04:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#122291
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?