github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 22:54:03 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8003] [AI] Fix append notes rules on new transactions #122263

New Issue
Open
opened 2026-06-11 21:02:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-11 21:02:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8003
Author: @kikiminyes
Created: 5/31/2026
Status: 🔄 Open

Base: master ← Head: fix-append-notes-rule-new-transactions

📝 Commits (1)

  • 6b526a2 [AI] Fix append notes rules on new transactions

📊 Changes

6 files changed (+218 additions, -28 deletions)

View changed files

📝 packages/desktop-client/package.json (+1 -0)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx (+7 -16)
📝 packages/desktop-client/src/components/transactions/TransactionList.tsx (+4 -12)
➕ packages/desktop-client/src/components/transactions/applyRuleDiff.test.ts (+97 -0)
➕ packages/desktop-client/src/components/transactions/applyRuleDiff.ts (+103 -0)
➕ upcoming-release-notes/8003.md (+6 -0)

📄 Description

Fixes #7303

Summary

  • centralize how rule diffs are applied to new transactions
  • allow append/prepend notes rule results to update non-empty notes when they preserve the user-entered note
  • reuse the same rule-diff behavior for desktop and mobile transaction entry

Testing

  • corepack yarn workspace @actual-app/web test src/components/transactions/applyRuleDiff.test.ts
  • corepack yarn workspace @actual-app/web typecheck
  • corepack yarn oxfmt --check packages/desktop-client/package.json packages/desktop-client/src/components/transactions/applyRuleDiff.ts packages/desktop-client/src/components/transactions/applyRuleDiff.test.ts packages/desktop-client/src/components/transactions/TransactionList.tsx packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx upcoming-release-notes/8003.md
  • corepack yarn oxlint --type-aware packages/desktop-client/src/components/transactions/applyRuleDiff.ts packages/desktop-client/src/components/transactions/applyRuleDiff.test.ts packages/desktop-client/src/components/transactions/TransactionList.tsx packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx (0 errors; existing no-unsafe-type-assertion warnings remain in touched files)
  • PR_NUMBER=8003 node packages\ci-actions\bin\release-notes-check.mjs

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.03 MB ? 14.03 MB (+1.83 kB) +0.01%
loot-core 1 5.34 MB 0%
api 2 3.97 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.03 MB ? 14.03 MB (+1.83 kB) +0.01%
Changeset
File ? Size
src/components/transactions/applyRuleDiff.ts ?? +1.8 kB 0 B ? 1.8 kB
package.json ?? +93 B (+0.98%) 9.28 kB ? 9.38 kB
locale/en.json ?? +252 B (+0.12%) 198.24 kB ? 198.48 kB
src/components/mobile/transactions/TransactionEdit.tsx ?? -159 B (-0.22%) 71.47 kB ? 71.32 kB
src/components/transactions/TransactionList.tsx ?? -151 B (-0.85%) 17.29 kB ? 17.14 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/Value.js 5.08 MB ? 5.08 MB (+1.65 kB) +0.03%
static/js/en.js 198.24 kB ? 198.48 kB (+252 B) +0.12%
static/js/index.js 1.54 MB ? 1.54 MB (+93 B) +0.01%

Smaller

Asset File Size % Changed
static/js/TransactionEdit.js 90.63 kB ? 90.47 kB (-159 B) -0.17%

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.98 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ReportRouter.js 1.26 MB 0%
static/js/ScheduleEditForm.js 146.44 kB 0%
static/js/SchedulesTable.js 202.7 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 186.75 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.15 kB 0%
static/js/de.js 170.77 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/es.js 178.68 kB 0%
static/js/extends.js 500.96 kB 0%
static/js/fr.js 178.57 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.05 kB 0%
static/js/nl.js 106.24 kB 0%
static/js/pt-BR.js 188.43 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.48 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 207.46 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 297.21 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.89 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.34 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker._bwMMgjb.js 5.34 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.97 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

Related work

Related to #7568, which also targets #7303. This PR keeps the fix in the transaction-entry diff application path and currently has a passing release note/check setup. Happy to close or adjust if maintainers prefer reviving the earlier PR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8003 **Author:** [@kikiminyes](https://github.com/kikiminyes) **Created:** 5/31/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-append-notes-rule-new-transactions` --- ### 📝 Commits (1) - [`6b526a2`](https://github.com/actualbudget/actual/commit/6b526a2d6d7665eb9cd9ccf1eb94fe315cda406a) [AI] Fix append notes rules on new transactions ### 📊 Changes **6 files changed** (+218 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/package.json` (+1 -0) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx` (+7 -16) 📝 `packages/desktop-client/src/components/transactions/TransactionList.tsx` (+4 -12) ➕ `packages/desktop-client/src/components/transactions/applyRuleDiff.test.ts` (+97 -0) ➕ `packages/desktop-client/src/components/transactions/applyRuleDiff.ts` (+103 -0) ➕ `upcoming-release-notes/8003.md` (+6 -0) </details> ### 📄 Description Fixes #7303 ## Summary - centralize how rule diffs are applied to new transactions - allow append/prepend notes rule results to update non-empty notes when they preserve the user-entered note - reuse the same rule-diff behavior for desktop and mobile transaction entry ## Testing - `corepack yarn workspace @actual-app/web test src/components/transactions/applyRuleDiff.test.ts` - `corepack yarn workspace @actual-app/web typecheck` - `corepack yarn oxfmt --check packages/desktop-client/package.json packages/desktop-client/src/components/transactions/applyRuleDiff.ts packages/desktop-client/src/components/transactions/applyRuleDiff.test.ts packages/desktop-client/src/components/transactions/TransactionList.tsx packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx upcoming-release-notes/8003.md` - `corepack yarn oxlint --type-aware packages/desktop-client/src/components/transactions/applyRuleDiff.ts packages/desktop-client/src/components/transactions/applyRuleDiff.test.ts packages/desktop-client/src/components/transactions/TransactionList.tsx packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx` (0 errors; existing `no-unsafe-type-assertion` warnings remain in touched files) - `PR_NUMBER=8003 node packages\ci-actions\bin\release-notes-check.mjs` <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.03 MB ? 14.03 MB (+1.83 kB) | +0.01% loot-core | 1 | 5.34 MB | 0% api | 2 | 3.97 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.03 MB ? 14.03 MB (+1.83 kB) | +0.01% <details> <summary>Changeset</summary> File | ? | Size ---- | - | ---- `src/components/transactions/applyRuleDiff.ts` | ?? +1.8 kB | 0 B ? 1.8 kB `package.json` | ?? +93 B (+0.98%) | 9.28 kB ? 9.38 kB `locale/en.json` | ?? +252 B (+0.12%) | 198.24 kB ? 198.48 kB `src/components/mobile/transactions/TransactionEdit.tsx` | ?? -159 B (-0.22%) | 71.47 kB ? 71.32 kB `src/components/transactions/TransactionList.tsx` | ?? -151 B (-0.85%) | 17.29 kB ? 17.14 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/Value.js | 5.08 MB ? 5.08 MB (+1.65 kB) | +0.03% static/js/en.js | 198.24 kB ? 198.48 kB (+252 B) | +0.12% static/js/index.js | 1.54 MB ? 1.54 MB (+93 B) | +0.01% **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/TransactionEdit.js | 90.63 kB ? 90.47 kB (-159 B) | -0.17% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.98 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.26 MB | 0% static/js/ScheduleEditForm.js | 146.44 kB | 0% static/js/SchedulesTable.js | 202.7 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 186.75 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.15 kB | 0% static/js/de.js | 170.77 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/es.js | 178.68 kB | 0% static/js/extends.js | 500.96 kB | 0% static/js/fr.js | 178.57 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.05 kB | 0% static/js/nl.js | 106.24 kB | 0% static/js/pt-BR.js | 188.43 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.48 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 207.46 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 297.21 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.89 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.34 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker._bwMMgjb.js | 5.34 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.97 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> ## Related work Related to #7568, which also targets #7303. This PR keeps the fix in the transaction-entry diff application path and currently has a passing release note/check setup. Happy to close or adjust if maintainers prefer reviving the earlier PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-11 21:02:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#122263
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?