github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 22:54:03 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #8002] [CLOSED] [WIP] Qe interview fresh #122262

New Issue
Closed
opened 2026-06-11 21:02:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-11 21:02:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8002
Author: @Rucha123
Created: 5/31/2026
Status: ❌ Closed

Base: master ← Head: qe-interview-fresh

📝 Commits (10+)

  • 488cc98 [AI] Add E2E tests for envelope budgeting and transaction management
  • 6e0e615 [AI] Fix test count in TEST_PLAN.md: 64 tests not 63
  • efee4f4 [autofix.ci] apply automated fixes
  • dcd2aaf [AI] Add release notes for PR #8002
  • beedbde [AI] Fix test count and missing bank-sync command in TEST_PLAN.md section 6
  • c9fa1ba Merge branch 'master' into qe-interview-fresh
  • 63c4060 [AI] Default slowMo to 0; keep PLAYWRIGHT_SLOW_MO env var for demos
  • 36a6062 [AI] Address PR review feedback on test quality and page model correctness
  • 2f2cd16 [autofix.ci] apply automated fixes
  • 718fb58 [AI] Update docs to reflect review fixes and correct stale dispatchEvent references

📊 Changes

16 files changed (+1433 additions, -38 deletions)

View changed files

➕ AI_INTERACTIONS.md (+270 -0)
➕ TEST_PLAN.md (+319 -0)
📝 packages/desktop-client/e2e/bank-sync.test.ts (+30 -0)
📝 packages/desktop-client/e2e/budget.test.ts (+272 -0)
📝 packages/desktop-client/e2e/page-models/account-page.ts (+12 -0)
📝 packages/desktop-client/e2e/page-models/bank-sync-page.ts (+34 -2)
📝 packages/desktop-client/e2e/page-models/budget-page.ts (+29 -19)
📝 packages/desktop-client/e2e/page-models/navigation.ts (+6 -0)
📝 packages/desktop-client/e2e/page-models/payees-page.ts (+32 -0)
📝 packages/desktop-client/e2e/payees.test.ts (+104 -17)
📝 packages/desktop-client/e2e/reports.test.ts (+68 -0)
📝 packages/desktop-client/e2e/rules.test.ts (+50 -0)
📝 packages/desktop-client/e2e/schedules.test.ts (+78 -0)
📝 packages/desktop-client/e2e/transactions.test.ts (+118 -0)
📝 packages/desktop-client/playwright.config.ts (+5 -0)
➕ upcoming-release-notes/8002.md (+6 -0)

📄 Description

Adds Playwright E2E test coverage for two core features as part of a QE take-home exercise:

Feature 1 — Envelope Budgeting

  • 8 new tests covering allocation, fund transfers, persistence after reload,
    escape-key cancellation, zero-out, month navigation, category creation,
    and a cross-feature integration test proving spending transactions drain
    the correct envelope balance

Feature 2 — Transaction Management

  • 3 new tests covering real-time search/filter, inline field editing,
    and delete with balance revert

Additional coverage

  • Payees (8), Rules (3), Schedules (3), Reports (3), Bank Sync (2)

Bug fix

  • BudgetPage.getTotalBudgeted/Spent/Leftover used parseInt to parse
    currency strings. parseInt("3,030.00") returns 3 — it stops at the
    comma. Values ≥ $1,000 were silently truncated. Fixed with
    Math.round(parseFloat(text.replace(/,/g, '')) * 100), consistent with
    the existing correct implementation in getBalanceForRow().

Files added

  • TEST_PLAN.md — test plan with 18 test cases, priorities, and steps
  • AI_INTERACTIONS.md — real AI interaction log documenting prompts,
    failures, and decisions

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.03 MB 0%
loot-core 1 5.34 MB 0%
api 2 3.97 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.03 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.54 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.98 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ReportRouter.js 1.26 MB 0%
static/js/ScheduleEditForm.js 146.44 kB 0%
static/js/SchedulesTable.js 202.7 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 5.08 MB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 186.75 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.15 kB 0%
static/js/de.js 170.77 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 198.48 kB 0%
static/js/es.js 178.68 kB 0%
static/js/extends.js 500.96 kB 0%
static/js/fr.js 178.57 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.05 kB 0%
static/js/nl.js 106.28 kB 0%
static/js/pt-BR.js 188.43 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.48 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 207.46 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 297.21 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.01 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.34 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker._bwMMgjb.js 5.34 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.97 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8002 **Author:** [@Rucha123](https://github.com/Rucha123) **Created:** 5/31/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `qe-interview-fresh` --- ### 📝 Commits (10+) - [`488cc98`](https://github.com/actualbudget/actual/commit/488cc98cde04de61e7005d6047d9d53bb3286826) [AI] Add E2E tests for envelope budgeting and transaction management - [`6e0e615`](https://github.com/actualbudget/actual/commit/6e0e615f42f43006213bd04c1cb4e9f31f5d15c0) [AI] Fix test count in TEST_PLAN.md: 64 tests not 63 - [`efee4f4`](https://github.com/actualbudget/actual/commit/efee4f47718eeb9af05685e7e770f13a0275a751) [autofix.ci] apply automated fixes - [`dcd2aaf`](https://github.com/actualbudget/actual/commit/dcd2aaf6fb424a0ddcec950c8ac15b97ad6bcfca) [AI] Add release notes for PR #8002 - [`beedbde`](https://github.com/actualbudget/actual/commit/beedbde426dc0cb4f14a40a8a8446790c4a6f68e) [AI] Fix test count and missing bank-sync command in TEST_PLAN.md section 6 - [`c9fa1ba`](https://github.com/actualbudget/actual/commit/c9fa1ba5109cf150f6a9396fdc01ba19f64194d9) Merge branch 'master' into qe-interview-fresh - [`63c4060`](https://github.com/actualbudget/actual/commit/63c4060397f67a6c881e62f429b24bbfbb84271e) [AI] Default slowMo to 0; keep PLAYWRIGHT_SLOW_MO env var for demos - [`36a6062`](https://github.com/actualbudget/actual/commit/36a6062e30d3c350358d5d5297e5061e29bc69d1) [AI] Address PR review feedback on test quality and page model correctness - [`2f2cd16`](https://github.com/actualbudget/actual/commit/2f2cd16ad55804ae6438c7695b9fe38e23ccc0e5) [autofix.ci] apply automated fixes - [`718fb58`](https://github.com/actualbudget/actual/commit/718fb581e6ef2b436d26d75cb2dc6a012d61cbab) [AI] Update docs to reflect review fixes and correct stale dispatchEvent references ### 📊 Changes **16 files changed** (+1433 additions, -38 deletions) <details> <summary>View changed files</summary> ➕ `AI_INTERACTIONS.md` (+270 -0) ➕ `TEST_PLAN.md` (+319 -0) 📝 `packages/desktop-client/e2e/bank-sync.test.ts` (+30 -0) 📝 `packages/desktop-client/e2e/budget.test.ts` (+272 -0) 📝 `packages/desktop-client/e2e/page-models/account-page.ts` (+12 -0) 📝 `packages/desktop-client/e2e/page-models/bank-sync-page.ts` (+34 -2) 📝 `packages/desktop-client/e2e/page-models/budget-page.ts` (+29 -19) 📝 `packages/desktop-client/e2e/page-models/navigation.ts` (+6 -0) 📝 `packages/desktop-client/e2e/page-models/payees-page.ts` (+32 -0) 📝 `packages/desktop-client/e2e/payees.test.ts` (+104 -17) 📝 `packages/desktop-client/e2e/reports.test.ts` (+68 -0) 📝 `packages/desktop-client/e2e/rules.test.ts` (+50 -0) 📝 `packages/desktop-client/e2e/schedules.test.ts` (+78 -0) 📝 `packages/desktop-client/e2e/transactions.test.ts` (+118 -0) 📝 `packages/desktop-client/playwright.config.ts` (+5 -0) ➕ `upcoming-release-notes/8002.md` (+6 -0) </details> ### 📄 Description Adds Playwright E2E test coverage for two core features as part of a QE take-home exercise: **Feature 1 — Envelope Budgeting** - 8 new tests covering allocation, fund transfers, persistence after reload, escape-key cancellation, zero-out, month navigation, category creation, and a cross-feature integration test proving spending transactions drain the correct envelope balance **Feature 2 — Transaction Management** - 3 new tests covering real-time search/filter, inline field editing, and delete with balance revert **Additional coverage** - Payees (8), Rules (3), Schedules (3), Reports (3), Bank Sync (2) **Bug fix** - `BudgetPage.getTotalBudgeted/Spent/Leftover` used `parseInt` to parse currency strings. `parseInt("3,030.00")` returns `3` — it stops at the comma. Values ≥ $1,000 were silently truncated. Fixed with `Math.round(parseFloat(text.replace(/,/g, '')) * 100)`, consistent with the existing correct implementation in `getBalanceForRow()`. **Files added** - `TEST_PLAN.md` — test plan with 18 test cases, priorities, and steps - `AI_INTERACTIONS.md` — real AI interaction log documenting prompts, failures, and decisions <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.03 MB | 0% loot-core | 1 | 5.34 MB | 0% api | 2 | 3.97 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.03 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.54 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.98 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.26 MB | 0% static/js/ScheduleEditForm.js | 146.44 kB | 0% static/js/SchedulesTable.js | 202.7 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 5.08 MB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 186.75 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.15 kB | 0% static/js/de.js | 170.77 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 198.48 kB | 0% static/js/es.js | 178.68 kB | 0% static/js/extends.js | 500.96 kB | 0% static/js/fr.js | 178.57 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.05 kB | 0% static/js/nl.js | 106.28 kB | 0% static/js/pt-BR.js | 188.43 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.48 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 207.46 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 297.21 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.01 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.34 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker._bwMMgjb.js | 5.34 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.97 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-11 21:02:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#122262
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?