github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7885] [CLOSED] [WIP] fix(fs): handle EPERM/EPERM gracefully in listDir #122186

New Issue
Closed
opened 2026-06-11 20:53:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-11 20:53:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7885
Author: @guangyang1206
Created: 5/18/2026
Status: ❌ Closed

Base: master ← Head: fix/eperm-scandir-error-7824

📝 Commits (1)

  • 35d01f0 fix(fs): handle EPERM/EPERM gracefully in listDir

📊 Changes

1 file changed (+8 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/platform/server/fs/index.electron.ts (+8 -1)

📄 Description

Fixes #7824.

Previously, listDir would crash with EPERM (operation not permitted) when the app tries to scan a directory without read permissions.

Now handles EPERM/EPERM gracefully by:

  1. Logging a warning
  2. Returning an empty array instead of crashing

This allows the UI to handle missing permissions gracefully.

Issue Reference

Fixes #7824

Problem Description

On macOS/Windows, when the app tries to scan a directory it doesn't have permission to access, it crashes with:

EPERM: operation not permitted, scandir '/Users/userd...'

This happens because fs.readdir() fails with EPERM or EACCES when the app tries to read a restricted directory.

Root Cause

In packages/loot-core/src/platform/server/fs/index.electron.ts, the listDir function did not handle permission errors, causing the app to crash.

Solution

Modified listDir to gracefully handle EPERM and EACCES errors:

  1. Catch EPERM and EACCES error codes
  2. Log a warning message
  3. Return an empty array instead of crashing
if (err.code === 'EPERM' || err.code === 'EACCES') {
  logger.warn(`No permission to read directory: ${filepath}`);
  resolve([]);
} else {
  reject(err);
}

Impact

  • App no longer crashes when encountering restricted directories
  • Users see an empty file list instead of an error
  • More graceful handling of file system permission issues

Testing

  • Tested on macOS with restricted directories
  • Tested on Windows with protected folders
  • Code review - error handling logic is correct

Checklist

  • Code follows project coding style
  • Commit message follows Conventional Commits
  • Tests added/updated (error handling is hard to unit test)
  • Documentation updated (if needed)

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 33 14 MB → 14 MB (+1010 B) +0.01%
loot-core 1 5.34 MB 0%
api 2 3.96 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
33 14 MB → 14 MB (+1010 B) +0.01%
Changeset
File Δ Size
locale/en.json 📈 +1.05 kB (+0.54%) 195.88 kB → 196.93 kB
locale/uk.json 📉 -68 B (-0.03%) 207.45 kB → 207.38 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/en.js 195.88 kB → 196.93 kB (+1.05 kB) +0.54%

Smaller

Asset File Size % Changed
static/js/uk.js 207.45 kB → 207.38 kB (-68 B) -0.03%

Unchanged

Asset File Size % Changed
static/js/index.js 2.02 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ReportRouter.js 1.25 MB 0%
static/js/ScheduleEditForm.js 146.45 kB 0%
static/js/TransactionEdit.js 86.89 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 5.08 MB 0%
static/js/bankSyncUtils.js 54.15 kB 0%
static/js/ca.js 187.62 kB 0%
static/js/chart-theme.js 800.08 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.17 kB 0%
static/js/de.js 170.27 kB 0%
static/js/en-GB.js 10.01 kB 0%
static/js/es.js 178.71 kB 0%
static/js/extends.js 500.36 kB 0%
static/js/fr.js 178.61 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.02 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.08 kB 0%
static/js/nl.js 106.24 kB 0%
static/js/pt-BR.js 189.28 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.48 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/useFormatList.js 4.96 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.65 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.34 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.BkJq0HmC.js 5.34 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.96 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.96 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7885 **Author:** [@guangyang1206](https://github.com/guangyang1206) **Created:** 5/18/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/eperm-scandir-error-7824` --- ### 📝 Commits (1) - [`35d01f0`](https://github.com/actualbudget/actual/commit/35d01f0209c3c7f20c3a77905a6012e8e233d772) fix(fs): handle EPERM/EPERM gracefully in listDir ### 📊 Changes **1 file changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/platform/server/fs/index.electron.ts` (+8 -1) </details> ### 📄 Description Fixes #7824. Previously, listDir would crash with EPERM (operation not permitted) when the app tries to scan a directory without read permissions. Now handles EPERM/EPERM gracefully by: 1. Logging a warning 2. Returning an empty array instead of crashing This allows the UI to handle missing permissions gracefully. ### Issue Reference Fixes #7824 ### Problem Description On macOS/Windows, when the app tries to scan a directory it doesn't have permission to access, it crashes with: ``` EPERM: operation not permitted, scandir '/Users/userd...' ``` This happens because `fs.readdir()` fails with `EPERM` or `EACCES` when the app tries to read a restricted directory. ### Root Cause In `packages/loot-core/src/platform/server/fs/index.electron.ts`, the `listDir` function did not handle permission errors, causing the app to crash. ### Solution Modified `listDir` to gracefully handle `EPERM` and `EACCES` errors: 1. Catch `EPERM` and `EACCES` error codes 2. Log a warning message 3. Return an empty array instead of crashing ```typescript if (err.code === 'EPERM' || err.code === 'EACCES') { logger.warn(`No permission to read directory: ${filepath}`); resolve([]); } else { reject(err); } ``` ### Impact - App no longer crashes when encountering restricted directories - Users see an empty file list instead of an error - More graceful handling of file system permission issues ### Testing - [ ] Tested on macOS with restricted directories - [ ] Tested on Windows with protected folders - [x] Code review - error handling logic is correct ### Checklist - [x] Code follows project coding style - [x] Commit message follows Conventional Commits - [ ] Tests added/updated (error handling is hard to unit test) - [ ] Documentation updated (if needed) <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 33 | 14 MB → 14 MB (+1010 B) | +0.01% loot-core | 1 | 5.34 MB | 0% api | 2 | 3.96 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 33 | 14 MB → 14 MB (+1010 B) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `locale/en.json` | 📈 +1.05 kB (+0.54%) | 195.88 kB → 196.93 kB `locale/uk.json` | 📉 -68 B (-0.03%) | 207.45 kB → 207.38 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/en.js | 195.88 kB → 196.93 kB (+1.05 kB) | +0.54% **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/uk.js | 207.45 kB → 207.38 kB (-68 B) | -0.03% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 2.02 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ReportRouter.js | 1.25 MB | 0% static/js/ScheduleEditForm.js | 146.45 kB | 0% static/js/TransactionEdit.js | 86.89 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 5.08 MB | 0% static/js/bankSyncUtils.js | 54.15 kB | 0% static/js/ca.js | 187.62 kB | 0% static/js/chart-theme.js | 800.08 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.17 kB | 0% static/js/de.js | 170.27 kB | 0% static/js/en-GB.js | 10.01 kB | 0% static/js/es.js | 178.71 kB | 0% static/js/extends.js | 500.36 kB | 0% static/js/fr.js | 178.61 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.02 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.08 kB | 0% static/js/nl.js | 106.24 kB | 0% static/js/pt-BR.js | 189.28 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.48 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/useFormatList.js | 4.96 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.65 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.34 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BkJq0HmC.js | 5.34 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.96 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.96 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-11 20:53:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#122186
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?