github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 15:14:02 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7064] [CLOSED] Warn before delete when transfer counterpart is reconciled #121630

New Issue
Closed
opened 2026-06-11 19:50:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-11 19:50:24 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7064
Author: @HadiAyache
Created: 2/24/2026
Status: ❌ Closed

Base: master ← Head: fix-6787-reconciled-transfer-delete-warning

📝 Commits (6)

  • 576d3fd fix: warn when transfer counterpart is reconciled on delete
  • 095315f chore: add release note for reconciled transfer delete warning
  • 33f069a chore: add PR-specific release note 7064
  • 272aae1 [autofix.ci] apply automated fixes
  • 7c90823 fix(transactions): include grouped splits in reconciled transfer delete check
  • 9d69842 refactor: type aqlQuery data in reconciled delete precheck

📊 Changes

4 files changed (+88 additions, -2 deletions)

View changed files

➕ packages/desktop-client/src/hooks/useTransactionBatchActions.test.ts (+54 -0)
📝 packages/desktop-client/src/hooks/useTransactionBatchActions.ts (+22 -2)
➕ upcoming-release-notes/6787.md (+6 -0)
➕ upcoming-release-notes/7064.md (+6 -0)

📄 Description

Summary

Fixes missing delete warning when a selected transaction is part of a transfer and the linked counterpart is reconciled/locked.

Repro

  • Select transaction "tx-1" (not reconciled)
  • Linked transfer peer "tx-peer" is reconciled
  • Trigger delete batch action
  • Before this change, no reconciled warning was shown

Root cause

Reconciled precheck only inspected selected IDs and did not include transfer counterpart IDs (transfer_id).

Fix

  • Expand warning precheck IDs to include transfer-linked counterpart IDs
  • Keep actual delete execution scoped to originally selected IDs

Test

Added regression test:

  • warns before delete when transfer pair contains a reconciled transaction

Validation

  • corepack yarn workspace @actual-app/web test src/hooks/useTransactionBatchActions.test.ts
  • corepack yarn workspace @actual-app/web test src/hooks/useMetaThemeColor.test.ts src/hooks/useTransactionBatchActions.test.ts
  • corepack yarn oxlint packages/desktop-client/src/hooks/useTransactionBatchActions.ts packages/desktop-client/src/hooks/useTransactionBatchActions.test.ts

Closes #6787

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 14.85 MB → 14.85 MB (+682 B) +0.00%
loot-core 1 5.82 MB 0%
api 1 4.43 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 14.85 MB → 14.85 MB (+682 B) +0.00%
Changeset
File Δ Size
src/hooks/useTransactionBatchActions.ts 📈 +682 B (+5.17%) 12.87 kB → 13.54 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/useTransactionBatchActions.js 13.23 kB → 13.89 kB (+682 B) +5.04%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 9.54 MB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/ca.js 188.15 kB 0%
static/js/da.js 106.35 kB 0%
static/js/de.js 180.07 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/en.js 170.37 kB 0%
static/js/es.js 174.55 kB 0%
static/js/fr.js 179.6 kB 0%
static/js/it.js 171.16 kB 0%
static/js/nb-NO.js 156.96 kB 0%
static/js/nl.js 106.37 kB 0%
static/js/pl.js 88.37 kB 0%
static/js/pt-BR.js 154.22 kB 0%
static/js/th.js 181.87 kB 0%
static/js/uk.js 214.74 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.16 MB 0%
static/js/narrow.js 637.77 kB 0%
static/js/TransactionList.js 106.22 kB 0%
static/js/wide.js 164.15 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 10.04 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.82 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.BwrdDDMW.js 5.82 MB 0%

api

Total

Files count Total bundle size % Changed
1 4.43 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
bundle.api.js 4.43 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7064 **Author:** [@HadiAyache](https://github.com/HadiAyache) **Created:** 2/24/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-6787-reconciled-transfer-delete-warning` --- ### 📝 Commits (6) - [`576d3fd`](https://github.com/actualbudget/actual/commit/576d3fd9f343cd0218f575c3361d3552a3f9ac6d) fix: warn when transfer counterpart is reconciled on delete - [`095315f`](https://github.com/actualbudget/actual/commit/095315f644a9a331b7c728310db4bed8f59acb05) chore: add release note for reconciled transfer delete warning - [`33f069a`](https://github.com/actualbudget/actual/commit/33f069a7be45a619cd46795bc0eeb008a38f08c0) chore: add PR-specific release note 7064 - [`272aae1`](https://github.com/actualbudget/actual/commit/272aae1c60ef146325cd5d0eda8ebaf957a53d16) [autofix.ci] apply automated fixes - [`7c90823`](https://github.com/actualbudget/actual/commit/7c908232ba57d59f9bca4e42cd45227150f39b40) fix(transactions): include grouped splits in reconciled transfer delete check - [`9d69842`](https://github.com/actualbudget/actual/commit/9d698428584f778c0ca38caf5f958f5c37148935) refactor: type aqlQuery data in reconciled delete precheck ### 📊 Changes **4 files changed** (+88 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/src/hooks/useTransactionBatchActions.test.ts` (+54 -0) 📝 `packages/desktop-client/src/hooks/useTransactionBatchActions.ts` (+22 -2) ➕ `upcoming-release-notes/6787.md` (+6 -0) ➕ `upcoming-release-notes/7064.md` (+6 -0) </details> ### 📄 Description ## Summary Fixes missing delete warning when a selected transaction is part of a transfer and the linked counterpart is reconciled/locked. ## Repro - Select transaction "tx-1" (not reconciled) - Linked transfer peer "tx-peer" is reconciled - Trigger delete batch action - Before this change, no reconciled warning was shown ## Root cause Reconciled precheck only inspected selected IDs and did not include transfer counterpart IDs (transfer_id). ## Fix - Expand warning precheck IDs to include transfer-linked counterpart IDs - Keep actual delete execution scoped to originally selected IDs ## Test Added regression test: - warns before delete when transfer pair contains a reconciled transaction ## Validation - corepack yarn workspace @actual-app/web test src/hooks/useTransactionBatchActions.test.ts - corepack yarn workspace @actual-app/web test src/hooks/useMetaThemeColor.test.ts src/hooks/useTransactionBatchActions.test.ts - corepack yarn oxlint packages/desktop-client/src/hooks/useTransactionBatchActions.ts packages/desktop-client/src/hooks/useTransactionBatchActions.test.ts Closes #6787 <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 14.85 MB → 14.85 MB (+682 B) | +0.00% loot-core | 1 | 5.82 MB | 0% api | 1 | 4.43 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 14.85 MB → 14.85 MB (+682 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/hooks/useTransactionBatchActions.ts` | 📈 +682 B (+5.17%) | 12.87 kB → 13.54 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/useTransactionBatchActions.js | 13.23 kB → 13.89 kB (+682 B) | +5.04% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.54 MB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/ca.js | 188.15 kB | 0% static/js/da.js | 106.35 kB | 0% static/js/de.js | 180.07 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/en.js | 170.37 kB | 0% static/js/es.js | 174.55 kB | 0% static/js/fr.js | 179.6 kB | 0% static/js/it.js | 171.16 kB | 0% static/js/nb-NO.js | 156.96 kB | 0% static/js/nl.js | 106.37 kB | 0% static/js/pl.js | 88.37 kB | 0% static/js/pt-BR.js | 154.22 kB | 0% static/js/th.js | 181.87 kB | 0% static/js/uk.js | 214.74 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.16 MB | 0% static/js/narrow.js | 637.77 kB | 0% static/js/TransactionList.js | 106.22 kB | 0% static/js/wide.js | 164.15 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 10.04 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.82 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BwrdDDMW.js | 5.82 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.43 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.43 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-11 19:50:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#121630
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?