github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 15:14:02 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #5763] [CLOSED] [WIP] fix: remove hidden decimals check in amount input #120819

New Issue
Closed
opened 2026-06-11 18:27:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-11 18:27:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5763
Author: @csenel
Created: 9/21/2025
Status: ❌ Closed

Base: master ← Head: fix-hidden-decimal-input

📝 Commits (3)

  • e8ce0ea remove hidden decimals check in amount input
  • 896f60a generate release notes, yarn lint and change input value
  • 26b35ce update to show with decimal, fix lint warnings

📊 Changes

7 files changed (+15 additions, -15 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx (+3 -3)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (+0 -1)
📝 packages/desktop-client/src/components/modals/HoldBufferModal.tsx (+0 -1)
📝 packages/desktop-client/src/components/modals/TransferModal.tsx (+0 -1)
📝 packages/desktop-client/src/components/util/AmountInput.tsx (+1 -6)
📝 packages/loot-core/src/shared/util.ts (+5 -3)
➕ upcoming-release-notes/5763.md (+6 -0)

📄 Description

Fixes https://github.com/actualbudget/actual/issues/3294

Attempt to fix the bug above. The code looked a bit cryptic to me but it seems like the hideFraction setting is applied while editing the text. This in turn changes the amount for the transaction. Removing this check should show the actual value while editing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5763 **Author:** [@csenel](https://github.com/csenel) **Created:** 9/21/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-hidden-decimal-input` --- ### 📝 Commits (3) - [`e8ce0ea`](https://github.com/actualbudget/actual/commit/e8ce0ea38657d1d3c9b19af567e6b764b47c938c) remove hidden decimals check in amount input - [`896f60a`](https://github.com/actualbudget/actual/commit/896f60a108d49fecb36c03d058eb8e4695695379) generate release notes, yarn lint and change input value - [`26b35ce`](https://github.com/actualbudget/actual/commit/26b35ce40e38442724ca2ed1819439608b4592f2) update to show with decimal, fix lint warnings ### 📊 Changes **7 files changed** (+15 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx` (+0 -1) 📝 `packages/desktop-client/src/components/modals/HoldBufferModal.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/modals/TransferModal.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/util/AmountInput.tsx` (+1 -6) 📝 `packages/loot-core/src/shared/util.ts` (+5 -3) ➕ `upcoming-release-notes/5763.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Fixes https://github.com/actualbudget/actual/issues/3294 Attempt to fix the bug above. The code looked a bit cryptic to me but it seems like the `hideFraction` setting is applied while editing the text. This in turn changes the amount for the transaction. Removing this check should show the actual value while editing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-11 18:27:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#120819
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?