[PR #4125] [CLOSED] [WIP] [Address suppressed ESLint errors] Fix exhaustive deps errors in FinancesApp.tsx #119916

Closed
opened 2026-06-11 16:55:42 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4125
Author: @joel-jeremy
Created: 1/10/2025
Status: ❌ Closed

Base: master ← Head: fix-exhaustive-deps-errors-FinancesApp


📝 Commits (3)

  • 900b294 Fix exhaustive deps errors in App.tsx
  • f522d18 Release notes
  • a1ea12c [Address suppressed ESLint errors] Fix exhaustive deps errors in FinancesApp.tsx

📊 Changes

4 files changed (+64 additions, -56 deletions)

View changed files

📝 eslint.config.mjs (+0 -2)
📝 packages/desktop-client/src/components/App.tsx (+55 -51)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+3 -3)
➕ upcoming-release-notes/4124.md (+6 -0)

📄 Description

  • 'packages/desktop-client/src/components/accounts/Account.jsx',
  • 'packages/desktop-client/src/components/accounts/MobileAccount.jsx',
  • 'packages/desktop-client/src/components/accounts/MobileAccounts.jsx',
  • 'packages/desktop-client/src/components/App.tsx',
  • 'packages/desktop-client/src/components/budget/BudgetCategories.jsx',
  • 'packages/desktop-client/src/components/budget/BudgetSummaries.tsx',
  • 'packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx',
  • 'packages/desktop-client/src/components/budget/index.tsx',
  • 'packages/desktop-client/src/components/budget/MobileBudget.tsx',
  • 'packages/desktop-client/src/components/budget/envelope/HoldMenu.tsx',
  • 'packages/desktop-client/src/components/budget/envelope/TransferMenu.tsx',
  • 'packages/desktop-client/src/components/common/Menu.tsx',
  • 'packages/desktop-client/src/components/FinancesApp.tsx',
  • 'packages/desktop-client/src/components/GlobalKeys.ts',
  • 'packages/desktop-client/src/components/LoggedInUser.tsx',
  • 'packages/desktop-client/src/components/manager/ManagementApp.jsx',
  • 'packages/desktop-client/src/components/manager/subscribe/common.tsx',
  • 'packages/desktop-client/src/components/ManageRules.tsx',
  • 'packages/desktop-client/src/components/mobile/MobileAmountInput.jsx',
  • 'packages/desktop-client/src/components/mobile/MobileNavTabs.tsx',
  • 'packages/desktop-client/src/components/Modals.tsx',
  • 'packages/desktop-client/src/components/modals/EditRule.jsx',
  • 'packages/desktop-client/src/components/modals/ImportTransactions.jsx',
  • 'packages/desktop-client/src/components/modals/MergeUnusedPayees.jsx',
  • 'packages/desktop-client/src/components/Notifications.tsx',
  • 'packages/desktop-client/src/components/payees/ManagePayees.jsx',
  • 'packages/desktop-client/src/components/payees/ManagePayeesWithData.jsx',
  • 'packages/desktop-client/src/components/payees/PayeeTable.tsx',
  • 'packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTable.tsx',
  • 'packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableTotals.tsx',
  • 'packages/desktop-client/src/components/reports/reports/CashFlowCard.jsx',
  • 'packages/desktop-client/src/components/reports/reports/CustomReport.jsx',
  • 'packages/desktop-client/src/components/reports/reports/NetWorthCard.jsx',
  • 'packages/desktop-client/src/components/reports/SaveReportName.tsx',
  • 'packages/desktop-client/src/components/reports/useReport.ts',
  • 'packages/desktop-client/src/components/schedules/ScheduleDetails.jsx',
  • 'packages/desktop-client/src/components/schedules/SchedulesTable.tsx',
  • 'packages/desktop-client/src/components/select/DateSelect.tsx',
  • 'packages/desktop-client/src/components/sidebar/Tools.tsx',
  • 'packages/desktop-client/src/components/sort.tsx',
  • 'packages/desktop-client/src/components/spreadsheet/useSheetValue.ts',
  • 'packages/desktop-client/src/components/table.tsx',
  • 'packages/desktop-client/src/components/Titlebar.tsx',
  • 'packages/desktop-client/src/components/transactions/MobileTransaction.jsx',
  • 'packages/desktop-client/src/components/transactions/SelectedTransactions.jsx',
  • 'packages/desktop-client/src/components/transactions/SimpleTransactionsTable.jsx',
  • 'packages/desktop-client/src/components/transactions/TransactionList.jsx',
  • 'packages/desktop-client/src/components/transactions/TransactionsTable.jsx',
  • 'packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx',
  • 'packages/desktop-client/src/hooks/useAccounts.ts',
  • 'packages/desktop-client/src/hooks/useCategories.ts',
  • 'packages/desktop-client/src/hooks/usePayees.ts',
  • 'packages/desktop-client/src/hooks/useProperFocus.tsx',
  • 'packages/desktop-client/src/hooks/useSelected.tsx',
  • 'packages/loot-core/src/client/query-hooks.tsx',

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4125 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 1/10/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-exhaustive-deps-errors-FinancesApp` --- ### 📝 Commits (3) - [`900b294`](https://github.com/actualbudget/actual/commit/900b294975197c100ad37dc35ce2e4dc5f8a7426) Fix exhaustive deps errors in App.tsx - [`f522d18`](https://github.com/actualbudget/actual/commit/f522d18636246b3a4e0da88bb03122f4d029f361) Release notes - [`a1ea12c`](https://github.com/actualbudget/actual/commit/a1ea12c3dde595ac4baa70b9839d7908a9497b9e) [Address suppressed ESLint errors] Fix exhaustive deps errors in FinancesApp.tsx ### 📊 Changes **4 files changed** (+64 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `eslint.config.mjs` (+0 -2) 📝 `packages/desktop-client/src/components/App.tsx` (+55 -51) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+3 -3) ➕ `upcoming-release-notes/4124.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> - [ ] 'packages/desktop-client/src/components/accounts/Account.jsx', - [ ] 'packages/desktop-client/src/components/accounts/MobileAccount.jsx', - [ ] 'packages/desktop-client/src/components/accounts/MobileAccounts.jsx', - [x] 'packages/desktop-client/src/components/App.tsx', - [ ] 'packages/desktop-client/src/components/budget/BudgetCategories.jsx', - [ ] 'packages/desktop-client/src/components/budget/BudgetSummaries.tsx', - [ ] 'packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx', - [ ] 'packages/desktop-client/src/components/budget/index.tsx', - [ ] 'packages/desktop-client/src/components/budget/MobileBudget.tsx', - [ ] 'packages/desktop-client/src/components/budget/envelope/HoldMenu.tsx', - [ ] 'packages/desktop-client/src/components/budget/envelope/TransferMenu.tsx', - [ ] 'packages/desktop-client/src/components/common/Menu.tsx', - [x] 'packages/desktop-client/src/components/FinancesApp.tsx', - [ ] 'packages/desktop-client/src/components/GlobalKeys.ts', - [ ] 'packages/desktop-client/src/components/LoggedInUser.tsx', - [ ] 'packages/desktop-client/src/components/manager/ManagementApp.jsx', - [ ] 'packages/desktop-client/src/components/manager/subscribe/common.tsx', - [ ] 'packages/desktop-client/src/components/ManageRules.tsx', - [ ] 'packages/desktop-client/src/components/mobile/MobileAmountInput.jsx', - [ ] 'packages/desktop-client/src/components/mobile/MobileNavTabs.tsx', - [ ] 'packages/desktop-client/src/components/Modals.tsx', - [ ] 'packages/desktop-client/src/components/modals/EditRule.jsx', - [ ] 'packages/desktop-client/src/components/modals/ImportTransactions.jsx', - [ ] 'packages/desktop-client/src/components/modals/MergeUnusedPayees.jsx', - [ ] 'packages/desktop-client/src/components/Notifications.tsx', - [ ] 'packages/desktop-client/src/components/payees/ManagePayees.jsx', - [ ] 'packages/desktop-client/src/components/payees/ManagePayeesWithData.jsx', - [ ] 'packages/desktop-client/src/components/payees/PayeeTable.tsx', - [ ] 'packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTable.tsx', - [ ] 'packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableTotals.tsx', - [ ] 'packages/desktop-client/src/components/reports/reports/CashFlowCard.jsx', - [ ] 'packages/desktop-client/src/components/reports/reports/CustomReport.jsx', - [ ] 'packages/desktop-client/src/components/reports/reports/NetWorthCard.jsx', - [ ] 'packages/desktop-client/src/components/reports/SaveReportName.tsx', - [ ] 'packages/desktop-client/src/components/reports/useReport.ts', - [ ] 'packages/desktop-client/src/components/schedules/ScheduleDetails.jsx', - [ ] 'packages/desktop-client/src/components/schedules/SchedulesTable.tsx', - [ ] 'packages/desktop-client/src/components/select/DateSelect.tsx', - [ ] 'packages/desktop-client/src/components/sidebar/Tools.tsx', - [ ] 'packages/desktop-client/src/components/sort.tsx', - [ ] 'packages/desktop-client/src/components/spreadsheet/useSheetValue.ts', - [ ] 'packages/desktop-client/src/components/table.tsx', - [ ] 'packages/desktop-client/src/components/Titlebar.tsx', - [ ] 'packages/desktop-client/src/components/transactions/MobileTransaction.jsx', - [ ] 'packages/desktop-client/src/components/transactions/SelectedTransactions.jsx', - [ ] 'packages/desktop-client/src/components/transactions/SimpleTransactionsTable.jsx', - [ ] 'packages/desktop-client/src/components/transactions/TransactionList.jsx', - [ ] 'packages/desktop-client/src/components/transactions/TransactionsTable.jsx', - [ ] 'packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx', - [ ] 'packages/desktop-client/src/hooks/useAccounts.ts', - [ ] 'packages/desktop-client/src/hooks/useCategories.ts', - [ ] 'packages/desktop-client/src/hooks/usePayees.ts', - [ ] 'packages/desktop-client/src/hooks/useProperFocus.tsx', - [ ] 'packages/desktop-client/src/hooks/useSelected.tsx', - [ ] 'packages/loot-core/src/client/query-hooks.tsx', --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-11 16:55:42 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#119916