mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-15 22:54:03 -05:00
[PR #3185] [MERGED] :electron: Packaging different architectures and installers for windows #119446
Closed
opened 2026-06-11 16:04:57 -05:00 by GiteaMirror
·
0 comments
No Branch/Tag Specified
master
dependabot/npm_and_yarn/npm_and_yarn-cd62b4b37a
enforce-append-only-migrations-ci
claude/error-codes-worker-boundary-26i5uu
api-browser-custom-data-dir
tabedzki/feat/replacing-month-picker-with-day-picker
delay-initial-sync-until-loaded
jfdoming/mobile-app-build
cross-version-sync-compat
jfdoming/api-tokens-part-1
jfdoming/api-tokens-part-2
jfdoming/api-tokens-part-3
jfdoming/mobile-app-updates
claude/budget-version-migration-compat-151jlr
claude/worker-error-serialization-9iqtl7
claude/react-table-library-research-afx83z
claude/issue-8401-regression-test-9nw9l3
jfdoming/mobile-app-foundation-part-1
jfdoming/mobile-app-scaffold
release
ai-fix-cleanup-def-8290
claude/relaxed-shannon-jusywa
claude/fervent-keller-s6f2fq
claude/determined-feynman-st1y9z
claude/wizardly-einstein-vi2wce
claude/sweet-albattani-7nseio
feat/bank-sync-per-budget-file
claude/affectionate-cannon-y0kc82
claude/dependabot-findings-m9pgmb
claude/mac-app-ios-publish-zjs1lz
claude/vigilant-tesla-aiiyos
depot-migrate-secrets-1781296330308
claude/quirky-cerf-v5qck7
claude/animation-removal-alternative-2etfh1
claude/netlify-preview-comments-consolidate-9XPYa
osc/7391-error-boundaries-reports
claude/pensive-dijkstra-7DYui
claude/server-app-version-mismatch-HTCGv
claude/pr-8027-review-feedback-mELuO
claude/zealous-wozniak-e5pO0
claude/intelligent-heisenberg-BSHJq
claude/translation-download-refactor-jFRsO
claude/mobile-performance-ideas-G9PAO
claude/github-issue-7988-5A5ly
blacksmith-migration-ff70d2d
claude/great-mayer-KRvOk
claude/react-native-ios-compilation-fcJh5
claude/serene-goldberg-58xv0
claude/kind-euler-LVG3K
release-automation/edge-nightly
7710-bundle-migrations
claude/fix-docker-build-error-WMfed
claude/llm-compatible-release-notes-t20Nr
7710-tests-tdd
cursor/transaction-table-rewrite-f077
claude/plan-ci-secure-context-OtEe1
claude/fix-issue-7667-DPXi3
cursor/resolve-pr-7449-ee11
claude/fix-typescript-build-error-JPtZ5
copilot/add-repository-configs-to-packages
worktree-compressed-drifting-ritchie
claude/api-consumer-verification-kfz1K
pr-7454
claude/fix-issue-7410-LLLQ4
revert-7281-generate-icons
react-query-useSchedules
copilot/sub-pr-6140
package-upgrades
v26.7.0
v26.6.0
v26.5.2
v26.5.1
v26.5.0
v26.4.0
v26.3.0
v26.2.1
v26.2.0
v26.1.0
v25.12.0
v25.11.0
v25.10.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.1
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.1
v25.2.0
v25.1.0
v24.12.0
v24.11.0
v24.10.1
v24.10.0
v24.9.0
v24.8.0
v24.7.0
v24.6.0
v24.5.0
v24.4.0
v24.3.0
v24.2.0
v24.1.0
v23.12.0
v23.11.0
v23.10.0
v23.9.0
v23.8.1
v23.8.0
v23.7.2
v23.7.1
v23.7.0
v23.6.0
v23.5.0
v23.4.2
v23.4.1
v23.4.0
v23.3.2
v23.3.0
v23.2.9
v23.2.5
v23.1.12
v22.12.9
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
Mirrored from GitHub Pull Request
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#119446
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/actualbudget/actual/pull/3185
Author: @MikesGlitch
Created: 8/3/2024
Status: ✅ Merged
Merged: 8/20/2024
Merged by: @youngcw
Base:
master← Head:electron/windows-arch-32-64-arm📝 Commits (10+)
57bd7fbpackaging different architectures for windows5f7f3bfappx for the windows store app hostinga2c0e1cremove unneeded applicationid3a7d03aMerge branch 'actualbudget:master' into electron/windows-arch-32-64-arm97bf4abadding windows store assets137579aadding images918d1aaappx added to artifacts0864fc1add appx to releaseda44ca1remove override build params4c540c4being specific about the mac build - default is dmg📊 Changes
90 files changed (+51 additions, -5 deletions)
View changed files
📝
.github/workflows/electron-master.yml(+9 -0)📝
.github/workflows/electron-pr.yml(+8 -0)➕
packages/desktop-electron/appx/LargeTile.png(+0 -0)➕
packages/desktop-electron/appx/LargeTile.scale-100.png(+0 -0)➕
packages/desktop-electron/appx/LargeTile.scale-125.png(+0 -0)➕
packages/desktop-electron/appx/LargeTile.scale-150.png(+0 -0)➕
packages/desktop-electron/appx/LargeTile.scale-200.png(+0 -0)➕
packages/desktop-electron/appx/LargeTile.scale-400.png(+0 -0)➕
packages/desktop-electron/appx/SmallTile.png(+0 -0)➕
packages/desktop-electron/appx/SmallTile.scale-100.png(+0 -0)➕
packages/desktop-electron/appx/SmallTile.scale-125.png(+0 -0)➕
packages/desktop-electron/appx/SmallTile.scale-150.png(+0 -0)➕
packages/desktop-electron/appx/SmallTile.scale-200.png(+0 -0)➕
packages/desktop-electron/appx/SmallTile.scale-400.png(+0 -0)➕
packages/desktop-electron/appx/SplashScreen.scale-100.png(+0 -0)➕
packages/desktop-electron/appx/SplashScreen.scale-125.png(+0 -0)➕
packages/desktop-electron/appx/SplashScreen.scale-150.png(+0 -0)➕
packages/desktop-electron/appx/SplashScreen.scale-200.png(+0 -0)➕
packages/desktop-electron/appx/SplashScreen.scale-400.png(+0 -0)➕
packages/desktop-electron/appx/Square150x150Logo.png(+0 -0)...and 70 more files
📄 Description
The current windows release is built only for x64 (the architecture the build machine is using). Nobody's complained yet, but if someone comes along with an Arm CPU it wont work.
With this change we're publishing NSIS and APPX (windows store) installers for Windows, in the following architectures
The NSIS files:
These files should be kept - they allow users to install without going to the Microsoft Appstore.
The AppX files:
The AppX files are used for the Microsoft Appstore. We've chosen the AppX over the .exe because the AppX installers are recommended, and allow us to host the files on the Windows hosting service.
NOTE: There's a lot of images in here but I think it's necessary. It's to cover all of Windows's scenarios - taskbar icons, start menu, different screen sizes, light/dark mode etc. We're forced to use at minimum 4/5 icons, but it looks terrible.
**In the future: ** we will automate the release using GitHub actions. For now it's manual because there are tweaks being made to the store listing and every change takes 3(ish) days for Microsoft to approve.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.