[PR #3186] [MERGED] (vrt) improving stability - rules test #11785

Closed
opened 2026-04-10 21:10:19 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3186
Author: @MatissJanis
Created: 8/3/2024
Status: Merged
Merged: 8/3/2024
Merged by: @MatissJanis

Base: masterHead: matiss/vert-stability


📝 Commits (2)

  • 71307e9 (vrt) improving stability - rules test
  • 7262916 Update VRT

📊 Changes

5 files changed (+7 additions, -1 deletions)

View changed files

📝 packages/desktop-client/e2e/rules.test.js (+1 -1)
📝 packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-3-chromium-linux.png (+0 -0)
upcoming-release-notes/3186.md (+6 -0)

📄 Description

The problem example: https://github.com/actualbudget/actual/pull/2892/files#diff-e4d886dbca1d6ee9741c3229ca49f7ac3277117edca2bd38727602d285295000

The text seems to be focused sometimes. A relatively simple fix would be to click away after searching (which removes focus). So moving the search operation before create. This would create the extra click and thus make the VRT stable again.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3186 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 8/3/2024 **Status:** ✅ Merged **Merged:** 8/3/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/vert-stability` --- ### 📝 Commits (2) - [`71307e9`](https://github.com/actualbudget/actual/commit/71307e99ce154240af5f37e4a94624d8598db998) :white_check_mark: (vrt) improving stability - rules test - [`7262916`](https://github.com/actualbudget/actual/commit/72629161f076b707f0a33b7a997cae66a966a49c) Update VRT ### 📊 Changes **5 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/rules.test.js` (+1 -1) 📝 `packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-3-chromium-linux.png` (+0 -0) ➕ `upcoming-release-notes/3186.md` (+6 -0) </details> ### 📄 Description The problem example: https://github.com/actualbudget/actual/pull/2892/files#diff-e4d886dbca1d6ee9741c3229ca49f7ac3277117edca2bd38727602d285295000 The text seems to be focused sometimes. A relatively simple fix would be to click away after searching (which removes focus). So moving the search operation before create. This would create the extra click and thus make the VRT stable again. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 21:10:19 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#11785