github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-11 01:18:59 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #3169] [MERGED] Fix budget type toggle not working the first time #11776

New Issue
Closed
opened 2026-04-10 21:10:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 21:10:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3169
Author: @YusefOuda
Created: 7/31/2024
Status: ✅ Merged
Merged: 8/1/2024
Merged by: @MatissJanis

Base: master ← Head: bugfix/budget-type-fix

📝 Commits (3)

  • b038165 use default 'rollover' for budgetType localPref
  • 2f68cc9 Merge branch 'master' into bugfix/budget-type-fix
  • 75055f3 release notes

📊 Changes

6 files changed (+11 additions, -7 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/index.tsx (+1 -2)
📝 packages/desktop-client/src/components/mobile/budget/index.tsx (+1 -2)
📝 packages/desktop-client/src/components/settings/BudgetTypeSettings.tsx (+1 -1)
📝 packages/desktop-client/src/components/settings/Experimental.tsx (+1 -1)
➕ upcoming-release-notes/3169.md (+6 -0)

📄 Description

Issue: When switching from "rollover" budget to "report" budget for the first time, the toggle doesn't actually work. This is because the localPref budgetType does not have a value initially, and the logic did not handle that so it attempts to toggle to a "rollover" budget (when it is already by default a "rollover")

const newBudgetType = budgetType === 'rollover' ? 'report' : 'rollover';

This PR fixes that issue by defaulting the localPref to "rollover" (also fixed it in other files where we use that localPref.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3169 **Author:** [@YusefOuda](https://github.com/YusefOuda) **Created:** 7/31/2024 **Status:** ✅ Merged **Merged:** 8/1/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `bugfix/budget-type-fix` --- ### 📝 Commits (3) - [`b038165`](https://github.com/actualbudget/actual/commit/b0381652e2e00dae694763be03f730a269720129) use default 'rollover' for budgetType localPref - [`2f68cc9`](https://github.com/actualbudget/actual/commit/2f68cc97560116f3703bab2f4b268da519dcb841) Merge branch 'master' into bugfix/budget-type-fix - [`75055f3`](https://github.com/actualbudget/actual/commit/75055f3631b96a197f9e1afbc531687a53109d85) release notes ### 📊 Changes **6 files changed** (+11 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+1 -2) 📝 `packages/desktop-client/src/components/mobile/budget/index.tsx` (+1 -2) 📝 `packages/desktop-client/src/components/settings/BudgetTypeSettings.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/settings/Experimental.tsx` (+1 -1) ➕ `upcoming-release-notes/3169.md` (+6 -0) </details> ### 📄 Description **Issue**: When switching from "rollover" budget to "report" budget for the first time, the toggle doesn't actually work. This is because the localPref `budgetType` does not have a value initially, and the logic did not handle that so it attempts to toggle to a "rollover" budget (when it is already by default a "rollover") `const newBudgetType = budgetType === 'rollover' ? 'report' : 'rollover';` This PR fixes that issue by defaulting the localPref to "rollover" (also fixed it in other files where we use that localPref. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 21:10:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#11776
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?